GNU bug report logs - #37534
[PATCH] gnu: conky: Activate Pulseaudio support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37534 in the body.
You can then email your comments to 37534 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vasile Dumitrascu <va511e <at> yahoo.com>
To: guix-patches <at> gnu.org
Cc: Vasile Dumitrascu <va511e <at> yahoo.com>
Subject: [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Fri, 27 Sep 2019 22:32:51 +0200

* gnu/packages/conky.scm (conky):
  [inputs] Add pulseaudio.
---
 gnu/packages/conky.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/conky.scm b/gnu/packages/conky.scm
index 681feb6e43..046d132a9b 100644
--- a/gnu/packages/conky.scm
+++ b/gnu/packages/conky.scm
@@ -2,6 +2,7 @@
 ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
 ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -31,6 +32,7 @@
   #:use-module (gnu packages lua)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages xorg))
 
 (define-public conky
@@ -51,7 +53,8 @@
     (arguments
      `(#:tests? #f                      ; there are no tests
        #:configure-flags
-       (list "-DRELEASE=true")
+       (list "-DRELEASE=true"
+             "-DBUILD_PULSEAUDIO=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'add-freetype-to-search-path
@@ -76,6 +79,7 @@
        ("libxext" ,libxext)
        ("libxft" ,libxft)
        ("libxinerama" ,libxinerama)
+       ("pulseaudio", pulseaudio)
        ("lua" ,lua)
        ("ncurses" ,ncurses)
        ("curl" ,curl)))
-- 
2.23.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Vasile Dumitrascu via Guix-patches <guix-patches <at> gnu.org>
Cc: 37534 <at> debbugs.gnu.org, Vasile Dumitrascu <va511e <at> yahoo.com>
Subject: Re: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Sat, 28 Sep 2019 00:50:10 +0200

[Message part 1 (text/plain, inline)]

Vasile,

Vasile Dumitrascu via Guix-patches via 写道：
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
>  ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice 
>  <me <at> tobias.gr>
>  ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>

Does this show up as corrupted in your mailbox as well?  (‘??’ 
instead of ‘©’.)

> @@ -76,6 +79,7 @@
>         ("libxext" ,libxext)
>         ("libxft" ,libxft)
>         ("libxinerama" ,libxinerama)
> +       ("pulseaudio", pulseaudio)
>         ("lua" ,lua)
>         ("ncurses" ,ncurses)
>         ("curl" ,curl)))

I guess any hope of alphabetical ordering was lost long ago.

The change looks fine to me, but could you try fixing the text 
encoding?

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dumitrascu Vasile <va511e <at> yahoo.com>
To: Vasile Dumitrascu via Guix-patches <guix-patches <at> gnu.org>, 
 Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 37534 <at> debbugs.gnu.org
Subject: Re: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Sat, 28 Sep 2019 09:02:12 +0000 (UTC)

[Message part 1 (text/plain, inline)]

  Hi Tobias
Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as I guess the encoding issues were caused by git send-mail.
  Thank you again,    Vasile

    On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:  
 
 Vasile,

Vasile Dumitrascu via Guix-patches via 写道：
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
>  ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice 
>  <me <at> tobias.gr>
>  ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>

Does this show up as corrupted in your mailbox as well?  (‘??’ 
instead of ‘©’.)

> @@ -76,6 +79,7 @@
>        ("libxext" ,libxext)
>        ("libxft" ,libxft)
>        ("libxinerama" ,libxinerama)
> +      ("pulseaudio", pulseaudio)
>        ("lua" ,lua)
>        ("ncurses" ,ncurses)
>        ("curl" ,curl)))

I guess any hope of alphabetical ordering was lost long ago.

The change looks fine to me, but could you try fixing the text 
encoding?

Thanks!

T G-R  

[Message part 2 (text/html, inline)]

[0001-gnu-conky-Activate-Pulseaudio-support.patch (text/x-patch, attachment)]

Message #22 received at 37534-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37534-done <at> debbugs.gnu.org
Cc: Dumitrascu Vasile <va511e <at> yahoo.com>
Subject: Re: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Tue, 01 Oct 2019 18:16:32 +0200

[Message part 1 (text/plain, inline)]

Vasile,

Thanks for the patch!  I've pushed it as 
18edc9db02658c597695905121a9df68e9118ab8 with miniscule changes to 
the commit message.

Dumitrascu Vasile 写道：
>   Hi Tobias
> Thank you for the review and sorry to have missed the sorting.

Oh, er, sorry you're sorry; no need to be.  All I meant by ‘any 
hope lost’ was that there's no way to make the entire list sorted 
without moving unrelated lines around (e.g. curl).  But your new 
compromise is a better compromise.  Thank you!

> I have re-attached the original patch as a file to this email, 
> as I guess the encoding issues were caused by git send-mail.

‘git send-email’ has one job, so it should do it really well.  I 
send all my patches in-line and have never had trouble.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.