GNU bug report logs -
#37534
[PATCH] gnu: conky: Activate Pulseaudio support.
Previous Next
Reported by: Vasile Dumitrascu <va511e <at> yahoo.com>
Date: Fri, 27 Sep 2019 20:34:01 UTC
Severity: normal
Tags: patch
Done: Tobias Geerinckx-Rice <me <at> tobias.gr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37534 in the body.
You can then email your comments to 37534 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#37534
; Package
guix-patches
.
(Fri, 27 Sep 2019 20:34:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Vasile Dumitrascu <va511e <at> yahoo.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Fri, 27 Sep 2019 20:34:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/conky.scm (conky):
[inputs] Add pulseaudio.
---
gnu/packages/conky.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/conky.scm b/gnu/packages/conky.scm
index 681feb6e43..046d132a9b 100644
--- a/gnu/packages/conky.scm
+++ b/gnu/packages/conky.scm
@@ -2,6 +2,7 @@
;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -31,6 +32,7 @@
#:use-module (gnu packages lua)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages pulseaudio)
#:use-module (gnu packages xorg))
(define-public conky
@@ -51,7 +53,8 @@
(arguments
`(#:tests? #f ; there are no tests
#:configure-flags
- (list "-DRELEASE=true")
+ (list "-DRELEASE=true"
+ "-DBUILD_PULSEAUDIO=ON")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'add-freetype-to-search-path
@@ -76,6 +79,7 @@
("libxext" ,libxext)
("libxft" ,libxft)
("libxinerama" ,libxinerama)
+ ("pulseaudio", pulseaudio)
("lua" ,lua)
("ncurses" ,ncurses)
("curl" ,curl)))
--
2.23.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#37534
; Package
guix-patches
.
(Fri, 27 Sep 2019 22:51:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Vasile,
Vasile Dumitrascu via Guix-patches via 写道:
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
> ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
> ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice
> <me <at> tobias.gr>
> ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>
Does this show up as corrupted in your mailbox as well? (‘??’
instead of ‘©’.)
> @@ -76,6 +79,7 @@
> ("libxext" ,libxext)
> ("libxft" ,libxft)
> ("libxinerama" ,libxinerama)
> + ("pulseaudio", pulseaudio)
> ("lua" ,lua)
> ("ncurses" ,ncurses)
> ("curl" ,curl)))
I guess any hope of alphabetical ordering was lost long ago.
The change looks fine to me, but could you try fixing the text
encoding?
Thanks!
T G-R
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#37534
; Package
guix-patches
.
(Fri, 27 Sep 2019 22:51:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#37534
; Package
guix-patches
.
(Sat, 28 Sep 2019 09:03:02 GMT)
Full text and
rfc822 format available.
Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Tobias
Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as I guess the encoding issues were caused by git send-mail.
Thank you again, Vasile
On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
Vasile,
Vasile Dumitrascu via Guix-patches via 写道:
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
> ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
> ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice
> <me <at> tobias.gr>
> ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>
Does this show up as corrupted in your mailbox as well? (‘??’
instead of ‘©’.)
> @@ -76,6 +79,7 @@
> ("libxext" ,libxext)
> ("libxft" ,libxft)
> ("libxinerama" ,libxinerama)
> + ("pulseaudio", pulseaudio)
> ("lua" ,lua)
> ("ncurses" ,ncurses)
> ("curl" ,curl)))
I guess any hope of alphabetical ordering was lost long ago.
The change looks fine to me, but could you try fixing the text
encoding?
Thanks!
T G-R
[Message part 2 (text/html, inline)]
[0001-gnu-conky-Activate-Pulseaudio-support.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#37534
; Package
guix-patches
.
(Sat, 28 Sep 2019 09:03:02 GMT)
Full text and
rfc822 format available.
Reply sent
to
Tobias Geerinckx-Rice <me <at> tobias.gr>
:
You have taken responsibility.
(Tue, 01 Oct 2019 16:17:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Vasile Dumitrascu <va511e <at> yahoo.com>
:
bug acknowledged by developer.
(Tue, 01 Oct 2019 16:17:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 37534-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Vasile,
Thanks for the patch! I've pushed it as
18edc9db02658c597695905121a9df68e9118ab8 with miniscule changes to
the commit message.
Dumitrascu Vasile 写道:
> Hi Tobias
> Thank you for the review and sorry to have missed the sorting.
Oh, er, sorry you're sorry; no need to be. All I meant by ‘any
hope lost’ was that there's no way to make the entire list sorted
without moving unrelated lines around (e.g. curl). But your new
compromise is a better compromise. Thank you!
> I have re-attached the original patch as a file to this email,
> as I guess the encoding issues were caused by git send-mail.
‘git send-email’ has one job, so it should do it really well. I
send all my patches in-line and have never had trouble.
Kind regards,
T G-R
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 30 Oct 2019 11:24:07 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 171 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.