GNU bug report logs - #37553
[PATCH] inferior: Change to using guix-repl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37553 in the body.
You can then email your comments to 37553 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] inferior: Change to using guix-repl.
Date: Sun, 29 Sep 2019 14:01:28 +0100

Rather than machine-repl, that was removed in [1]. While this could work if
the %load-path is such that a module that defines machine-repl is loaded, I
believe the intent is that the (guix scripts repl) module comes from the Guix
managing the inferior. Therefore, matching the changes in [1], switch to
calling the guix-repl function with the right arguments.

1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679

* guix/inferior.scm (inferior-pipe): Call guix-repl, rather than machine-repl,
and add necessary arguments.
---
 guix/inferior.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/inferior.scm b/guix/inferior.scm
index dcbc954432..7c0143062b 100644
--- a/guix/inferior.scm
+++ b/guix/inferior.scm
@@ -137,7 +137,8 @@ it's an old Guix."
                        `(begin
                           (primitive-load ,(search-path %load-path
                                                         "guix/scripts/repl.scm"))
-                          ((@ (guix scripts repl) machine-repl))))))
+                          ((@ (guix scripts repl) guix-repl)
+                           "-t" "machine")))))
         pipe)))
 
 (define* (port->inferior pipe #:optional (close close-port))
-- 
2.23.0

Message #8 received at 37553 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 37553 <at> debbugs.gnu.org
Subject: [PATCH] inferior: Change to use the (guix repl) module.
Date: Sun, 29 Sep 2019 16:20:04 +0100

Rather than (guix scripts repl), from which the machine-repl procedure was
removed in [1].

1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679

* guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
scripts repl).
---
 guix/inferior.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/inferior.scm b/guix/inferior.scm
index dcbc954432..dcffb7b4ab 100644
--- a/guix/inferior.scm
+++ b/guix/inferior.scm
@@ -137,7 +137,7 @@ it's an old Guix."
                        `(begin
                           (primitive-load ,(search-path %load-path
                                                         "guix/scripts/repl.scm"))
-                          ((@ (guix scripts repl) machine-repl))))))
+                          ((@ (guix repl) machine-repl))))))
         pipe)))
 
 (define* (port->inferior pipe #:optional (close close-port))
-- 
2.23.0

Message #11 received at 37553 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 37553 <at> debbugs.gnu.org
Subject: [PATCH] inferior: Change to use the (guix repl) module.
Date: Sun, 29 Sep 2019 16:57:28 +0100

Rather than (guix scripts repl), from which the machine-repl procedure was
removed in [1].

1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679

* guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
scripts repl).
---
 guix/inferior.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/inferior.scm b/guix/inferior.scm
index dcbc954432..d6d2053ab8 100644
--- a/guix/inferior.scm
+++ b/guix/inferior.scm
@@ -136,8 +136,8 @@ it's an old Guix."
                       (object->string
                        `(begin
                           (primitive-load ,(search-path %load-path
-                                                        "guix/scripts/repl.scm"))
-                          ((@ (guix scripts repl) machine-repl))))))
+                                                        "guix/repl.scm"))
+                          ((@ (guix repl) machine-repl))))))
         pipe)))
 
 (define* (port->inferior pipe #:optional (close close-port))
-- 
2.23.0

Message #14 received at 37553 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 37553 <at> debbugs.gnu.org
Subject: Re: [bug#37553] [PATCH] inferior: Change to use the (guix repl)
 module.
Date: Tue, 01 Oct 2019 10:56:05 +0200

Hi,

Christopher Baines <mail <at> cbaines.net> skribis:

> Rather than (guix scripts repl), from which the machine-repl procedure was
> removed in [1].
>
> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679
>
> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
> scripts repl).
> ---
>  guix/inferior.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/inferior.scm b/guix/inferior.scm
> index dcbc954432..d6d2053ab8 100644
> --- a/guix/inferior.scm
> +++ b/guix/inferior.scm
> @@ -136,8 +136,8 @@ it's an old Guix."
>                        (object->string
>                         `(begin
>                            (primitive-load ,(search-path %load-path
> -                                                        "guix/scripts/repl.scm"))
> -                          ((@ (guix scripts repl) machine-repl))))))
> +                                                        "guix/repl.scm"))
> +                          ((@ (guix repl) machine-repl))))))
>          pipe)))

This one LGTM!

(Note that this code is only used when spawning an inferior for a
revision that dates back to before ‘guix repl’ existed, so before July
2018.)

Thanks,
Ludo’.

Message #19 received at 37553-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37553-done <at> debbugs.gnu.org
Subject: Re: [bug#37553] [PATCH] inferior: Change to use the (guix repl)
 module.
Date: Tue, 01 Oct 2019 20:26:56 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Rather than (guix scripts repl), from which the machine-repl procedure was
>> removed in [1].
>>
>> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679
>>
>> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
>> scripts repl).
>> ---
>>  guix/inferior.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/inferior.scm b/guix/inferior.scm
>> index dcbc954432..d6d2053ab8 100644
>> --- a/guix/inferior.scm
>> +++ b/guix/inferior.scm
>> @@ -136,8 +136,8 @@ it's an old Guix."
>>                        (object->string
>>                         `(begin
>>                            (primitive-load ,(search-path %load-path
>> -                                                        "guix/scripts/repl.scm"))
>> -                          ((@ (guix scripts repl) machine-repl))))))
>> +                                                        "guix/repl.scm"))
>> +                          ((@ (guix repl) machine-repl))))))
>>          pipe)))
>
> This one LGTM!

Great :) I've pushed it as 2cd599f005bb91ae120a66824b8efbac81a27a69.

> (Note that this code is only used when spawning an inferior for a
> revision that dates back to before ‘guix repl’ existed, so before July
> 2018.)

Yep, I've been experimenting with loading older revisions in to the Guix
Data Service, and this is one of the issues I came across.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 37553-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 37553-done <at> debbugs.gnu.org
Subject: Re: [bug#37553] [PATCH] inferior: Change to use the (guix repl)
 module.
Date: Wed, 02 Oct 2019 11:30:06 +0200

Hi,

Christopher Baines <mail <at> cbaines.net> skribis:

> Yep, I've been experimenting with loading older revisions in to the Guix
> Data Service, and this is one of the issues I came across.

Nice!  I’ve been thinking we should have time-traveling continuous
integration.  Like checking that we can build some Guix revision of the
past in between two ‘core-updates’ merges.

It would also be useful to flag known-bad revisions, but in a way the
Data Service is already doing that for recent revisions.

Thanks,
Ludo’.

Message #25 received at 37553-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37553-done <at> debbugs.gnu.org
Subject: Re: [bug#37553] [PATCH] inferior: Change to use the (guix repl)
 module.
Date: Sun, 06 Oct 2019 09:46:27 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Yep, I've been experimenting with loading older revisions in to the Guix
>> Data Service, and this is one of the issues I came across.
>
> Nice!  I’ve been thinking we should have time-traveling continuous
> integration.  Like checking that we can build some Guix revision of the
> past in between two ‘core-updates’ merges.
>
> It would also be useful to flag known-bad revisions, but in a way the
> Data Service is already doing that for recent revisions.

So I've been looking at retrying failed jobs in the Guix Data Service,
there are a few where it's just networking issues talking to Savannah.

I guess it could be useful to have a list of revisions which can't be
used through guix pull or a channel, and that information could also be
used in the Guix Data Service.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 37553-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 37553-done <at> debbugs.gnu.org
Subject: Re: [bug#37553] [PATCH] inferior: Change to use the (guix repl)
 module.
Date: Sun, 06 Oct 2019 10:58:15 +0200

Hi Chris,

Christopher Baines <mail <at> cbaines.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hi,
>>
>> Christopher Baines <mail <at> cbaines.net> skribis:
>>
>>> Yep, I've been experimenting with loading older revisions in to the Guix
>>> Data Service, and this is one of the issues I came across.
>>
>> Nice!  I’ve been thinking we should have time-traveling continuous
>> integration.  Like checking that we can build some Guix revision of the
>> past in between two ‘core-updates’ merges.
>>
>> It would also be useful to flag known-bad revisions, but in a way the
>> Data Service is already doing that for recent revisions.
>
> So I've been looking at retrying failed jobs in the Guix Data Service,
> there are a few where it's just networking issues talking to Savannah.

Cool.

> I guess it could be useful to have a list of revisions which can't be
> used through guix pull or a channel, and that information could also be
> used in the Guix Data Service.

Yes, thanks for looking into it!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.