GNU bug report logs - #37567
[PATCH] gnu: pulseaudio: Add optional X11 inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37567 in the body.
You can then email your comments to 37567 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: pulseaudio: Add optional X11 inputs.
Date: Tue, 01 Oct 2019 12:42:06 +0200

[Message part 1 (text/plain, inline)]

Hello Guix,

Pulseaudio is currently built without the optional X11 modules (e.g
module-x11-bell, which makes it possible to customize the x11-bell
sound).  This patch adds those X11 libraries to Pulseaudios's inputs,
which are necessary for the modules to be built.

Regards,

Diego

[0001-gnu-pulseaudio-Add-optional-X11-inputs.patch (text/x-patch, inline)]

From 3bcfda0a26a572b6789a469ea6da4d384db4be47 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Date: Tue, 1 Oct 2019 11:31:42 +0200
Subject: [PATCH] gnu: pulseaudio: Add optional X11 inputs.

* gnu/packages/pulseaudio.scm (pulseaudio)[inputs]: Add libxcb, libice, libsm,
  and libxtst.
---
 gnu/packages/pulseaudio.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index fa48d8a7a6..f0f8574078 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -50,7 +50,8 @@
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages python-web)
   #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages xiph))
+  #:use-module (gnu packages xiph)
+  #:use-module (gnu packages xorg))
 
 (define-public libsndfile
   (package
@@ -187,6 +188,10 @@ rates.")
        ("libltdl" ,libltdl)
        ("fftwf" ,fftwf)
        ("avahi" ,avahi)
+       ("libxcb" ,libxcb)   ; For enabling X11.
+       ("libice" ,libice)   ; For enabling X11.
+       ("libsm" ,libsm)     ; For enabling X11.
+       ("libxtst" ,libxtst) ; For enabling X11.
        ("eudev" ,eudev)))         ;for the detection of hardware audio devices
     (native-inputs
      `(("check" ,check)
-- 
2.23.0

Message #10 received at 37567-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>, 37567-done <at> debbugs.gnu.org
Subject: Re: [bug#37567] [PATCH] gnu: pulseaudio: Add optional X11 inputs.
Date: Sun, 13 Oct 2019 23:09:45 +0200

[Message part 1 (text/plain, inline)]

Diego Nicola Barbato <dnbarbato <at> posteo.de> writes:

> Hello Guix,
>
> Pulseaudio is currently built without the optional X11 modules (e.g
> module-x11-bell, which makes it possible to customize the x11-bell
> sound).  This patch adds those X11 libraries to Pulseaudios's inputs,
> which are necessary for the modules to be built.

This patch increases the size of pulseaudio from 187.2 MiB to 189.4 MiB,
which is OK IMO.

Pushed to 'staging' with a minor cosmetic change in 531b63eba7.

Thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.