GNU bug report logs - #37570
[PATCH] gnu: gtk+: Add libxrandr input.

Previous Next

Package: guix-patches;

Reported by: Ingo Ruhnke <grumbel <at> gmail.com>

Date: Tue, 1 Oct 2019 14:32:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37570 in the body.
You can then email your comments to 37570 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37570; Package guix-patches. (Tue, 01 Oct 2019 14:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ingo Ruhnke <grumbel <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 01 Oct 2019 14:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ingo Ruhnke <grumbel <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gtk+: Add libxrandr input.
Date: Tue,  1 Oct 2019 14:25:32 +0200
This fixes multi-monitor issues in XFCE and other Gtk+ apps.

* gnu/packages/gtk.scm: Add libxrandr input.
---
 gnu/packages/gtk.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 12972b75df..55c24c774c 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -753,6 +753,7 @@ application suites.")
       ("libxinerama" ,libxinerama)
       ("libxkbcommon" ,libxkbcommon)
       ("libxdamage" ,libxdamage)
+      ("libxrandr" ,libxrandr)
       ("mesa" ,mesa)
       ("pango" ,pango)
       ("wayland" ,wayland)
-- 
2.20.1





Information forwarded to guix-patches <at> gnu.org:
bug#37570; Package guix-patches. (Tue, 01 Oct 2019 23:56:02 GMT) Full text and rfc822 format available.

Message #8 received at 37570 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ingo Ruhnke <grumbel <at> gmail.com>
Cc: 37570 <at> debbugs.gnu.org
Subject: Re: [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
Date: Wed, 2 Oct 2019 01:55:52 +0200
[Message part 1 (text/plain, inline)]
Hmm, gtk+ has a huge number of dependents.

Also, shouldn't gtk+ already have libxrandr in its inputs by virtue of gtk+
inheriting from gtk+-2, which does have it in its inputs?  Why doesn't it
work without the patch?

I suspect that other (xfce) packages actually should require libxrandr in THEIR
inputs, and it's missing there.

Of course adding it to propagated-inputs of gtk+ would "fix" (work around) the
problem, but that's usually not the correct place for it.



[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#37570; Package guix-patches. (Wed, 02 Oct 2019 18:47:01 GMT) Full text and rfc822 format available.

Message #11 received at 37570 <at> debbugs.gnu.org (full text, mbox):

From: Ingo Ruhnke <grumbel <at> gmail.com>
To: 37570 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
Date: Wed, 2 Oct 2019 20:46:25 +0200
[Message part 1 (text/plain, inline)]
The issue with Xfce specifically was that "gdk_monitor_get_model()" would
return NULL instead of the proper name and all the multi-monitor handling
would fall apart in turn, that seems like an gtk issue, not an Xfce issue.

As for "propagated-inputs", I put it there because that's where all the
other X11 libraries already are. Don't know exactly why, but it seems to
cause xrandr show up in the pkgconfig file which it wouldn't otherwise:

pkgconfig/gdk-3.0.pc:
Requires.private: ... xrandr ...
[Message part 2 (text/html, inline)]

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Wed, 09 Oct 2019 16:59:02 GMT) Full text and rfc822 format available.

Notification sent to Ingo Ruhnke <grumbel <at> gmail.com>:
bug acknowledged by developer. (Wed, 09 Oct 2019 16:59:02 GMT) Full text and rfc822 format available.

Message #16 received at 37570-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ingo Ruhnke <grumbel <at> gmail.com>, 37570-done <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
Date: Wed, 09 Oct 2019 18:58:23 +0200
[Message part 1 (text/plain, inline)]
Hello Ingo,

Ingo Ruhnke <grumbel <at> gmail.com> writes:

> The issue with Xfce specifically was that "gdk_monitor_get_model()" would
> return NULL instead of the proper name and all the multi-monitor handling
> would fall apart in turn, that seems like an gtk issue, not an Xfce issue.
>
> As for "propagated-inputs", I put it there because that's where all the
> other X11 libraries already are. Don't know exactly why, but it seems to
> cause xrandr show up in the pkgconfig file which it wouldn't otherwise:
>
> pkgconfig/gdk-3.0.pc:
> Requires.private: ... xrandr ...

Thank you very much for this debugging work and patch.  Pushed to the
'staging' branch in 52b61e999101724c7e2d341586e9a6150614f208.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 07 Nov 2019 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 143 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.