GNU bug report logs - #37594
Menu rearrangement

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37594 in the body.
You can then email your comments to 37594 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Menu rearrangement
Date: Thu, 03 Oct 2019 00:27:37 +0300

[Message part 1 (text/plain, inline)]

Tags: patch

The most suitable place for the new tab commands is below
window and frame commands in the File menu.

Since this makes the menu too long, this patch moves the
print related commands into a new submenu.

Also it adds new menu items for two new commands,
and renames 'grep' to 'rgrep' that is more user-friendly.

Finally, it advertises easier to understand bindings C-x <right>
and C-x <left> instead of XF86Forward and XF86Back that are
too confusing for users as these questions indicate
https://stackoverflow.com/questions/21239706/which-keys-are-xf86back-and-xf86forward-in-emacs

[menu-rearrangement.patch (text/x-diff, inline)]

diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0be1458798..4c5450f050 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -933,9 +933,11 @@ esc-map
 (define-key ctl-x-map [right] 'next-buffer)
 (define-key ctl-x-map [C-right] 'next-buffer)
 (define-key global-map [XF86Forward] 'next-buffer)
+(put 'next-buffer :advertised-binding [?\C-x right])
 (define-key ctl-x-map [left] 'previous-buffer)
 (define-key ctl-x-map [C-left] 'previous-buffer)
 (define-key global-map [XF86Back] 'previous-buffer)
+(put 'previous-buffer :advertised-binding [?\C-x left])
 
 (let ((map minibuffer-local-map))
   (define-key map "\en"   'next-history-element)
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index b7967b858a..f5dbadce10 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -49,6 +49,36 @@ cua-enable-cua-keys
 ;; It gets modified in place when menu-bar-update-buffers is called.
 (defvar global-buffers-menu-map (make-sparse-keymap "Buffers"))
 
+(defvar menu-bar-print-menu
+  (let ((menu (make-sparse-keymap "Print")))
+    (bindings--define-key menu [ps-print-region]
+      '(menu-item "PostScript Print Region (B+W)" ps-print-region
+                  :enable mark-active
+                  :help "Pretty-print marked region in black and white to PostScript printer"))
+    (bindings--define-key menu [ps-print-buffer]
+      '(menu-item "PostScript Print Buffer (B+W)" ps-print-buffer
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Pretty-print current buffer in black and white to PostScript printer"))
+    (bindings--define-key menu [ps-print-region-faces]
+      '(menu-item "PostScript Print Region"
+                  ps-print-region-with-faces
+                  :enable mark-active
+                  :help "Pretty-print marked region to PostScript printer"))
+    (bindings--define-key menu [ps-print-buffer-faces]
+      '(menu-item "PostScript Print Buffer"
+                  ps-print-buffer-with-faces
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Pretty-print current buffer to PostScript printer"))
+    (bindings--define-key menu [print-region]
+      '(menu-item "Print Region" print-region
+                  :enable mark-active
+                  :help "Print region between mark and current position"))
+    (bindings--define-key menu [print-buffer]
+      '(menu-item "Print Buffer" print-buffer
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Print current buffer with page headings"))
+    menu))
+
 ;; Only declared obsolete (and only made a proper alias) in 23.3.
 (define-obsolete-variable-alias
   'menu-bar-files-menu 'menu-bar-file-menu "22.1")
@@ -63,6 +93,19 @@ menu-bar-file-menu
     (bindings--define-key menu [separator-exit]
       menu-bar-separator)
 
+    (unless (featurep 'ns)
+      (bindings--define-key menu [close-tab]
+        '(menu-item "Close Tab" tab-close
+                    :visible (fboundp 'tab-close)
+                    :help "Close currently selected tab"))
+      (bindings--define-key menu [make-tab]
+        '(menu-item "New Tab" tab-new
+                    :visible (fboundp 'tab-new)
+                    :help "Open a new tab"))
+
+      (bindings--define-key menu [separator-tab]
+        menu-bar-separator))
+
     ;; Don't use delete-frame as event name because that is a special
     ;; event.
     (bindings--define-key menu [delete-this-frame]
@@ -70,6 +113,10 @@ menu-bar-file-menu
                   :visible (fboundp 'delete-frame)
                   :enable (delete-frame-enabled-p)
                   :help "Delete currently selected frame"))
+    (bindings--define-key menu [make-frame-on-monitor]
+      '(menu-item "New Frame on Monitor..." make-frame-on-monitor
+                  :visible (fboundp 'make-frame-on-monitor)
+                  :help "Open a new frame on another monitor"))
     (bindings--define-key menu [make-frame-on-display]
       '(menu-item "New Frame on Display..." make-frame-on-display
                   :visible (fboundp 'make-frame-on-display)
@@ -102,32 +149,8 @@ menu-bar-file-menu
     (bindings--define-key menu [separator-window]
       menu-bar-separator)
 
-    (bindings--define-key menu [ps-print-region]
-      '(menu-item "PostScript Print Region (B+W)" ps-print-region
-                  :enable mark-active
-                  :help "Pretty-print marked region in black and white to PostScript printer"))
-    (bindings--define-key menu [ps-print-buffer]
-      '(menu-item "PostScript Print Buffer (B+W)" ps-print-buffer
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Pretty-print current buffer in black and white to PostScript printer"))
-    (bindings--define-key menu [ps-print-region-faces]
-      '(menu-item "PostScript Print Region"
-                  ps-print-region-with-faces
-                  :enable mark-active
-                  :help "Pretty-print marked region to PostScript printer"))
-    (bindings--define-key menu [ps-print-buffer-faces]
-      '(menu-item "PostScript Print Buffer"
-                  ps-print-buffer-with-faces
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Pretty-print current buffer to PostScript printer"))
-    (bindings--define-key menu [print-region]
-      '(menu-item "Print Region" print-region
-                  :enable mark-active
-                  :help "Print region between mark and current position"))
-    (bindings--define-key menu [print-buffer]
-      '(menu-item "Print Buffer" print-buffer
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Print current buffer with page headings"))
+    (bindings--define-key menu [print]
+      `(menu-item "Print" ,menu-bar-print-menu))
 
     (bindings--define-key menu [separator-print]
       menu-bar-separator)
@@ -1216,6 +1239,12 @@ menu-bar-showhide-menu
                                   (frame-visible-p
                                    (symbol-value 'speedbar-frame))))))
 
+    (bindings--define-key menu [showhide-tab-line-mode]
+      '(menu-item "Window Tab Line" global-tab-line-mode
+                  :help "Turn window-local tab-lines on/off"
+                  :visible (fboundp 'global-tab-line-mode)
+                  :button (:toggle . global-tab-line-mode)))
+
     (bindings--define-key menu [showhide-window-divider]
       `(menu-item "Window Divider" ,menu-bar-showhide-window-divider-menu
                   :visible (memq (window-system) '(x w32))))
@@ -1242,13 +1271,14 @@ menu-bar-showhide-menu
                               (frame-parameter (menu-bar-frame-for-menubar)
                                                'menu-bar-lines)))))
 
-    (bindings--define-key menu [showhide-tab-bar]
-      '(menu-item "Tab Bar" toggle-tab-bar-mode-from-frame
-                  :help "Turn tab bar on/off"
-                  :button
-                  (:toggle . (menu-bar-positive-p
-                              (frame-parameter (menu-bar-frame-for-menubar)
-                                               'tab-bar-lines)))))
+    (unless (featurep 'ns)
+      (bindings--define-key menu [showhide-tab-bar]
+        '(menu-item "Tab Bar" toggle-tab-bar-mode-from-frame
+                    :help "Turn tab bar on/off"
+                    :button
+                    (:toggle . (menu-bar-positive-p
+                                (frame-parameter (menu-bar-frame-for-menubar)
+                                                 'tab-bar-lines))))))
 
     (if (and (boundp 'menu-bar-showhide-tool-bar-menu)
              (keymapp menu-bar-showhide-tool-bar-menu))
@@ -1698,8 +1728,8 @@ menu-bar-tools-menu
     (bindings--define-key menu [compile]
       '(menu-item "Compile..." compile
                   :help "Invoke compiler or Make, view compilation errors"))
-    (bindings--define-key menu [grep]
-      '(menu-item "Search Files (Grep)..." grep
+    (bindings--define-key menu [rgrep]
+      '(menu-item "Search Files (Recursive Grep)..." rgrep
                   :help "Search files for strings or regexps (with Grep)"))
     menu))
 

Message #8 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Thu, 03 Oct 2019 20:09:23 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Thu, 03 Oct 2019 00:27:37 +0300
> 
> The most suitable place for the new tab commands is below
> window and frame commands in the File menu.
> 
> Since this makes the menu too long, this patch moves the
> print related commands into a new submenu.

Please move the "Print" part after the New Frame, New Window, etc.

> Also it adds new menu items for two new commands,
> and renames 'grep' to 'rgrep' that is more user-friendly.

Why rename?  People are accustomed to see "Grep".  If you think Rgrep
is so useful as to warrant a menu item, let's add it.

These changes should be in NEWS.

Thanks.

Message #11 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Fri, 04 Oct 2019 01:43:37 +0300

[Message part 1 (text/plain, inline)]

>> The most suitable place for the new tab commands is below
>> window and frame commands in the File menu.
>>
>> Since this makes the menu too long, this patch moves the
>> print related commands into a new submenu.
>
> Please move the "Print" part after the New Frame, New Window, etc.

Moved in a new patch.

>> Also it adds new menu items for two new commands,
>> and renames 'grep' to 'rgrep' that is more user-friendly.
>
> Why rename?

Only to keep the same menu size.

> People are accustomed to see "Grep".  If you think Rgrep
> is so useful as to warrant a menu item, let's add it.

Ok, added in a new patch.

> These changes should be in NEWS.

Added as well:

[menu-rearrangement.2.patch (text/x-diff, inline)]

diff --git a/etc/NEWS b/etc/NEWS
index 00a01999a7..39cafb5142 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2094,6 +2094,9 @@ immediately.  Type 'M-x so-long-commentary' for full documentation.
 
 * Incompatible Lisp Changes in Emacs 27.1
 
+---
+** Print menu items in the File menu moved to submenu.
+
 ---
 ** Incomplete destructive splicing support has been removed.
 Support for Common Lisp style destructive splicing (",.") was
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index b7967b858a..f0ab5b41d5 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -49,6 +49,36 @@ cua-enable-cua-keys
 ;; It gets modified in place when menu-bar-update-buffers is called.
 (defvar global-buffers-menu-map (make-sparse-keymap "Buffers"))
 
+(defvar menu-bar-print-menu
+  (let ((menu (make-sparse-keymap "Print")))
+    (bindings--define-key menu [ps-print-region]
+      '(menu-item "PostScript Print Region (B+W)" ps-print-region
+                  :enable mark-active
+                  :help "Pretty-print marked region in black and white to PostScript printer"))
+    (bindings--define-key menu [ps-print-buffer]
+      '(menu-item "PostScript Print Buffer (B+W)" ps-print-buffer
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Pretty-print current buffer in black and white to PostScript printer"))
+    (bindings--define-key menu [ps-print-region-faces]
+      '(menu-item "PostScript Print Region"
+                  ps-print-region-with-faces
+                  :enable mark-active
+                  :help "Pretty-print marked region to PostScript printer"))
+    (bindings--define-key menu [ps-print-buffer-faces]
+      '(menu-item "PostScript Print Buffer"
+                  ps-print-buffer-with-faces
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Pretty-print current buffer to PostScript printer"))
+    (bindings--define-key menu [print-region]
+      '(menu-item "Print Region" print-region
+                  :enable mark-active
+                  :help "Print region between mark and current position"))
+    (bindings--define-key menu [print-buffer]
+      '(menu-item "Print Buffer" print-buffer
+                  :enable (menu-bar-menu-frame-live-and-visible-p)
+                  :help "Print current buffer with page headings"))
+    menu))
+
 ;; Only declared obsolete (and only made a proper alias) in 23.3.
 (define-obsolete-variable-alias
   'menu-bar-files-menu 'menu-bar-file-menu "22.1")
@@ -63,6 +93,25 @@ menu-bar-file-menu
     (bindings--define-key menu [separator-exit]
       menu-bar-separator)
 
+    (bindings--define-key menu [print]
+      `(menu-item "Print" ,menu-bar-print-menu))
+
+    (bindings--define-key menu [separator-print]
+      menu-bar-separator)
+
+    (unless (featurep 'ns)
+      (bindings--define-key menu [close-tab]
+        '(menu-item "Close Tab" tab-close
+                    :visible (fboundp 'tab-close)
+                    :help "Close currently selected tab"))
+      (bindings--define-key menu [make-tab]
+        '(menu-item "New Tab" tab-new
+                    :visible (fboundp 'tab-new)
+                    :help "Open a new tab"))
+
+      (bindings--define-key menu [separator-tab]
+        menu-bar-separator))
+
     ;; Don't use delete-frame as event name because that is a special
     ;; event.
     (bindings--define-key menu [delete-this-frame]
@@ -70,6 +119,10 @@ menu-bar-file-menu
                   :visible (fboundp 'delete-frame)
                   :enable (delete-frame-enabled-p)
                   :help "Delete currently selected frame"))
+    (bindings--define-key menu [make-frame-on-monitor]
+      '(menu-item "New Frame on Monitor..." make-frame-on-monitor
+                  :visible (fboundp 'make-frame-on-monitor)
+                  :help "Open a new frame on another monitor"))
     (bindings--define-key menu [make-frame-on-display]
       '(menu-item "New Frame on Display..." make-frame-on-display
                   :visible (fboundp 'make-frame-on-display)
@@ -102,36 +155,6 @@ menu-bar-file-menu
     (bindings--define-key menu [separator-window]
       menu-bar-separator)
 
-    (bindings--define-key menu [ps-print-region]
-      '(menu-item "PostScript Print Region (B+W)" ps-print-region
-                  :enable mark-active
-                  :help "Pretty-print marked region in black and white to PostScript printer"))
-    (bindings--define-key menu [ps-print-buffer]
-      '(menu-item "PostScript Print Buffer (B+W)" ps-print-buffer
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Pretty-print current buffer in black and white to PostScript printer"))
-    (bindings--define-key menu [ps-print-region-faces]
-      '(menu-item "PostScript Print Region"
-                  ps-print-region-with-faces
-                  :enable mark-active
-                  :help "Pretty-print marked region to PostScript printer"))
-    (bindings--define-key menu [ps-print-buffer-faces]
-      '(menu-item "PostScript Print Buffer"
-                  ps-print-buffer-with-faces
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Pretty-print current buffer to PostScript printer"))
-    (bindings--define-key menu [print-region]
-      '(menu-item "Print Region" print-region
-                  :enable mark-active
-                  :help "Print region between mark and current position"))
-    (bindings--define-key menu [print-buffer]
-      '(menu-item "Print Buffer" print-buffer
-                  :enable (menu-bar-menu-frame-live-and-visible-p)
-                  :help "Print current buffer with page headings"))
-
-    (bindings--define-key menu [separator-print]
-      menu-bar-separator)
-
     (bindings--define-key menu [recover-session]
       '(menu-item "Recover Crashed Session" recover-session
                   :enable
@@ -1216,6 +1239,12 @@ menu-bar-showhide-menu
                                   (frame-visible-p
                                    (symbol-value 'speedbar-frame))))))
 
+    (bindings--define-key menu [showhide-tab-line-mode]
+      '(menu-item "Window Tab Line" global-tab-line-mode
+                  :help "Turn window-local tab-lines on/off"
+                  :visible (fboundp 'global-tab-line-mode)
+                  :button (:toggle . global-tab-line-mode)))
+
     (bindings--define-key menu [showhide-window-divider]
       `(menu-item "Window Divider" ,menu-bar-showhide-window-divider-menu
                   :visible (memq (window-system) '(x w32))))
@@ -1242,13 +1271,14 @@ menu-bar-showhide-menu
                               (frame-parameter (menu-bar-frame-for-menubar)
                                                'menu-bar-lines)))))
 
-    (bindings--define-key menu [showhide-tab-bar]
-      '(menu-item "Tab Bar" toggle-tab-bar-mode-from-frame
-                  :help "Turn tab bar on/off"
-                  :button
-                  (:toggle . (menu-bar-positive-p
-                              (frame-parameter (menu-bar-frame-for-menubar)
-                                               'tab-bar-lines)))))
+    (unless (featurep 'ns)
+      (bindings--define-key menu [showhide-tab-bar]
+        '(menu-item "Tab Bar" toggle-tab-bar-mode-from-frame
+                    :help "Turn tab bar on/off"
+                    :button
+                    (:toggle . (menu-bar-positive-p
+                                (frame-parameter (menu-bar-frame-for-menubar)
+                                                 'tab-bar-lines))))))
 
     (if (and (boundp 'menu-bar-showhide-tool-bar-menu)
              (keymapp menu-bar-showhide-tool-bar-menu))
@@ -1698,6 +1728,9 @@ menu-bar-tools-menu
     (bindings--define-key menu [compile]
       '(menu-item "Compile..." compile
                   :help "Invoke compiler or Make, view compilation errors"))
+    (bindings--define-key menu [rgrep]
+      '(menu-item "Recursive Grep..." rgrep
+                  :help "Interactively ask for parameters and search recursively"))
     (bindings--define-key menu [grep]
       '(menu-item "Search Files (Grep)..." grep
                   :help "Search files for strings or regexps (with Grep)"))

Message #14 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Fri, 04 Oct 2019 10:37:23 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 37594 <at> debbugs.gnu.org
> Date: Fri, 04 Oct 2019 01:43:37 +0300
> 
>  * Incompatible Lisp Changes in Emacs 27.1

This entry should go into the "Changes" section, as it is not a
Lisp-level change, it's a user-level change.

> +---
> +** Print menu items in the File menu moved to submenu.

I suggest to name the entry "The File menu-bar menu was re-arranged"
and describe also the new entries for tabs there.

Thanks.

Message #17 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Thu, 28 Nov 2019 00:36:20 +0200

>>  * Incompatible Lisp Changes in Emacs 27.1
>
> This entry should go into the "Changes" section, as it is not a
> Lisp-level change, it's a user-level change.
>
>> +---
>> +** Print menu items in the File menu moved to submenu.
>
> I suggest to name the entry "The File menu-bar menu was re-arranged"
> and describe also the new entries for tabs there.

Installed with these changes.

Message #20 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Wed, 15 Jan 2020 02:04:21 +0200

>>> +** Print menu items in the File menu moved to submenu.
>>
>> I suggest to name the entry "The File menu-bar menu was re-arranged"
>> and describe also the new entries for tabs there.
>
> Installed with these changes.

Also a very useful command async-shell-command has no menu item.
I propose to add a new submenu  "Shell" and add to it two existing
menu items "Shell command" and "Shell command on region",
and two new items "Async shell command" and "Run shell":

Shell:
  Shell command
  Shell command on region
  Async shell command
  Run shell

Also noticed there is no lazy-count menu item in Isearch menu.
Should it be?

diff --git a/lisp/isearch.el b/lisp/isearch.el
index c987393725..25f7cba8e0 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -572,6 +572,11 @@ isearch-menu-bar-map
                   :help "Search for literal char"))
     (define-key map [isearch-special-char-separator]
       '(menu-item "--"))
+    (bindings--define-key map [isearch-lazy-count]
+      (menu-bar-make-toggle toggle-isearch-lazy-count isearch-lazy-count
+                            "Hit count"
+                            "Indication of hit count %s"
+                            "Indicate hit count, globally"))
     (define-key map [isearch-toggle-word]
       '(menu-item "Word matching" isearch-toggle-word
                   :help "Word matching"

Message #23 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Wed, 15 Jan 2020 18:14:27 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 37594 <at> debbugs.gnu.org
> Date: Wed, 15 Jan 2020 02:04:21 +0200
> 
> Also a very useful command async-shell-command has no menu item.
> I propose to add a new submenu  "Shell" and add to it two existing
> menu items "Shell command" and "Shell command on region",
> and two new items "Async shell command" and "Run shell":
> 
> Shell:

I prefer "Shell Commands"

>   Shell command
>   Shell command on region
>   Async shell command
>   Run shell

"Run shell interactively", I think.

> Also noticed there is no lazy-count menu item in Isearch menu.
> Should it be?

Is it important enough to have there?

Message #26 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Thu, 16 Jan 2020 01:30:57 +0200

>> Also a very useful command async-shell-command has no menu item.
>> I propose to add a new submenu  "Shell" and add to it two existing
>> menu items "Shell command" and "Shell command on region",
>> and two new items "Async shell command" and "Run shell":
>> 
>> Shell:
>
> I prefer "Shell Commands"
>
>>   Shell command
>>   Shell command on region
>>   Async shell command
>>   Run shell
>
> "Run shell interactively", I think.

Done.

>> Also noticed there is no lazy-count menu item in Isearch menu.
>> Should it be?
>
> Is it important enough to have there?

Right, this is a customizable user option that is not important here.

BTW, I can't believe there is no desktop-mode activation from the menu bar.
Under "Options" there is "Save Place in Files between Sessions",
but no menu item for saving windows/tabs/frames in the desktop file.
How about adding below the above a new menu option with a title like
"Save Sessions (with buffers and windows)"

Message #29 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Thu, 16 Jan 2020 16:40:01 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 37594 <at> debbugs.gnu.org
> Date: Thu, 16 Jan 2020 01:30:57 +0200
> 
> BTW, I can't believe there is no desktop-mode activation from the menu bar.
> Under "Options" there is "Save Place in Files between Sessions",
> but no menu item for saving windows/tabs/frames in the desktop file.
> How about adding below the above a new menu option with a title like
> "Save Sessions (with buffers and windows)"

Fine with me, but "Save Sessions" is not the right title for this
feature.  Something like "Save Emacs State" or "Save Desktop", I
think.

Message #32 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Fri, 17 Jan 2020 02:24:51 +0200

>> BTW, I can't believe there is no desktop-mode activation from the menu bar.
>> Under "Options" there is "Save Place in Files between Sessions",
>> but no menu item for saving windows/tabs/frames in the desktop file.
>> How about adding below the above a new menu option with a title like
>> "Save Sessions (with buffers and windows)"
>
> Fine with me, but "Save Sessions" is not the right title for this
> feature.  Something like "Save Emacs State" or "Save Desktop", I
> think.

Referring to Desktop is what I tried to avoid in the menu.
The name Desktop says nothing to the user who doesn't know
that the package name is desktop.el.

The Info node name describing this feature is named
"Saving Emacs Sessions", this is why "Save Session"
makes sense.  Also the same node says: "save the state of Emacs",
so maybe a good name would be "Save State between Sessions"
where "between Sessions" is the same text that is already
presented in "Save Place in Files between Sessions".

Message #35 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Fri, 17 Jan 2020 10:20:08 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 37594 <at> debbugs.gnu.org
> Date: Fri, 17 Jan 2020 02:24:51 +0200
> 
> > Fine with me, but "Save Sessions" is not the right title for this
> > feature.  Something like "Save Emacs State" or "Save Desktop", I
> > think.
> 
> Referring to Desktop is what I tried to avoid in the menu.
> The name Desktop says nothing to the user who doesn't know
> that the package name is desktop.el.

Using a word that happens to be the package name does have its
advantages.

> The Info node name describing this feature is named
> "Saving Emacs Sessions", this is why "Save Session"
> makes sense.

the Info node has the whole node to explain what "saving an Emacs
session" means in this context.  The menu item doesn't have that
luxury.

> Also the same node says: "save the state of Emacs",
> so maybe a good name would be "Save State between Sessions"

Fine with me, thanks.

Message #38 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Mon, 20 Jan 2020 02:15:04 +0200

tags 37594 fixed
close 37594 27.0.60
quit

>> Also the same node says: "save the state of Emacs",
>> so maybe a good name would be "Save State between Sessions"
>
> Fine with me, thanks.

Done.

There are many other commands that could be added to the menu, but
at least these were the ones whose absence in the menu was noticeable,
so I'm closing this report.

Message #45 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Mon, 20 Jan 2020 19:11:42 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 37594 <at> debbugs.gnu.org
> Date: Mon, 20 Jan 2020 02:15:04 +0200
> 
> tags 37594 fixed
> close 37594 27.0.60
> quit
> 
> >> Also the same node says: "save the state of Emacs",
> >> so maybe a good name would be "Save State between Sessions"
> >
> > Fine with me, thanks.
> 
> Done.

Thanks, but this should have gone to master, not to the release
branch.  We are not adding new features to the release branch at this
time.  Please move it to master.

Message #48 received at 37594 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37594 <at> debbugs.gnu.org
Subject: Re: bug#37594: Menu rearrangement
Date: Tue, 21 Jan 2020 01:10:11 +0200

> Thanks, but this should have gone to master, not to the release
> branch.  We are not adding new features to the release branch at this
> time.  Please move it to master.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.