GNU bug report logs - #37603
[PATCH] gnu: Add aha.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Wiktor Żelazny <wz@HIDDEN>; Keywords: patch; dated Thu, 3 Oct 2019 14:18:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 37603 <at> debbugs.gnu.org:


Received: (at 37603) by debbugs.gnu.org; 3 Oct 2019 14:47:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 03 10:47:19 2019
Received: from localhost ([127.0.0.1]:40753 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iG2Nz-0008OY-8H
	for submit <at> debbugs.gnu.org; Thu, 03 Oct 2019 10:47:19 -0400
Received: from tobias.gr ([80.241.217.52]:56350)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1iG2Ns-0008Gq-Ow
 for 37603 <at> debbugs.gnu.org; Thu, 03 Oct 2019 10:47:17 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id de063743;
 Thu, 3 Oct 2019 14:47:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=UrhuTTEI1Jg5jFOvR9ljUz
 k9rJl/E3OjEKkbqVI3Pws=; b=KxWOcRKHpfCL2JlpKBdsTq6uPqqHmmm4g6qzkG
 MjbwGMvkA1KAOh/BFu6Rf7y1e6NCi2ZS1YPjRGZheYsdKhBEQp6H/Yyamx/lLFes
 kg2/OShOQCsdGUl8I8z/nRygr5YGgydAdooVZsdoZu1dnuB01Opv2SuYKCzTW92/
 +JGZ4buY51qvOJOgXhA5eNyqMtCc07yPrN5foSCLNvQbqDMnbY+XcI5ZpQJKJ0mC
 Hebwxab28XeAkwRvUh5ds6nEa1aeQg4CLtawJjyNChQXsect+hQOuxdAllWrDJ8a
 QAfCqnh2LMROhEH9qyPVlfunC5jSEFhZjS2zNmtJRtVXsAIQ==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 761a6c18
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 3 Oct 2019 14:47:08 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Wiktor =?utf-8?Q?=C5=BBelazny?= <wz@HIDDEN>
Subject: Re: [bug#37603] [PATCH] gnu: Add aha.
References: <20191003141529.3940-1-wz@HIDDEN>
In-reply-to: <20191003141529.3940-1-wz@HIDDEN>
Date: Thu, 03 Oct 2019 16:47:07 +0200
Message-ID: <87wodl51jo.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37603
Cc: 37603 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Wiktor,

Thanks for the patch!  This isn't a review, just an answer to your=20
question:

Wiktor =C5=BBelazny =E5=86=99=E9=81=93=EF=BC=9A
> Hi, This is the first time that I=E2=80=99m submitting something that=20
> uses the
> git-fetch method. I tried to follow the manual. Unfortunately,=20
> it does
> not explain the role of this "0.9" string. I noticed that other
> contributors use various values. I left it at "0.9".

It's not a random value; it's the last =E2=80=98real=E2=80=99 release, thin=
k of it=20
as =E2=80=98release 0.9 + some more commits that were needed for some=20
reason=E2=80=99.  If the project has never seen a release, =E2=80=980.0.0=
=E2=80=99 is=20
used.  You'll find that this is quite common, too.

At https://github.com/theZiz/aha/releases, we can see that the=20
last release before this commit was =E2=80=980.5=E2=80=99, so that's what y=
ou=20
should use.

However: we prefer packaging releases, not arbitrary commits.  Why=20
not package 0.5?  If it's because it's old (it is) and missing=20
cool features, consider asking the author to cut a new release.

Whatever the case, please note the reason in a comment: =E2=80=98The last=20
release 0.5 is missing the vital foo feature and/or crashes on=20
Fridays=E2=80=99.

Since I'm here (still not a review! :-):

> +        (revision "1"))          ;Guix package revision

I know you probably copied this from elsewhere, but don't think=20
this comment adds anything.

> +                (url "git://github.com/theZiz/aha.git")

Please use https:// instead of git://.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl2WCesACgkQ2Imw8BjF
STyjSQ/+MtkPQ6hJN21N4lwpr3CAgp0V2aR9hZL2VLSUPhsUsLdWyf22qCROAiV9
lodqm219qc0ATd+SAkC4EA0W6p8w+QecSP8C/PhklvjVChx3SyvguEENl1z0Y25E
oAiAWteURK2iKggwlHbJCMgOHpf8ok12IOEToOM+q5PNtfy57spqMG0IQox0ZZJq
YkDByqP+wLzY0cde71+Ajoj980FwMh1gr4HzyyWjoKrMOSDC3ya1apm/8f9PvEEc
KaPbw3XJwEIAbULVNms3lITshV2Sh7GjmV9JJu6Q8Xp8THlzFqw7gnJgHOE5MQNn
PZD4Tyet5r8YoaktBb0tbM8sli+0Ff9jwIkwJjt0lmsLydAJvUlKrdj03w4r6aCw
vuURIqQvbi+VhlSBtINTkns4I2ANi5Qi0Xcltp7puduADRdzROUT3MQvxOjAQkLs
vNBeqhvw7VmW3RepKAUjvF2fpeedXw8hOwhZ89uGNVlJxyDPAb8RDFPj68iTnLgL
QA6zCCBsG3Jc977R+NRaUiYe2hPOMiinGOnBwpDGWSu1d+qWd47FG/APlyl27oAK
vd34fVlO7yr5K4LhS0hQrZbozip8YRyqOvKY7StPw6ih/LrAuEpO4rke516SSqAF
LaJ7hGoXJqSROozPOsCacWLT3kKQZoDHfCAlOn9tzszVKNrmNsE=
=U5Lu
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37603; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 3 Oct 2019 14:17:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 03 10:17:53 2019
Received: from localhost ([127.0.0.1]:40703 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iG1vU-0005gW-Up
	for submit <at> debbugs.gnu.org; Thu, 03 Oct 2019 10:17:53 -0400
Received: from lists.gnu.org ([209.51.188.17]:54244)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <wz@HIDDEN>) id 1iG1vT-0005gP-HS
 for submit <at> debbugs.gnu.org; Thu, 03 Oct 2019 10:17:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60454)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <wz@HIDDEN>) id 1iG1vS-0005DJ-2l
 for guix-patches@HIDDEN; Thu, 03 Oct 2019 10:17:51 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <wz@HIDDEN>) id 1iG1vP-00088H-9C
 for guix-patches@HIDDEN; Thu, 03 Oct 2019 10:17:49 -0400
Received: from freeshell.de ([2a01:360:106::2]:45337)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <wz@HIDDEN>) id 1iG1vO-00083X-QY
 for guix-patches@HIDDEN; Thu, 03 Oct 2019 10:17:47 -0400
From: =?UTF-8?q?Wiktor=20=C5=BBelazny?= <wz@HIDDEN>
DKIM-Filter: OpenDKIM Filter v2.9.2 freeshell.de E25AB35CC340
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freeshell.de;
 s=mail; t=1570112260;
 bh=VUrKJCcXLnkhKVyM7HX+a0x00x8fVeM63inC9yPvKyo=;
 h=From:To:Subject:Date;
 b=exiSQctb9itCCdRkBSIW9zvXv9OHdhKWkR51Tmk9G0vH34x12n8bRl0+9mrdylFMx
 4PRqmciij2khNBQHV8B5XATY/mkCl1Z4JrieZztlCTdf93kKrXJvV7wg6C7hH2TdZ8
 3Lx1T9vC1SPGVchrYaUmZkQ5Q3odpZpWxf4MUF4w=
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add aha.
Date: Thu,  3 Oct 2019 16:15:29 +0200
Message-Id: <20191003141529.3940-1-wz@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a01:360:106::2
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

From: Wiktor =C5=BBelazny <wzelazny@HIDDEN>

* gnu/packages/textutils.scm (aha): new variable.
---
Hi, This is the first time that I=E2=80=99m submitting something that use=
s the
git-fetch method. I tried to follow the manual. Unfortunately, it does
not explain the role of this "0.9" string. I noticed that other
contributors use various values. I left it at "0.9".
 gnu/packages/textutils.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 79cf172179..1bf5a4fb1b 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -17,6 +17,7 @@
 ;;; Copyright =C2=A9 2018 Pierre Neidhardt <mail@HIDDEN>
 ;;; Copyright =C2=A9 2018 Meiyo Peng <meiyo.peng@HIDDEN>
 ;;; Copyright =C2=A9 2019 Yoshinori Arai <kumagusu08@HIDDEN>
+;;; Copyright =C2=A9 2019 Wiktor =C5=BBelazny <wzelazny@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1011,3 +1012,32 @@ instance one can add new syntax elements to markdo=
wn, etc.
=20
 This package provides Python bindings.")
     (license license:bsd-3)))
+
+(define-public aha
+  (let ((commit "2592da4330b4df6d482a631f4a35543b96f4744d")
+        (revision "1"))          ;Guix package revision
+    (package
+      (name "aha")
+      (version (git-version "0.9" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+                (url "git://github.com/theZiz/aha.git")
+                (commit commit)))
+         (sha256
+          (base32
+           "0fq81ibxqg27b3860wmqd4zym2mymkr7sgvfhsyl0kb7ck367w4q"))
+         (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       '(#:phases (modify-phases %standard-phases (delete 'configure))
+         #:make-flags (list "CC=3Dgcc"
+                            (string-append "PREFIX=3D"
+                                           (assoc-ref %outputs "out")))
+         #:tests? #f)) ; no check target
+      (home-page "https://github.com/theZiz/aha")
+      (synopsis "Ansi HTML Adapter")
+      (description "@code{aha} converts ANSI escape sequences of a Unix =
terminal
+to HTML code.")
+      (license (list license:lgpl2.0+ license:mpl1.1)))))
--=20
2.23.0





Acknowledgement sent to Wiktor Żelazny <wz@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#37603; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 3 Oct 2019 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.