GNU bug report logs - #37615
27.0.50; package-test-macro-compilation fails

Previous Next

Package: emacs;

Reported by: Eli Zaretskii <eliz <at> gnu.org>

Date: Fri, 4 Oct 2019 08:14:02 UTC

Severity: normal

Tags: fixed

Merged with 42534

Found in versions 27.0.50, 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37615 in the body.
You can then email your comments to 37615 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 04 Oct 2019 08:14:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Eli Zaretskii <eliz <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 04 Oct 2019 08:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; package-test-macro-compilation fails
Date: Fri, 04 Oct 2019 11:13:09 +0300
I just did the obvious:

  cd test
  make lisp/emacs-lisp/package-tests.log

and got this:

  Test package-test-macro-compilation backtrace:
    signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
    ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal
    (if (unwind-protect (setq value-77 (apply fn-75 args-76)) (setq form
    (let (form-description-79) (if (unwind-protect (setq value-77 (apply
    (let ((value-77 'ert-form-evaluation-aborted-78)) (let (form-descrip
    (let* ((fn-75 #'equal) (args-76 (condition-case err (let ((signal-ho
    (progn nil (package-install-file (expand-file-name "macro-problem-pa
    (unwind-protect (progn nil (package-install-file (expand-file-name "
    (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
    (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b
    (progn (fset 'y-or-n-p vnew) (fset 'yes-or-no-p vnew) (let ((temp-bu
    (unwind-protect (progn (fset 'y-or-n-p vnew) (fset 'yes-or-no-p vnew
    (let* ((vnew #'(lambda (&rest r) t)) (vnew #'(lambda (&rest r) t)) (
    (progn (cd "package-resources") (if (file-directory-p package-user-d
    (unwind-protect (progn (cd "package-resources") (if (file-directory-
    (let* ((package-test-user-dir (make-temp-file "pkg-test-user-dir-" t
    (lambda nil (let* ((package-test-user-dir (make-temp-file "pkg-test-
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name package-test-macro-compilation :docum
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
    ert-run-tests-batch((not (tag :unstable)))
    ert-run-tests-batch-and-exit((not (tag :unstable)))
    eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
    command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86
    command-line()
    normal-top-level()
  Test package-test-macro-compilation condition:
      (ert-test-failed
       ((should
	 (equal
	  (macro-problem-func)
	  '...))
	:form
	(equal
	 (progn a b)
	 (1 b))
	:value nil :explanation
	(proper-lists-of-different-length 3 2
					  (progn a b)
					  (1 b)
					  first-mismatch-at 0)))
     FAILED  13/21  package-test-macro-compilation (0.796875 sec)

In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
 of 2019-10-04 built on HOME-C4E4A596F7
Repository revision: 3886a5c140b03f07c8faea7cacad0a791bc54fa5
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int --with-modules
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 50864 9234)
 (symbols 48 7160 1)
 (strings 16 18763 2090)
 (string-bytes 1 528068)
 (vectors 16 9862)
 (vector-slots 8 129461 7294)
 (floats 8 21 35)
 (intervals 40 258 0)
 (buffers 888 11))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 04 Oct 2019 08:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37615 <at> debbugs.gnu.org
Subject: Re: bug#37615: 27.0.50; package-test-macro-compilation fails
Date: Fri, 4 Oct 2019 10:23:45 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> I just did the obvious:
>
>   cd test
>   make lisp/emacs-lisp/package-tests.log
>
> and got this:
[...]
>      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
>
> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
>  of 2019-10-04 built on HOME-C4E4A596F7

Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 04 Oct 2019 08:48:02 GMT) Full text and rfc822 format available.

Message #11 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 37615 <at> debbugs.gnu.org
Subject: Re: bug#37615: 27.0.50; package-test-macro-compilation fails
Date: Fri, 04 Oct 2019 10:47:04 +0200
>>>>> On Fri, 4 Oct 2019 10:23:45 +0200, Stefan Kangas <stefan <at> marxist.se> said:

    Stefan> Eli Zaretskii <eliz <at> gnu.org> writes:
    >> I just did the obvious:
    >> 
    >> cd test
    >> make lisp/emacs-lisp/package-tests.log
    >> 
    >> and got this:
    Stefan> [...]
    >> FAILED  13/21  package-test-macro-compilation (0.796875 sec)
    >> 
    >> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
    >> of 2019-10-04 built on HOME-C4E4A596F7

    Stefan> Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Iʼm seeing it on macOS (and make bootstrap fails....)

Robert




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 04 Oct 2019 08:56:02 GMT) Full text and rfc822 format available.

Message #14 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37615 <at> debbugs.gnu.org
Subject: Re: bug#37615: 27.0.50; package-test-macro-compilation fails
Date: Fri, 04 Oct 2019 11:55:03 +0300
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Fri, 4 Oct 2019 10:23:45 +0200
> Cc: 37615 <at> debbugs.gnu.org
> 
> >   cd test
> >   make lisp/emacs-lisp/package-tests.log
> >
> > and got this:
> [...]
> >      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
> >
> > In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
> >  of 2019-10-04 built on HOME-C4E4A596F7
> 
> Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Could be.  Do you know where should I look and what additional details
to send?

In general, this test is too noisy and displays a lot of messages that
fill the screen and make it hard to find relevant parts.  So maybe I'm
missing some important clue.  For example, is any of the below related
or not?

    INFO     Scraping files for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...
  ~/macro-problem-2.0/macro-problem-autoloads.el and c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el are the same file
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...done
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...
  ~/macro-problem-2.0/macro-problem-autoloads.el and c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el are the same file
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...done
    INFO     Scraping files for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...done
  Wrote c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el
  Checking c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-pkg.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...

  In macro-problem-10-and-90:
  macro-problem.el:27:45:Warning: reference to free variable `hehe'

  In end of data:
  macro-problem.el:31:1:Warning: the function `macro-aux-3' is not known to be
      defined.




Forcibly Merged 37615 42534. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 13 Aug 2020 00:09:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 06:30:02 GMT) Full text and rfc822 format available.

Message #19 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 07:29:10 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> I just did the obvious:
>
>   cd test
>   make lisp/emacs-lisp/package-tests.log

[...]

>      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
>
> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)

I tried this (with mingw64) in Emacs 28, and this test didn't fail for
me.  Are you still seeing this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 07:55:02 GMT) Full text and rfc822 format available.

Message #22 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 09:54:34 +0200
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 37615 <at> debbugs.gnu.org,  42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 07:29:10 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I just did the obvious:
> >
> >   cd test
> >   make lisp/emacs-lisp/package-tests.log
> 
> [...]
> 
> >      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
> >
> > In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
> 
> I tried this (with mingw64) in Emacs 28, and this test didn't fail for
> me.  Are you still seeing this?

Yes (with current master).  I get this in the failure message:

  Test package-test-macro-compilation condition:
      (ert-test-failed
       ((should
	 (equal
	  (macro-problem-func)
	  '...))
	:form
	(equal
	 (progn a b)
	 (1 b))
	:value nil :explanation
	(proper-lists-of-different-length 3 2
					  (progn a b)
					  (1 b)
					  first-mismatch-at 0)))
     FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm happy to provide more details if needed, or debug this more given
some instructions.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 19:39:02 GMT) Full text and rfc822 format available.

Message #25 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 20:37:49 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

>      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm getting this failure instead (on a brand new msys2/mingw
installation): 

1 unexpected results:
   FAILED  package-test-signed

> I'm happy to provide more details if needed, or debug this more given
> some instructions.

I'm pretty unfamiliar with package.el and wholly unfamiliar with
Windows, so I'll leave that to somebody else.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 20:43:02 GMT) Full text and rfc822 format available.

Message #28 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 22:42:17 +0200
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 37615 <at> debbugs.gnu.org,  42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 20:37:49 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

First signs of trouble are here:

  In macro-problem-10-and-90:
  macro-problem.el:27:45: Warning: reference to free variable `hehe'

  In end of data:
  macro-problem.el:31:1: Warning: the function `macro-aux-3' is not known to be
      defined.

I cannot understand why this happens on MS-Windows, but not on
GNU/Linux.

> I'm getting this failure instead (on a brand new msys2/mingw
> installation): 
> 
> 1 unexpected results:
>    FAILED  package-test-signed

On my system this is skipped because gpg2 is not installed.

> > I'm happy to provide more details if needed, or debug this more given
> > some instructions.
> 
> I'm pretty unfamiliar with package.el and wholly unfamiliar with
> Windows, so I'll leave that to somebody else.

CC'ing the author of package-tests in the hope that he could suggest
some ideas for fixing this.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 20:50:02 GMT) Full text and rfc822 format available.

Message #31 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 21:49:31 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> I cannot understand why this happens on MS-Windows, but not on
> GNU/Linux.

The test that fails is this:

(ert-deftest package-test-macro-compilation ()
  "Install a package which includes a dependency."
  (with-package-test (:basedir (ert-resource-directory))
    (package-install-file (expand-file-name "macro-problem-package-1.0/"))
    (require 'macro-problem)
    ;; `macro-problem-func' uses a macro from `macro-aux'.
    (should (equal (macro-problem-func) '(progn a b)))
    (package-install-file (expand-file-name "macro-problem-package-2.0/"))
    ;; After upgrading, `macro-problem-func' depends on a new version
    ;; of the macro from `macro-aux'.
    (should (equal (macro-problem-func) '(1 b)))
    ;; `macro-problem-10-and-90' depends on an entirely new macro from `macro-aux'.
    (should (equal (macro-problem-10-and-90) '(10 90)))))

The thing that doesn't work is:

    (package-install-file (expand-file-name "macro-problem-package-2.0/"))

This does not reload the files, and that's because
package--load-files-for-activation doesn't reload them.  Which is
because package--list-loaded-files doesn't identify the files as
something that needs to be reloaded, as far as I can tell.

That function does a whole lot of comparison of file paths, and my guess
is that whatever it's doing (I'm having a hard time following the logic)
only works on GNU/Linux systems.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Fri, 25 Dec 2020 21:44:01 GMT) Full text and rfc822 format available.

Message #34 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 22:43:24 +0100
The problem on Macos seems to be that it's comparing file-truenames, but
that's not what's in the load history.  For instance,
"/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
is in load-history, but it's finding conflicts by truenaming:

(file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
=> "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"

And indeed:

larsi <at> open-catalina test % ls -ld /var
lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var

The following seems to fix the problem for me on Macos and doesn't lead
to any breakages on Debian, so I'm pushing it now.  Can you check
whether this fixes the problem on Windows?

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0170e61e12..bc450b09d0 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -830,7 +830,7 @@ package--files-load-history
         (mapcar (lambda (x)
                   (let ((f (car x)))
                     (and (stringp f)
-                         (file-name-sans-extension f))))
+                         (file-name-sans-extension (file-truename f)))))
                 load-history)))
 
 (defun package--list-of-conflicts (dir history)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Sat, 26 Dec 2020 08:40:01 GMT) Full text and rfc822 format available.

Message #37 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org, bruce.connor.am <at> gmail.com
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Sat, 26 Dec 2020 10:39:03 +0200
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Artur Malabarba <bruce.connor.am <at> gmail.com>,  37615 <at> debbugs.gnu.org,
>   42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 22:43:24 +0100
> 
> The problem on Macos seems to be that it's comparing file-truenames, but
> that's not what's in the load history.  For instance,
> "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> is in load-history, but it's finding conflicts by truenaming:
> 
> (file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
> => "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> 
> And indeed:
> 
> larsi <at> open-catalina test % ls -ld /var
> lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var
> 
> The following seems to fix the problem for me on Macos and doesn't lead
> to any breakages on Debian, so I'm pushing it now.  Can you check
> whether this fixes the problem on Windows?

Yes, thanks.

In my case, the problem was that MS-Windows (in the version I run
here) produces short 8+3 alias file names for long directory names,
the file name for temporary-file-directory didn't compare equal to
what Emacs expected, exactly as on macOS; file-truename fixed that.




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 26 Dec 2020 22:01:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 42534 <at> debbugs.gnu.org and Philipp <p.stephani2 <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 26 Dec 2020 22:01:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37615; Package emacs. (Sat, 26 Dec 2020 22:01:02 GMT) Full text and rfc822 format available.

Message #44 received at 37615 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org, bruce.connor.am <at> gmail.com
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Sat, 26 Dec 2020 23:00:35 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> In my case, the problem was that MS-Windows (in the version I run
> here) produces short 8+3 alias file names for long directory names,
> the file name for temporary-file-directory didn't compare equal to
> what Emacs expected, exactly as on macOS; file-truename fixed that.

Ah, I see.  Apparently the Windows setup I'm using (for Emacs build
tests) isn't doing the 8+3 thing (Windows 10 with msys2/mingw shell).

Anyway, thanks for checking; closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 24 Jan 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 86 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.