GNU bug report logs - #37680
[core-updates] simple-scan fails to build

Previous Next

Package: guix;

Reported by: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>

Date: Wed, 9 Oct 2019 10:58:01 UTC

Severity: normal

Merged with 37687, 37715, 37885

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37680 in the body.
You can then email your comments to 37680 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#37680; Package guix. (Wed, 09 Oct 2019 10:58:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 09 Oct 2019 10:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <bug-guix <at> gnu.org>
Subject: [core-updates] simple-scan fails to build
Date: Wed, 9 Oct 2019 12:57:26 +0200
[Message part 1 (text/plain, inline)]
After the core-updates merge, simplescan fails to build:
This is on:

525ef21ba0d4a50a7d21f5543db40b6cc328f9cd


starting phase
`build' Making all in src
make[1]: Entering directory '/tmp/guix-build-simple-scan-3.24.1.drv-0/simple-scan-3.24.1/src'
  CC       simple_scan-book.o
  CC       simple_scan-book-view.o
  CC       simple_scan-page.o
  CC       simple_scan-page-view.o
  CC       simple_scan-simple-scan.o
  CC       simple_scan-scanner.o
make[2]: Entering directory '/tmp/guix-build-simple-scan-3.24.1.drv-0/simple-scan-3.24.1/src'
  VALAC    simple_scan_vala.stamp
  CC       simple_scan-autosave-manager.o
  CC       simple_scan-resources.o
page.vala:90.5-90.39: error: Property `Page.scan_direction' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public ScanDirection scan_direction
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ui.vala:1295.25-1295.80: warning: Gtk.Arrow.new has been deprecated since 3.14
ui.vala:1867.13-1867.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1868.13-1868.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1869.13-1869.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1870.13-1870.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1871.13-1871.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1872.13-1872.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1873.13-1873.31: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
ui.vala:1019.9-1019.23: warning: Gtk.Menu.popup has been deprecated since 3.22
simple-scan.vala:130.30-130.41: error: Argument 1: Cannot convert from `unowned GLib.List<weak ScanDevice>' to `unowned GLib.List<ScanDevice>'
        ui.set_scan_devices (devices_copy, missing_driver);
                             ^^^^^^^^^^^^
Compilation failed: 2 error(s), 9 warning(s)
make[2]: *** [Makefile:655: simple_scan_vala.stamp] Error 1
make[2]: Leaving directory '/tmp/guix-build-simple-scan-3.24.1.drv-0/simple-scan-3.24.1/src'
make[1]: *** [Makefile:645: ui.c] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/tmp/guix-build-simple-scan-3.24.1.drv-0/simple-scan-3.24.1/src'
make: *** [Makefile:399: all-recursive] Error 1
command "make" "-j" "4" "gtk_update_icon_cache=true" failed with status 2


Björn
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#37680; Package guix. (Thu, 10 Oct 2019 17:23:02 GMT) Full text and rfc822 format available.

Message #8 received at 37680 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 37680 <at> debbugs.gnu.org
Subject: simple-scan builds with newer version
Date: Thu, 10 Oct 2019 13:22:50 -0400 (EDT)
[Message part 1 (text/plain, inline)]
The version of simple-scan that current in Guix, 3.24.1, which fails to 
build is a little old. I tried to update it to the version that 
numerically matches our GNOME version, 3.30.2, but that fails with the 
same problem.

However, the current newest simple-scan release, 3.34.1, does build. 
Unfortunately, I had to take the colord out of inputs or native inputs 
otherwise the build would fail with

"error: Package `colord' not found in specified Vala API directories or 
GObject-Introspection GIR directories"

and I didn't see how it was detecting colord during configure, but not 
during the build. The needs to be fixed eventually, but in the meantime I 
have prepared the following patch.

A bigger problem than colord though, is that while simple-scan now builds, 
it doesn't run. It exits after printing "Trace/breakpoint trap". I've 
attached strace output.

I'm not sure what's next, thoughts?

Best,
Jack
[simple-scan.strace (text/plain, attachment)]

Information forwarded to bug-guix <at> gnu.org:
bug#37680; Package guix. (Thu, 10 Oct 2019 17:25:01 GMT) Full text and rfc822 format available.

Message #11 received at 37680 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 37680 <at> debbugs.gnu.org
Cc: Jack Hill <jackhill <at> jackhill.us>
Subject: [PATCH] gnu: simple-scan: Update to 3.34.1
Date: Thu, 10 Oct 2019 13:23:54 -0400
* gnu/package/gnome.scm (simple-scan): Update to 3.34.1
[build-system]: Switch to meson-build-system.
[source]: Fetch from GNOME mirrors.
[inputs]: Add libwebp.
[native-inputs]: Remove colord.
[arguments]: Remove #:configure-flags. Remove 'clean phase.
[home-page]: Update to current home-page.
---
 gnu/packages/gnome.scm | 35 +++++++++++------------------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index eae62a1d06..1956a672a3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4302,48 +4302,35 @@ USB transfers with your high-level application or system daemon.")
 (define-public simple-scan
   (package
     (name "simple-scan")
-    (version "3.24.1")
+    (version "3.34.1")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/simple-scan/"
+              (uri (string-append "mirror://gnome/sources/" name "/"
                                   (version-major+minor version) "/"
-                                  version "/+download/simple-scan-"
-                                  version ".tar.xz"))
+                                  name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1czg21cdbd2fgqylxfnzfhhzy69gycf816d5bbaq6hb62hmq7bjy"))))
-    (build-system glib-or-gtk-build-system)
+                "0glzskxdc7p9z7nwcakqc7qzij4l79adlvvb2cj5fmis731zw9yq"))))
+    (build-system meson-build-system)
     (inputs
      `(("gtk" ,gtk+)
        ("zlib" ,zlib)
        ("cairo" ,cairo)
+       ;; Building with colord support fails with
+       ;; error: Package `colord' not found in specified Vala API directories or GObject-Introspection GIR directories
+       ;; ("colord-gtk" ,colord-gtk)
        ("gdk-pixbuf" ,gdk-pixbuf)
        ("gusb" ,gusb)
-       ("libsane" ,sane-backends)))
+       ("libsane" ,sane-backends)
+       ("libwebp" ,libwebp)))
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("itstool" ,itstool)
-       ("colord" ,colord)
        ("glib" ,glib "bin")                       ; glib-compile-schemas, etc.
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)
        ("xmllint" ,libxml2)))
-    (arguments
-     '(#:configure-flags '("--disable-packagekit")
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'clean
-                    (lambda _
-                      ;; Remove a left-over reference to PackageKit.
-
-                      ;; https://bugs.launchpad.net/simple-scan/+bug/1462769
-
-                      ;; There are some generated C files erroneously
-                      ;; included in the source distribution, and this
-                      ;; one breaks the build by referring to a
-                      ;; non-existent header (packagekit.h)
-                      (delete-file "src/ui.c"))))))
-    (home-page "https://launchpad.net/simple-scan")
+    (home-page "https://gitlab.gnome.org/GNOME/simple-scan")
     (synopsis "Document and image scanner")
     (description "Simple Scan is an easy-to-use application, designed to let
 users connect their scanner and quickly have the image/document in an
-- 
2.23.0





Merged 37680 37687. Request was from Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> to control <at> debbugs.gnu.org. (Thu, 10 Oct 2019 19:37:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#37680; Package guix. (Thu, 10 Oct 2019 19:46:01 GMT) Full text and rfc822 format available.

Message #16 received at 37680 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 37680 <at> debbugs.gnu.org
Subject: Re: bug#37680: simple-scan builds with newer version
Date: Thu, 10 Oct 2019 21:45:40 +0200
[Message part 1 (text/plain, inline)]
Hi Jack,

thanks for looking into this.

On Thu, 10 Oct 2019 13:22:50 -0400 (EDT)
Jack Hill <jackhill <at> jackhill.us> wrote:

> The version of simple-scan that current in Guix, 3.24.1, which fails
> to build is a little old. I tried to update it to the version that 
> numerically matches our GNOME version, 3.30.2, but that fails with
> the same problem.
> 
> However, the current newest simple-scan release, 3.34.1, does build. 
> Unfortunately, I had to take the colord out of inputs or native
> inputs otherwise the build would fail with

I was also quickly trying out the same things you did and came to the
same conclusion. I hoped to find a way around today, but I don't know
the meson-build-system and have no futher idea.

[..]

> A bigger problem than colord though, is that while simple-scan now
> builds, it doesn't run. It exits after printing "Trace/breakpoint
> trap". I've attached strace output.

Oh, sounds bad. I haven't tried to run it.
 
> I'm not sure what's next, thoughts?

No.

Björn
[Message part 2 (application/pgp-signature, inline)]

Merged 37680 37687 37885. Request was from Tobias Geerinckx-Rice <me <at> tobias.gr> to control <at> debbugs.gnu.org. (Wed, 23 Oct 2019 13:31:02 GMT) Full text and rfc822 format available.

Merged 37680 37687 37715 37885. Request was from Tobias Geerinckx-Rice <me <at> tobias.gr> to control <at> debbugs.gnu.org. (Wed, 23 Oct 2019 13:31:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 21 Nov 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 147 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.