GNU bug report logs - #37699
global-tab-line-mode and dired "*Marked Files*" buffer

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 10 Oct 2019 23:18:02 UTC

Severity: normal

Fixed in version 27.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37699 in the body.
You can then email your comments to 37699 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37699; Package emacs. (Thu, 10 Oct 2019 23:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 10 Oct 2019 23:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Fri, 11 Oct 2019 01:17:08 +0200
Steps to reproduce:

0. emacs -Q
1. M-x dired RET RET
2. M-x global-tab-line-mode
2. Mark some files using "m"
3. Type some command e.g. "!"

Result: There are tabs in the window showing the "*Marked Files*" buffer.

There should be no tabs in this window.  I believe the function
dired-mark-pop-up is where we show the marked files.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37699; Package emacs. (Sun, 20 Oct 2019 22:42:02 GMT) Full text and rfc822 format available.

Message #8 received at 37699 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37699 <at> debbugs.gnu.org
Subject: Re: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Mon, 21 Oct 2019 01:34:16 +0300
> Steps to reproduce:
>
> 0. emacs -Q
> 1. M-x dired RET RET
> 2. M-x global-tab-line-mode
> 2. Mark some files using "m"
> 3. Type some command e.g. "!"
>
> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>
> There should be no tabs in this window.  I believe the function
> dired-mark-pop-up is where we show the marked files.

I propose the following patch:

diff --git a/lisp/dired.el b/lisp/dired.el
index 3146511305..75dfbc4b9a 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3436,7 +3436,8 @@ dired-mark-pop-up
 	 (dired-format-columns-of-files
 	  (if (eq (car files) t) (cdr files) files))
 	 (remove-text-properties (point-min) (point-max)
-				 '(mouse-face nil help-echo nil)))))))
+				 '(mouse-face nil help-echo nil))
+	 (setq tab-line-format nil))))))
 
 (defun dired-format-columns-of-files (files)
   (let ((beg (point)))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37699; Package emacs. (Wed, 23 Oct 2019 21:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 37699 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37699 <at> debbugs.gnu.org
Subject: Re: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Thu, 24 Oct 2019 00:34:30 +0300
>> Steps to reproduce:
>>
>> 0. emacs -Q
>> 1. M-x dired RET RET
>> 2. M-x global-tab-line-mode
>> 2. Mark some files using "m"
>> 3. Type some command e.g. "!"
>>
>> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>>
>> There should be no tabs in this window.  I believe the function
>> dired-mark-pop-up is where we show the marked files.
>
> I propose the following patch:

This is pushed now.  Please confirm if everything is right before closing.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37699; Package emacs. (Sat, 26 Oct 2019 22:43:01 GMT) Full text and rfc822 format available.

Message #14 received at 37699 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37699 <at> debbugs.gnu.org
Subject: Re: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Sun, 27 Oct 2019 01:41:47 +0300
>>> Steps to reproduce:
>>>
>>> 0. emacs -Q
>>> 1. M-x dired RET RET
>>> 2. M-x global-tab-line-mode
>>> 2. Mark some files using "m"
>>> 3. Type some command e.g. "!"
>>>
>>> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>>>
>>> There should be no tabs in this window.  I believe the function
>>> dired-mark-pop-up is where we show the marked files.
>>
>> I propose the following patch:
>
> This is pushed now.  Please confirm if everything is right before closing.

Now pushed a better fix to set tab-line-exclude to nil
(instead of setting tab-line-format).




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37699; Package emacs. (Wed, 06 Nov 2019 23:25:02 GMT) Full text and rfc822 format available.

Message #17 received at 37699 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37699 <at> debbugs.gnu.org
Subject: Re: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Thu, 07 Nov 2019 00:24:19 +0100
close 37699 27.1
thanks

Juri Linkov <juri <at> linkov.net> writes:

>> This is pushed now.  Please confirm if everything is right before closing.
>
> Now pushed a better fix to set tab-line-exclude to nil
> (instead of setting tab-line-format).

I can confirm that this is working now, so I'll just go ahead and
close this bug.  Thanks Juri for fixing it.

Best regards,
Stefan Kangas




bug marked as fixed in version 27.1, send any further explanations to 37699 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Wed, 06 Nov 2019 23:25:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 Dec 2019 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 115 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.