GNU bug report logs - #37708
[PATCH] gnu: add uchardet

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37708 in the body.
You can then email your comments to 37708 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: add uchardet
Date: Fri, 11 Oct 2019 23:51:03 +0330

From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Date: Fri, 11 Oct 2019 23:23:21 +0330
Subject: [PATCH] gnu: add uchardet

* gnu/packages/freedesktop.scm (uchardet) New variable.
---
gnu/packages/freedesktop.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 401f54bb14..51848be170 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -14,6 +14,7 @@
;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
;;; Copyright © 2018 Stefan Stefanović <stefanx2ovic <at> gmail.com>
+;;; Copyright © 2019 Reza Alizadeh Majd <r.majd <at> pantherx.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1409,3 +1410,24 @@ This package also contains two related utilities:
their MIME type.
@end itemize")
    (license license:perl-license)))
+
+(define-public uchardet
+  (package
+    (name "uchardet")
+    (version "0.0.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://www.freedesktop.org/software/" 
+                            name "/releases/" name "-" version ".tar.xz"))
+        (sha256
+          (base32 
"0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f))
+    (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
+    (synopsis "encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a 
+sequence of bytes in an unknown character encoding without any additional 
+information, and attempts to determine the encoding of the text. Returned 
+encoding names are iconv-compatible.")
+    (license license:gpl2+)))
-- 
Regards
Reza Alizadeh Majd
PantherX Team

Message #8 received at 37708 <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: <37708 <at> debbugs.gnu.org.>
Subject: [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 01:48:08 +0330

[Message part 1 (text/plain, inline)]

It seems that my mail client brokes the patch file format so I resend the 
patch file 
as an attachment in this message again.

-- 
Regards
Reza Alizadeh Majd
PantherX Team

[0001-gnu-add-uchardet.patch (text/x-patch, attachment)]

Message #11 received at 37708 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>, 37708 <at> debbugs.gnu.org
Subject: Re: [bug#37708] [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 10:17:15 +0200

On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
"uchardet is an encoding detector library, which takes
> a +sequence of bytes in an unknown character encoding without any
> additional +information, and attempts to determine the encoding of the
> text. Returned +encoding names are iconv-compatible.")

What does this "+" do here? Are they broken texinfo syntax?

Message #14 received at 37708 <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 37708 <at> debbugs.gnu.org
Subject: Re: [bug#37708] [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 12:19:08 +0330

it seems that my mail client brokes the patch content provided in first 
message. please consider to check the attached patch file in my second 
email.


On Saturday, October 12, 2019 11:47:15 AM +0330, Jonathan Brielmaier wrote:
> On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
> "uchardet is an encoding detector library, which takes
>> a +sequence of bytes in an unknown character encoding without any
>> additional +information, and attempts to determine the encoding of the
>> text. Returned +encoding names are iconv-compatible.")
>
> What does this "+" do here? Are they broken texinfo syntax?
>
>

-- 
Regards
Reza Alizadeh Majd
PantherX Team

Message #19 received at 37708-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 37708-done <at> debbugs.gnu.org
Subject: Re: [bug#37708] [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 15:16:53 +0200

[Message part 1 (text/plain, inline)]

Hi Reza,

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
> Date: Fri, 11 Oct 2019 23:23:21 +0330
> Subject: [PATCH] gnu: add uchardet
>
> * gnu/packages/freedesktop.scm (uchardet) New variable.

Applied with the modifications below, which address ‘guix lint’ warnings
(remember to run it next time :-)), enable tests, and clarify the
license.

Thank you for the patch!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 17736aa537..4339f14f35 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1423,16 +1423,18 @@ their MIME type.
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "https://www.freedesktop.org/software/" 
+        (uri (string-append "https://www.freedesktop.org/software/"
                             name "/releases/" name "-" version ".tar.xz"))
         (sha256
           (base32 "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f))
     (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
-    (synopsis "encoding detector library")
-    (description "uchardet is an encoding detector library, which takes a 
-sequence of bytes in an unknown character encoding without any additional 
-information, and attempts to determine the encoding of the text. Returned 
+    (synopsis "Encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a
+sequence of bytes in an unknown character encoding without any additional
+information, and attempts to determine the encoding of the text.  Returned
 encoding names are iconv-compatible.")
+
+    ;; This combines code under MPL 1.1, LGPL 2.1+, and GPL 2.0+, so the
+    ;; combination is GPL 2.0+.
     (license license:gpl2+)))

Message #22 received at 37708-done <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37708-done <at> debbugs.gnu.org
Subject: Re: [bug#37708] [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 18:18:34 +0330

Hi Ludo, 

On Sat, Oct 12, 2019, at 4:46 PM, Ludovic Courtès wrote: 
> Applied with the modifications below, which address ‘guix lint’ warnings
> (remember to run it next time :-)), enable tests, and clarify the
> license.

Thanks for your notice about `guix lint`. I will keep that in mind for my later patch submissions.

-- 
Regards
Reza Alizadeh Majd
PantherX Team

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.