GNU bug report logs - #37714
Add renpy package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37714 in the body.
You can then email your comments to 37714 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: Add renpy package
Date: Sat, 12 Oct 2019 09:20:56 +0200

[Message part 1 (text/plain, inline)]

This patch adds the Ren'py Visual Novel engine split into four outputs:
- "out": contains the engine itself. Since Guix differs strongly from
the platforms Ren'py usually runs on, we ship our own Ren'py main file.
- "launcher": The Ren'py launcher, that people would normally expect
when invoking renpy -- it does not seem very usable in Guix, though.
- "the-question": An example game, that ships with Ren'py.
- "tutorial": The tutorial that ships with Ren'py.

Ren'py also ships its own version of pygame. They call it pygame_sdl2
since it's a reimplementation of pygame using SDL2, but the tags make
it very clear, that it is developed alongside Ren'py.

[0001-gnu-Add-python2-renpy.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: Re: Add renpy package
Date: Mon, 14 Oct 2019 11:00:12 +0200

[Message part 1 (text/plain, inline)]

A small fixup to correct the synopsis of python2-renpy. It should now
follow the guidelines.

[0002-gnu-python2-renpy-fix-synopsis.patch (text/x-patch, attachment)]

Message #11 received at 37714 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 37714 <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Fri, 18 Oct 2019 21:49:41 +0200

Hello,

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> This patch adds the Ren'py Visual Novel engine split into four
> outputs:

Great! It was on my TODO list, too.

> - "out": contains the engine itself. Since Guix differs strongly from
> the platforms Ren'py usually runs on, we ship our own Ren'py main file.
> - "launcher": The Ren'py launcher, that people would normally expect
> when invoking renpy -- it does not seem very usable in Guix, though.

What do you mean?

> * gnu/packages/game-development: (python2-pygame-for-renpy): New procedure.
> (python2-renpy): New variable.

New variable for both in enough, I think.

> +(define (python2-pygame-for-renpy version hash)
> +  (package
> +   (inherit python2-pygame)
> +   (name "python2-pygame-for-renpy")
> +   (version version)
> +    (source
> +     (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +            (url "https://github.com/renpy/pygame_sdl2.git")
> +            (commit (string-append "renpy-" version))))

Upstream provides a tarball for that:

  https://www.renpy.org/dl/7.3.5/pygame_sdl2-2.1.0-for-renpy-7.3.5.tar.gz

I think it is preferable using it than pointing to Github.

> +      (sha256
> +       (base32
> +        hash))

Nitpick: At least bash32 and hash could go on the same line.

> +    (home-page "http://www.renpy.org/")
> +    (synopsis "Reimplementation of the Pygame API using SDL2")

The description field is missing. Could you add one?

> +(define-public python2-renpy

"python2" prefix is for libraries. I think this one can be called
"renpy".

> +  (package
> +   (name "python2-renpy")
> +   (version "7.3.4.596")

I noticed 7.3.5 is out. Could you update it?

> +    (source
> +     (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +            (url "https://github.com/renpy/renpy.git")
> +            (commit version)))

As above, I suggest to use tarball from main site:

  https://www.renpy.org/dl/7.3.5/renpy-7.3.5-source.tar.bz2

> +         (replace 'build
> +           (lambda args
> +             (apply
> +              (lambda* (build-root #:key inputs outputs #:allow-other-keys)
> +                (chdir "module")
> +                (apply (assoc-ref %standard-phases 'build) args)
> +                (chdir build-root)
> +                (delete-file "renpy/__init__.pyc")
> +                (invoke "python" "-m" "compileall" "renpy"))
> +              (getcwd) args)
> +             #t))

This is a bit confusing because you're not really replacing `build'
phase, but wrapping stuff around it. I think it may be better to add
a `before-build' and an `after-build' phases, adding comments, if
possible, to explain why they are needed.

> +         (replace 'install
> +           (lambda args
> +             (apply
> +              (lambda* (build-root #:key inputs outputs #:allow-other-keys)
> +                (let* ((pygame (assoc-ref inputs "python2-pygame"))
> +                       (out (assoc-ref outputs "out"))
> +                       (site (string-append "/lib/python"
> +                                            ,(version-major+minor
> +                                              (package-version python-2))
> +                                            "/site-packages")))
> +                  (chdir "module")
> +                  (apply (assoc-ref %standard-phases 'install) args)
> +                  (chdir build-root)
> +                  (copy-recursively "renpy"
> +                                    (string-append out site "/renpy"))))
> +              (getcwd) args)
> +             #t))

See above. It might be more readable to use one phase before, and one
after.

> +    (inputs
> +     `(("ffmpeg" ,ffmpeg)
> +       ("freetype" ,freetype)
> +       ("glew" ,glew)
> +       ("libpng" ,libpng)
> +       ("sdl-union"
> +        ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))
> +       ("python" ,python)))

So it needs both Python 2 and Python 3?

Could you order alphabetically the inputs?

> +    (outputs
> +     (list "out" "launcher" "tutorial" "the-question"))
> +    (propagated-inputs
> +     `(("python2-pygame"
> +        ,(python2-pygame-for-renpy
> +          version
> +          "1gwbqkyv7763813x7nmzb3nz4r8673d33ggsp6lgp1d640rimlpb"))))

Could you see if there's a way to not propagate this input? What happens
if it is a simple input?

> +    (native-inputs
> +     `(("python2-cython" ,python2-cython)))
> +    (home-page "http://www.renpy.org/")
> +    (synopsis "The Ren'Py Visual Novel Engine -- libary files")
> +    (description "Ren'Py is a visual novel engine -- used by thousands of
> +creators from around the world -- that helps you use words, images, and sounds
> +to tell interactive stories that run on computers and mobile devices. These can
> +be both visual novels and life simulation games. The easy to learn script
> +language allows anyone to efficiently write large visual novels, while its
> +Python scripting is enough for complex simulation games.")

You need to add two spaces at the end of sentences.

> +    (license license:x11)))

I this should be license:expat.

Could you send an updated patch?

Thank you for the work.


Regards,

-- 
Nicolas Goaziou

Message #14 received at 37714 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 37714 <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Sat, 19 Oct 2019 22:59:14 +0200

[Message part 1 (text/plain, inline)]

After some work, I've come up with this new patchset.
- 0001 is an update of the previous 0001 with most of the issues raised
(hopefully) being addressed. It still uses git from source and wraps
the build and install phase, though.
- 0002 causes the packages to use the main site instead of git.
- 0003 splits renpy into the python package python2-renpy and the
program itself. This makes the build rules a little easier to read,
even if they themselves did not change much.
- 0004 fixes the launcher (mostly). One can now set a project
directory, create projects, launch created projects and open project
directories in the default file explorer. However, setting the editor
(and hence launching one) still does not work.

Regards,

Leo

[0001-gnu-Add-renpy.patch (text/x-patch, attachment)]

[0002-gnu-renpy-use-main-site-instead-of-git.patch (text/x-patch, attachment)]

[0003-gnu-split-renpy-into-library-and-program.patch (text/x-patch, attachment)]

[0004-gnu-fix-renpy-launcher.patch (text/x-patch, attachment)]

Message #17 received at 37714 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 37714 <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Sun, 20 Oct 2019 14:09:54 +0200

[Message part 1 (text/plain, inline)]

Am Samstag, den 19.10.2019, 22:59 +0200 schrieb Leo Prikler:
> - 0003 splits renpy into the python package python2-renpy and the
> program itself. This makes the build rules a little easier to read,
> even if they themselves did not change much.
Now also with a package description for python2-renpy.
> - 0004 fixes the launcher (mostly). One can now set a project
> directory, create projects, launch created projects and open project
> directories in the default file explorer. However, setting the editor
> (and hence launching one) still does not work.
Adjusted accordingly.
- 0005 uses pre-install renpy to compile the games. I've also updated
the comments on #:tests? that are inaccurate as of 0002.

Regards,

Leo

[0003-gnu-split-renpy-into-library-and-program.patch (text/x-patch, attachment)]

[0004-gnu-fix-renpy-launcher.patch (text/x-patch, attachment)]

[0005-gnu-compile-Ren-py-games.patch (text/x-patch, attachment)]

Message #20 received at 37714 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 37714 <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Mon, 21 Oct 2019 09:26:16 +0200

Hello,

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> Am Samstag, den 19.10.2019, 22:59 +0200 schrieb Leo Prikler:
>> - 0003 splits renpy into the python package python2-renpy and the
>> program itself. This makes the build rules a little easier to read,
>> even if they themselves did not change much.
> Now also with a package description for python2-renpy.
>> - 0004 fixes the launcher (mostly). One can now set a project
>> directory, create projects, launch created projects and open project
>> directories in the default file explorer. However, setting the editor
>> (and hence launching one) still does not work.
> Adjusted accordingly.
> - 0005 uses pre-install renpy to compile the games. I've also updated
> the comments on #:tests? that are inaccurate as of 0002.

Could you squeeze all those patches into a single one and send it again?

Thank you for all the work so far!

Regards,

-- 
Nicolas Goaziou

Message #23 received at 37714 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 37714 <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Mon, 21 Oct 2019 09:35:23 +0200

[Message part 1 (text/plain, inline)]

Am Montag, den 21.10.2019, 09:26 +0200 schrieb Nicolas Goaziou:
> Hello,
> 
> Leo Prikler <leo.prikler <at> student.tugraz.at> writes:
> 
> > Am Samstag, den 19.10.2019, 22:59 +0200 schrieb Leo Prikler:
> > > - 0003 splits renpy into the python package python2-renpy and the
> > > program itself. This makes the build rules a little easier to
> > > read,
> > > even if they themselves did not change much.
> > Now also with a package description for python2-renpy.
> > > - 0004 fixes the launcher (mostly). One can now set a project
> > > directory, create projects, launch created projects and open
> > > project
> > > directories in the default file explorer. However, setting the
> > > editor
> > > (and hence launching one) still does not work.
> > Adjusted accordingly.
> > - 0005 uses pre-install renpy to compile the games. I've also
> > updated
> > the comments on #:tests? that are inaccurate as of 0002.
> 
> Could you squeeze all those patches into a single one and send it
> again?
> 
> Thank you for all the work so far!
> 
> Regards,
> 
Sure.

Regards,

Leo

[0001-gnu-Add-renpy.patch (text/x-patch, attachment)]

Message #28 received at 37714-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 37714-done <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Wed, 30 Oct 2019 00:04:56 +0100

Hello,

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> Subject: [PATCH] gnu: Add renpy

I applied your patch and added a line to your name in the authors list,
at the beginning of the file. I used the name from your commit. Let me
know if it should be otherwise.

Thank you!

Regards,

-- 
Nicolas Goaziou

Message #31 received at 37714-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 37714-done <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Wed, 30 Oct 2019 10:16:14 +0100

Am Mittwoch, den 30.10.2019, 00:04 +0100 schrieb Nicolas Goaziou:
> Hello,
> 
> Leo Prikler <leo.prikler <at> student.tugraz.at> writes:
> 
> > Subject: [PATCH] gnu: Add renpy
> 
> I applied your patch and added a line to your name in the authors
> list,
> at the beginning of the file. I used the name from your commit. Let
> me
> know if it should be otherwise.
Ah, that was my mistake, I messed up my git environment and the two
were different. It should be "Leo Prikler <
leo.prikler <at> student.tugraz.at>" as in the sender of the email.

Message #34 received at 37714-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 37714-done <at> debbugs.gnu.org
Subject: Re: [bug#37714] Add renpy package
Date: Wed, 30 Oct 2019 14:45:27 +0100

Hello,

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> Ah, that was my mistake, I messed up my git environment and the two
> were different. It should be "Leo Prikler <
> leo.prikler <at> student.tugraz.at>" as in the sender of the email.

I fixed the attribution line.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.