GNU bug report logs - #37718
[PATCH] Add gnome-mahjongg.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37718 in the body.
You can then email your comments to 37718 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "David Wilson" <david <at> daviwil.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add gnome-mahjongg.
Date: Sat, 12 Oct 2019 09:17:41 -0700

[Message part 1 (text/plain, inline)]

Hi fellow Guixers,

Here's a patch to add the (highly addictive) game Gnome Mahjongg.  Please let me know if there's any way this package definition can be improved!

Happy hacking,

David

[0001-gnu-Add-gnome-mahjongg.patch (text/x-patch, attachment)]

Message #10 received at 37718-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "David Wilson" <david <at> daviwil.com>
Cc: 37718-done <at> debbugs.gnu.org
Subject: Re: [bug#37718] [PATCH] Add gnome-mahjongg.
Date: Tue, 15 Oct 2019 14:17:18 +0200

[Message part 1 (text/plain, inline)]

Hi David,

"David Wilson" <david <at> daviwil.com> skribis:

> From a589ef5124d265b9c0fb646b35e8efe852b74855 Mon Sep 17 00:00:00 2001
> From: David Wilson <david <at> daviwil.com>
> Date: Sat, 12 Oct 2019 09:07:11 -0700
> Subject: [PATCH] gnu: Add gnome-mahjongg.
>
> * gnu/packages/gnome.scm (gnome-mahjongg) New variable.

Applied with the following changes, thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 81566e6e42..99cd7a7cb6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8406,6 +8406,7 @@ higher level porcelain stuff.")
               (uri (git-reference
                     (url "https://gitlab.gnome.org/GNOME/gnome-mahjongg.git")
                     (commit version)))
+              (file-name (git-file-name name version))
               (sha256
                (base32
                 "019a66a4m5w4kkb0sm6gxj0wi54n06zdxdlmyqw7h8kbakjizv7l"))))
@@ -8427,8 +8428,8 @@ higher level porcelain stuff.")
        ("gtk+" ,gtk+)
        ("librsvg" ,librsvg)))
     (synopsis "Mahjongg tile-matching game")
-    (description "Gnome Mahjongg is a game based on the classic Chinese tile-
-matching game Mahjong.  It features multiple board layouts, tile themes, and a
-high score table.")
+    (description "GNOME Mahjongg is a game based on the classic Chinese
+tile-matching game Mahjong.  It features multiple board layouts, tile themes,
+and a high score table.")
     (home-page "https://wiki.gnome.org/Apps/Mahjongg")
     (license license:gpl2)))

Message #13 received at 37718 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "David Wilson" <david <at> daviwil.com>
Cc: 37718 <at> debbugs.gnu.org
Subject: Re: [bug#37718] [PATCH] Add gnome-mahjongg.
Date: Tue, 15 Oct 2019 14:20:14 +0200

[Message part 1 (text/plain, inline)]

Oops, and this change too:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 99cd7a7cb6..81cb2fb37f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8432,4 +8432,4 @@ higher level porcelain stuff.")
 tile-matching game Mahjong.  It features multiple board layouts, tile themes,
 and a high score table.")
     (home-page "https://wiki.gnome.org/Apps/Mahjongg")
-    (license license:gpl2)))
+    (license license:gpl2+)))

[Message part 3 (text/plain, inline)]

… because source file headers carry the “or any later version” wording.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.