GNU bug report logs - #37738
[PATCH] gnu: add lxqt-connman-applet

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37738 in the body.
You can then email your comments to 37738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add lxqt-connman-applet
Date: Sun, 13 Oct 2019 22:19:01 +0330

[Message part 1 (text/plain, inline)]

Hi, 
I added a new package related to LXQt stuff: lxqt-connman-applet
could you please check and add it package repositories? thanks. 

--
Regards
Reza Alizadeh Majd
PantherX Team

[0001-gnu-add-lxqt-connman-applet.patch (application/octet-stream, attachment)]

Message #8 received at 37738 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
Cc: 37738 <at> debbugs.gnu.org
Subject: Re: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Fri, 18 Oct 2019 11:45:13 +0200

Hi Reza,

"Reza Alizadeh Majd" <r.majd <at> pantherx.org> skribis:

> From c3756518da1289ec7f7cc803e624632aa21aed01 Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
> Date: Sun, 13 Oct 2019 20:55:21 +0330
> Subject: [PATCH] gnu: add lxqt-connman-applet
>
> * gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.

Nice.  A few comments/questions:

> +(define-public lxqt-connman-applet
> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
> +        (revision "0"))

Why did you choose this specific commit?

Normally we only package upstream releases (tags); we resort to commits
in between releases only when there’s a good reason to do that, and in
that cases it’s better to add a comment explaining why we did that.

> +      (arguments
> +        `(#:tests? #f

Could you add a comment explaining why tests are disabled?

> +      (home-page "https://github.com/lxqt/lxqt-connman-applet")
> +      (synopsis "System-tray applet for connman")
> +      (description "LXQt based system-tray applet for connman")

Please write a full description:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Apart from that the patch LGTM.

Could you send an updated patch?

Thank you!

Ludo’.

Message #11 received at 37738 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37738 <at> debbugs.gnu.org
Subject: Re: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Fri, 18 Oct 2019 17:04:24 +0330

[Message part 1 (text/plain, inline)]

Hi Ludo, 


> Nice.  A few comments/questions:
> 
>> +(define-public lxqt-connman-applet
>> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>> +        (revision "0"))
> 
> Why did you choose this specific commit?
> 
> Normally we only package upstream releases (tags); we resort to commits
> in between releases only when there’s a good reason to do that, and in
> that cases it’s better to add a comment explaining why we did that.

since the package developers didn’t release a specific version so I 
decided to choose their latest commit in `master` branch. besides that 
I had tested the applet on LXQt desktop and it works without issues. 


>> +      (arguments
>> +        `(#:tests? #f
> 
> Could you add a comment explaining why tests are disabled?

OK, sure, I will submit updated patch ASAP. 


>> +      (home-page "https://github.com/lxqt/lxqt-connman-applet")
>> +      (synopsis "System-tray applet for connman")
>> +      (description "LXQt based system-tray applet for connman")
> 
> Please write a full description:
> 
>  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

unfortunately the original developers didn’t provide any further 
details about this package yet. so is it OK to write a description 
about this package by myself? 



Regards,
Reza

[Message part 2 (text/html, inline)]

Message #14 received at 37738 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
Cc: 37738 <at> debbugs.gnu.org
Subject: Re: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Fri, 18 Oct 2019 23:20:26 +0200

Hi,

"Reza Alizadeh Majd" <r.majd <at> pantherx.org> skribis:

>> Nice.  A few comments/questions:
>> 
>>> +(define-public lxqt-connman-applet
>>> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>>> +        (revision "0"))
>> 
>> Why did you choose this specific commit?
>> 
>> Normally we only package upstream releases (tags); we resort to commits
>> in between releases only when there’s a good reason to do that, and in
>> that cases it’s better to add a comment explaining why we did that.
>
> since the package developers didn’t release a specific version so I 
> decided to choose their latest commit in `master` branch. besides that 
> I had tested the applet on LXQt desktop and it works without issues. 

Oh, I see (I thought there was a 0.14.1 release, but there’s no such
thing on github.com.)

>> Please write a full description:
>> 
>>  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> unfortunately the original developers didn’t provide any further 
> details about this package yet. so is it OK to write a description 
> about this package by myself? 

Yes, sure!

Thank you,
Ludo’.

Message #17 received at 37738 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37738 <at> debbugs.gnu.org
Subject: Re: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Sat, 19 Oct 2019 15:24:56 +0330

[Message part 1 (text/plain, inline)]

Hi Ludo, 

I updated the patch file based on mentioned requirements. so could you please
check if this recent patch meets the requirements to be submitted to guix repository?


Thank you,
Reza

[0001-gnu-add-lxqt-connman-applet.patch (application/octet-stream, attachment)]

Message #22 received at 37738-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
Cc: 37738-done <at> debbugs.gnu.org
Subject: Re: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Sun, 20 Oct 2019 23:26:01 +0200

[Message part 1 (text/plain, inline)]

Hi,

"Reza Alizadeh Majd" <r.majd <at> pantherx.org> skribis:

> From d59861d1b422d1fd1b61fec9bf7d01f9aa6f8816 Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
> Date: Sun, 13 Oct 2019 20:55:21 +0330
> Subject: [PATCH] gnu: add lxqt-connman-applet
>
> * gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.

Great!  Applied with the minor tweak below to make the description a
full sentence and give a bit of context.

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 375fb1ffe1..8d5d3522ec 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1320,8 +1320,9 @@ like @command{tar} and @command{zip}.")
                   #t)))))
       (home-page "https://github.com/lxqt/lxqt-connman-applet")
       (synopsis "System-tray applet for connman")
-      (description "Qt based system-tray applet for @code{connman},
-originally developed for @code{lxqt} desktop.")
+      (description "This package provides a Qt-based system-tray applet for
+the network management tool Connman, originally developed for the LXQT
+desktop.")
       (license license:lgpl2.1+))))
 
 ;; The LXQt Desktop Environment

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.