GNU bug report logs - #37793
[PATCH] gnu: Add gens-gs.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Thu, 17 Oct 2019 14:44:02 UTC

Severity: normal

Tags: patch

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37793 in the body.
You can then email your comments to 37793 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Thu, 17 Oct 2019 14:44:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 17 Oct 2019 14:44:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add gens-gs.
Date: Thu, 17 Oct 2019 16:42:38 +0200
* gnu/packages/emulators.scm (gens-gs): New variable.
---
 gnu/packages/emulators.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index f6da7f2d25..c1d1d54052 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -1366,3 +1366,37 @@ functions.  The source code to MAME serves as this documentation.")
     ;; However, over 90% of the files are under Expat license.  Also, artwork,
     ;; keymaps, languages and samples are under CC0.
     (license (list license:gpl2+ license:expat license:cc0))))
+
+(define-public gens-gs
+  (package
+    (name "gens-gs")
+    (version "7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://retrocdn.net/images/6/6d/Gens-gs-r"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "1ha5s6d3y7s9aq9f4zmn9p88109c3mrj36z2w68jhiw5xrxws833"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:system "i686-linux"))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("nasm" ,nasm)))
+    (inputs
+     `(("sdl" ,sdl)
+       ("gtk" ,gtk+-2)
+       ;; TODO: Test if following deps are necessary.
+       ;; ("libpng" ,libpng)
+       ;; ("zlib" ,zlib)
+       ;; ("glu" ,glu)
+       ))
+    (home-page "https://segaretro.org/Gens/GS")
+    (synopsis "Emulator for Sega Genesis/Mega Drive systems")
+    (description
+     "Gens/GS is an emulator for the Sega Mega Drive (also known as Genesis),
+derived from Gens.  Project goals include clean source code, combined features
+from various forks of Gens, and improved platform portability.")
+    (license license:gpl2+)))
-- 
2.23.0





Information forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Thu, 17 Oct 2019 15:39:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37793 <at> debbugs.gnu.org
Subject: Re: [bug#37793] [PATCH] gnu: Add gens-gs.
Date: Thu, 17 Oct 2019 17:38:43 +0200
Hey Pierre,

> +    (arguments
> +     `(#:system "i686-linux"))

Maybe you should add:

--8<---------------cut here---------------start------------->8---
    (supported-systems '("i686-linux" "x86_64-linux"))
--8<---------------cut here---------------end--------------->8---

then?

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Thu, 17 Oct 2019 15:39:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Fri, 18 Oct 2019 08:36:02 GMT) Full text and rfc822 format available.

Message #14 received at 37793 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 37793 <at> debbugs.gnu.org
Subject: Re: bug#37793: Acknowledgement ([PATCH] gnu: Add gens-gs.)
Date: Fri, 18 Oct 2019 10:35:24 +0200
[Message part 1 (text/plain, inline)]
This package currently fails to build with the following error:

--8<---------------cut here---------------start------------->8---
ui/gtk/gens/gens_window_callbacks.cpp:157:15: error: ‘GdkDragContext {aka struct _GdkDragContext}’ has no member named ‘targets’
  if (context->targets)
               ^~~~~~~
--8<---------------cut here---------------end--------------->8---

Nix has nothing special in its definition: https://github.com/NixOS/nixpkgs/tree/master/pkgs/misc/emulators.

-- 
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Sat, 19 Oct 2019 13:38:02 GMT) Full text and rfc822 format available.

Message #17 received at 37793 <at> debbugs.gnu.org (full text, mbox):

From: "David Wilson" <david <at> daviwil.com>
To: 37793 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add gens-gs.
Date: Sat, 19 Oct 2019 06:36:50 -0700
[Message part 1 (text/plain, inline)]
Hi all! I was able to get the gens-gs build working with the attached patch on top of Pierre's original. Tested the output by loading up a "Chakan: The Forever Man" ROM, seemed to work fine :)  The key was this line of the Nix package definition:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/emulators/gens-gs/default.nix#L16

Apparently gens-gs' code is so old that it's using some deprecated GTK APIs, so we have to remove the GTK_DISABLE_DEPRECATED define, etc, from GTK_CFLAGS so that the build will complete successfully.

David
[gens-fix.patch (text/x-patch, attachment)]

bug closed, send any further explanations to 37793 <at> debbugs.gnu.org and Pierre Neidhardt <mail <at> ambrevar.xyz> Request was from Pierre Neidhardt <mail <at> ambrevar.xyz> to control <at> debbugs.gnu.org. (Mon, 21 Oct 2019 16:14:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#37793; Package guix-patches. (Mon, 21 Oct 2019 16:26:02 GMT) Full text and rfc822 format available.

Message #22 received at 37793 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 37793 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, David Wilson <david <at> daviwil.com>
Subject: Re: [bug#37793] [PATCH] gnu: Add gens-gs.
Date: Mon, 21 Oct 2019 18:25:07 +0200
[Message part 1 (text/plain, inline)]
Merged, thank you David and Mathieu!

-- 
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 19 Nov 2019 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 131 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.