GNU bug report logs - #37831
GDM has a GNOME entry even when not installed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37831 in the body.
You can then email your comments to 37831 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: bug-guix <at> gnu.org
Subject: GDM has a GNOME entry even when not installed
Date: Sun, 20 Oct 2019 13:15:41 +0200

[Message part 1 (text/plain, inline)]

My config.scm installs EXWM + StumpWM, but not GNOME.
Before the last core-update, GDM would only suggest the 2 window
managers.

After a recent Guix pull followed by a `guix system reconfigure', GDM
also suggests GNOME.  If I select it, it fails to log in, which I
suppose is expected since it's not installed.

I believe the GNOME entry in GDM should only appear if GNOME is installed.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 37831 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 37831 <at> debbugs.gnu.org
Subject: Re: bug#37831: GDM has a GNOME entry even when not installed
Date: Fri, 14 Feb 2020 14:14:25 -0500

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> My config.scm installs EXWM + StumpWM, but not GNOME.
> Before the last core-update, GDM would only suggest the 2 window
> managers.
>
> After a recent Guix pull followed by a `guix system reconfigure', GDM
> also suggests GNOME.  If I select it, it fails to log in, which I
> suppose is expected since it's not installed.
>
> I believe the GNOME entry in GDM should only appear if GNOME is installed.

I can confirm the issue, attempting to use GDM + ratpoison (without
GNOME installed).

Maxim

Message #13 received at 37831 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 37831 <at> debbugs.gnu.org
Subject: Re: bug#37831: GDM has a GNOME entry even when not installed
Date: Sat, 11 Apr 2020 18:31:48 +0200

Hi,

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> My config.scm installs EXWM + StumpWM, but not GNOME.
> Before the last core-update, GDM would only suggest the 2 window
> managers.
>
> After a recent Guix pull followed by a `guix system reconfigure', GDM
> also suggests GNOME.  If I select it, it fails to log in, which I
> suppose is expected since it's not installed.
>
> I believe the GNOME entry in GDM should only appear if GNOME is installed.

I investigated this issue.

‘collect_sessions’ in ‘gdm-sessions.c’ does this:

--8<---------------cut here---------------start------------->8---
const char *xorg_search_dirs[] = {
        "/etc/X11/sessions/",
        DMCONFDIR "/Sessions/",
        DATADIR "/gdm/BuiltInSessions/",
        DATADIR "/xsessions/",
        NULL
};

xorg_search_array = g_array_new (TRUE, TRUE, sizeof (char *));

const gchar * const *system_data_dirs = g_get_system_data_dirs ();

for (i = 0; system_data_dirs[i]; i++) {
        session_dir = g_build_filename (system_data_dirs[i], "xsessions", NULL);
        g_array_append_val (xorg_search_array, session_dir);
}

g_array_append_vals (xorg_search_array, xorg_search_dirs, G_N_ELEMENTS (xorg_search_dirs));

if (gdm_available_sessions_map == NULL) {
        gdm_available_sessions_map = g_hash_table_new_full (g_str_hash, g_str_equal,
                                                            g_free, (GDestroyNotify)gdm_session_file_free);
}

for (i = 0; i < xorg_search_array->len; i++) {
        collect_sessions_from_directory (g_array_index (xorg_search_array, gchar*, i));
}
--8<---------------cut here---------------end--------------->8---

‘gnome-desktop.desktop’, which contains the GNOME entry, is picked up
from $(guix build gnome-session)/share/xsessions, which happens to be
one of the ‘system_data_dirs’ elements (via $XDG_DATA_DIR).

So I thought that setting:

  system_data_dirs = { NULL };

would solve the issue.  Alas, it seems that when we do that, either the
array remains empty or somehow ‘collect_sessions_from_directory’ is not
called.

I can’t attach GDM though, or I don’t know what to attach it to…

Ideas anyone?

Thanks,
Ludo’.

Message #18 received at 37831-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 37831-done <at> debbugs.gnu.org
Subject: Re: bug#37831: GDM has a GNOME entry even when not installed
Date: Sun, 12 Apr 2020 00:23:58 +0200

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> My config.scm installs EXWM + StumpWM, but not GNOME.
> Before the last core-update, GDM would only suggest the 2 window
> managers.
>
> After a recent Guix pull followed by a `guix system reconfigure', GDM
> also suggests GNOME.  If I select it, it fails to log in, which I
> suppose is expected since it's not installed.
>
> I believe the GNOME entry in GDM should only appear if GNOME is installed.

Alright, I eventually succeeded and pushed a fix as
f4ec5e1a9823a66c27fe2bc033db7b58b29edfef (‘version-1.1.0’; will merge
later on ‘master’).  Woohoo!

AFAICS it works as advertised, but please report any issues!

Ludo’.

Message #21 received at 37831-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37831-done <at> debbugs.gnu.org
Subject: Re: bug#37831: GDM has a GNOME entry even when not installed
Date: Sun, 12 Apr 2020 09:52:09 +0200

[Message part 1 (text/plain, inline)]

Thanks!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.