GNU bug report logs - #37833
[PATCH] sddm-service-type: Add default configuration.

Previous Next

Package: guix-patches;

Reported by: Brendan Tildesley <mail <at> brendan.scot>

Date: Sun, 20 Oct 2019 14:14:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37833 in the body.
You can then email your comments to 37833 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37833; Package guix-patches. (Sun, 20 Oct 2019 14:14:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brendan Tildesley <mail <at> brendan.scot>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 20 Oct 2019 14:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: guix-patches <at> gnu.org
Subject: [PATCH] sddm-service-type: Add default configuration.
Date: Sun, 20 Oct 2019 23:12:02 +0900
* gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
configured in an operating-system configuration by simply adding (service
sddm-service-type). This adds the default SDDM configuration just like GDM
does.
---
 gnu/services/sddm.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b0e6d40260..f33f1f93b9 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -316,7 +316,8 @@ Relogin="              (if (sddm-configuration-relogin? config)
                         (service-extension account-service-type
                                            (const %sddm-accounts))
                         (service-extension profile-service-type
-                                           sddm-profile-service)))))
+                                           sddm-profile-service)))
+                (default-value (sddm-configuration))))
 
 (define* (sddm-service #:optional (config (sddm-configuration)))
   "Run the @uref{https://github.com/sddm/sddm,SSDM display manager}
-- 
2.23.0





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 21 Oct 2019 13:48:02 GMT) Full text and rfc822 format available.

Notification sent to Brendan Tildesley <mail <at> brendan.scot>:
bug acknowledged by developer. (Mon, 21 Oct 2019 13:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 37833-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 37833-done <at> debbugs.gnu.org
Subject: Re: [bug#37833] [PATCH] sddm-service-type: Add default configuration.
Date: Mon, 21 Oct 2019 15:47:02 +0200
Hi Brendan,

Brendan Tildesley <mail <at> brendan.scot> skribis:

> * gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
> configured in an operating-system configuration by simply adding (service
> sddm-service-type). This adds the default SDDM configuration just like GDM
> does.

Applied with a tweaked commit log that more closely matches our
conventions.

Thank you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 19 Nov 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 131 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.