GNU bug report logs - #37837
[PATCH] Make sb-image.el obsolete

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37837 in the body.
You can then email your comments to 37837 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make sb-image.el obsolete
Date: Sun, 20 Oct 2019 22:28:40 +0200

[Message part 1 (text/plain, inline)]

sb-image.el says:

;; Supporting Image display for Emacs 20 and less, Emacs 21, and XEmacs,
;; is a challenging task, which doesn't take kindly to being byte compiled.
;; When sharing speedbar.elc between these three applications, the Image
;; support can get lost.
;;
;; By splitting out that hard part into this file, and avoiding byte
;; compilation, one copy speedbar can support all these platforms together.

I suggest to get rid of this compatibility kludge.  Is the attached
patch an acceptable way to do that?

Best regards,
Stefan Kangas

[0001-Make-sb-image.el-to-obsolete.patch (application/octet-stream, attachment)]

Message #8 received at 37837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37837 <at> debbugs.gnu.org
Subject: Re: bug#37837: [PATCH] Make sb-image.el obsolete
Date: Mon, 21 Oct 2019 09:27:04 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 20 Oct 2019 22:28:40 +0200
> 
> sb-image.el says:
> 
> ;; Supporting Image display for Emacs 20 and less, Emacs 21, and XEmacs,
> ;; is a challenging task, which doesn't take kindly to being byte compiled.
> ;; When sharing speedbar.elc between these three applications, the Image
> ;; support can get lost.
> ;;
> ;; By splitting out that hard part into this file, and avoiding byte
> ;; compilation, one copy speedbar can support all these platforms together.
> 
> I suggest to get rid of this compatibility kludge.  Is the attached
> patch an acceptable way to do that?

Did we decide to drop support of those older Emacs versions?

Message #11 received at 37837 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37837 <at> debbugs.gnu.org
Subject: Re: bug#37837: [PATCH] Make sb-image.el obsolete
Date: Sat, 2 Nov 2019 04:21:27 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:
>
> > From: Stefan Kangas <stefan <at> marxist.se>
> > Date: Sun, 20 Oct 2019 22:28:40 +0200
> >
> > sb-image.el says:
> >
> > ;; Supporting Image display for Emacs 20 and less, Emacs 21, and XEmacs,
> > ;; is a challenging task, which doesn't take kindly to being byte compiled.
> > ;; When sharing speedbar.elc between these three applications, the Image
> > ;; support can get lost.
> > ;;
> > ;; By splitting out that hard part into this file, and avoiding byte
> > ;; compilation, one copy speedbar can support all these platforms together.
> >
> > I suggest to get rid of this compatibility kludge.  Is the attached
> > patch an acceptable way to do that?
>
> Did we decide to drop support of those older Emacs versions?

I'm not aware of any general requirement to maintain backwards
compatibility with ancient Emacs versions on master.  For example, we
have dropped all compatibility function and variable aliases.

Users of Emacs 21 or older should surely just use whatever was shipped
with the version of Emacs that they are using.  Or am I missing
something?

To be clear, this package is not distributed on GNU ELPA as far as I can tell.

Best regards,
Stefan Kangas

Message #14 received at 37837 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 37837 <at> debbugs.gnu.org
Subject: Re: bug#37837: [PATCH] Make sb-image.el obsolete
Date: Sun, 17 Nov 2019 10:57:29 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> I'm not aware of any general requirement to maintain backwards
> compatibility with ancient Emacs versions on master.  For example, we
> have dropped all compatibility function and variable aliases.

We routinely drop support for old versions of Emacs from the .el files
in Emacs -- there's no point in carrying around dead weight.

So I think the patch looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 37837 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 37837 <at> debbugs.gnu.org
Subject: Re: bug#37837: [PATCH] Make sb-image.el obsolete
Date: Fri, 17 Jan 2020 06:56:56 +0100

close 37837 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> We routinely drop support for old versions of Emacs from the .el files
> in Emacs -- there's no point in carrying around dead weight.
>
> So I think the patch looks good to me.

No further comments within 8 weeks, so I pushed this to master as
commit 6dbe2c932a.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.