GNU bug report logs - #37857
[PATCH] guix: svn: Allow dropping externals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37857 in the body.
You can then email your comments to 37857 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: svn: Allow dropping externals
Date: Mon, 21 Oct 2019 21:55:38 +0200

[Message part 1 (text/plain, inline)]

A subversion repository can contain externals, references to other
projects that also use subversion. This is very similar to git
submodules. When checking out a repository, svn will automatically
check these external repositories too. However, if the externals are
not pinned to a specific revision, svn will fetch the latest sources
for the external, leading to non reproducibility of the sources' hash.

This patch adds a fetch-externals? field to svn-reference and
svn-multi-reference, defaulting to #t for preserving the old behavior.
Setting it to #f will prevent fetching any external from the project.
This is useful for josm for instance.

[0001-guix-svn-Allow-dropping-externals.patch (text/x-patch, attachment)]

Message #8 received at 37857 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 37857 <at> debbugs.gnu.org
Subject: Re: [bug#37857] [PATCH] guix: svn: Allow dropping externals
Date: Tue, 22 Oct 2019 18:10:59 +0200

Hi Julien,

Julien Lepiller <julien <at> lepiller.eu> skribis:

>>From 0ac412a3c912b2fe7ebd05d178120db50d47184e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Mon, 21 Oct 2019 21:48:31 +0200
> Subject: [PATCH] guix: svn: Allow dropping externals.
>
> * guix/build/svn.scm (svn-fetch): Allow to ignore externals.
> * guix/svn-download.scm (svn-reference, svn-multi-reference): Add
> fetch-externals? field.

Nice.

For consistency with git-download.scm & co., what about calling the
parameter and the field ‘recursive?’ rather than ‘fetch-externals?’?

>  (define-record-type* <svn-reference>
>    svn-reference make-svn-reference
>    svn-reference?
> -  (url       svn-reference-url)                    ; string
> -  (revision  svn-reference-revision)               ; number
> -  (user-name svn-reference-user-name (default #f))
> -  (password  svn-reference-password (default #f)))
> +  (url              svn-reference-url)                    ; string
> +  (revision         svn-reference-revision)               ; number
> +  (fetch-externals? svn-reference-fetch-externals? (default #t))

Do you know of packages that rely on externals?

It’d be great to eventually default to #f, but for that we’d need to
check every package that uses ‘svn-fetch’ (notably all the TeX Live
packages.)

Thanks,
Ludo’.

Message #13 received at 37857-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 37857-done <at> debbugs.gnu.org
Subject: Re: [bug#37857] [PATCH] guix: svn: Allow dropping externals
Date: Wed, 23 Oct 2019 23:34:23 +0200

Pushed as 51395c84fdbf8daed6392951a973ad750cf3eefa.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.