GNU logs - #37858, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#37858: 27.0.50; Ensure a minimum width for `space` display prop
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 21 Oct 2019 20:05:02 +0000
Resent-Message-ID: <handler.37858.B.157168825823042 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 37858 <at> debbugs.gnu.org
From: Stefan Monnier <monnier@HIDDEN>
Date: Mon, 21 Oct 2019 16:03:58 -0400
Message-ID: <jwvy2xdams1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Package: Emacs
Version: 27.0.50


For text displayed in columns, alignment is generally obtained with
a `display` text-property of the form

    (space :align-to FOO)

This works great when the previous text ends before FOO, but when we
mis-calculate (or didn't calculate at all) and the previous text already
extends further than the desired alignment of the following text, such
space is reduced down to 0 pixels which is often not what we want.

Sometimes one can workaround this by placing 2 spaces in the buffer: one
with the :align-to and another fixed size space.  But it can be
cumbersome to do that and it leads to undesirable artifacts (e.g. the
cursor can be placed between the two space).

So, I'd like to extend our `space` specifications so as to be able to
specify a minimum width.  I came up with the patch below which lets you
write:

    (space :align-to FOO :min-width BAR)

which seems to work fine, but while trying to update the Elisp doc for
it I realized that maybe a better option is to extend the acceptable
forms for FOO so it can be of the form:

    (space :align-to (max FOO (+ BAR current-x)))

WDYT?


        Stefan


diff --git a/src/xdisp.c b/src/xdisp.c
index be1c209553..fd825d2dfe 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -29218,6 +29218,28 @@ append_stretch_glyph (struct it *it, Lisp_Object object,
 
 #endif	/* HAVE_WINDOW_SYSTEM */
 
+static int
+compute_relative_width (struct it *it, Lisp_Object prop)
+{
+  struct it it2;
+  unsigned char *p = BYTE_POS_ADDR (IT_BYTEPOS (*it));
+
+  it2 = *it;
+  if (it->multibyte_p)
+    it2.c = it2.char_to_display = STRING_CHAR_AND_LENGTH (p, it2.len);
+  else
+    {
+      it2.c = it2.char_to_display = *p, it2.len = 1;
+      if (! ASCII_CHAR_P (it2.c))
+	it2.char_to_display = BYTE8_TO_CHAR (it2.c);
+    }
+
+  it2.glyph_row = NULL;
+  it2.what = IT_CHARACTER;
+  PRODUCE_GLYPHS (&it2);
+  return NUMVAL (prop) * it2.pixel_width;
+}
+
 /* Produce a stretch glyph for iterator IT.  IT->object is the value
    of the glyph property displayed.  The value must be a list
    `(space KEYWORD VALUE ...)' with the following KEYWORD/VALUE pairs
@@ -29288,23 +29310,7 @@ produce_stretch_glyph (struct it *it)
       /* Relative width `:relative-width FACTOR' specified and valid.
 	 Compute the width of the characters having the `glyph'
 	 property.  */
-      struct it it2;
-      unsigned char *p = BYTE_POS_ADDR (IT_BYTEPOS (*it));
-
-      it2 = *it;
-      if (it->multibyte_p)
-	it2.c = it2.char_to_display = STRING_CHAR_AND_LENGTH (p, it2.len);
-      else
-	{
-	  it2.c = it2.char_to_display = *p, it2.len = 1;
-	  if (! ASCII_CHAR_P (it2.c))
-	    it2.char_to_display = BYTE8_TO_CHAR (it2.c);
-	}
-
-      it2.glyph_row = NULL;
-      it2.what = IT_CHARACTER;
-      PRODUCE_GLYPHS (&it2);
-      width = NUMVAL (prop) * it2.pixel_width;
+      width = compute_relative_width (it, prop);
     }
   else if ((prop = Fplist_get (plist, QCalign_to), !NILP (prop))
 	   && calc_pixel_width_or_height (&tem, it, prop, font, true,
@@ -29323,6 +29329,21 @@ produce_stretch_glyph (struct it *it)
     /* Nothing specified -> width defaults to canonical char width.  */
     width = FRAME_COLUMN_WIDTH (it->f);
 
+  if ((prop = Fplist_get (plist, QCmin_width), !NILP (prop))
+      && calc_pixel_width_or_height (&tem, it, prop, font, true, 0))
+    {
+      /* Absolute minimum width `:min-width WIDTH' specified and valid.  */
+      if (width < tem)
+        width = tem;
+    }
+  else if (prop = Fplist_get (plist, QCmin_relative_width), NUMVAL (prop) > 0)
+    {
+      /* Relative width `:min-relative-width FACTOR' specified and valid.  */
+      int tem = compute_relative_width (it, prop);
+      if (width < tem)
+        width = tem;
+    }
+
   if (width <= 0 && (width < 0 || !zero_width_ok_p))
     width = 1;
 
@@ -34275,6 +34296,8 @@ syms_of_xdisp (void)
   DEFSYM (QCalign_to, ":align-to");
   DEFSYM (QCrelative_width, ":relative-width");
   DEFSYM (QCrelative_height, ":relative-height");
+  DEFSYM (QCmin_relative_width, ":min-relative-width");
+  DEFSYM (QCmin_width, ":min-width");
   DEFSYM (QCeval, ":eval");
   DEFSYM (QCpropertize, ":propertize");
   DEFSYM (QCfile, ":file");

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefan Monnier <monnier@HIDDEN>
Subject: bug#37858: Acknowledgement (27.0.50; Ensure a minimum width for
 `space` display prop)
Message-ID: <handler.37858.B.157168825823042.ack <at> debbugs.gnu.org>
References: <jwvy2xdams1.fsf@HIDDEN>
X-Gnu-PR-Message: ack 37858
X-Gnu-PR-Package: emacs
Reply-To: 37858 <at> debbugs.gnu.org
Date: Mon, 21 Oct 2019 20:05:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 37858 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
37858: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37858
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#37858: 27.0.50; Ensure a minimum width for `space` display prop
Resent-From: Robert Pluim <rpluim@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 22 Oct 2019 08:04:01 +0000
Resent-Message-ID: <handler.37858.B37858.157173143629232 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefan Monnier <monnier@HIDDEN>
Cc: 37858 <at> debbugs.gnu.org
From: Robert Pluim <rpluim@HIDDEN>
References: <jwvy2xdams1.fsf@HIDDEN>
Mail-Copies-To: never
Gmane-Reply-To-List: yes
Date: Tue, 22 Oct 2019 10:03:46 +0200
In-Reply-To: <jwvy2xdams1.fsf@HIDDEN> (Stefan Monnier's message of
 "Mon, 21 Oct 2019 16:03:58 -0400")
Message-ID: <m2ftjlurz1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

>>>>> On Mon, 21 Oct 2019 16:03:58 -0400, Stefan Monnier <monnier@HIDDEN=
real.ca> said:

    Stefan> Package: Emacs
    Stefan> Version: 27.0.50


    Stefan> For text displayed in columns, alignment is generally obtained =
with
    Stefan> a `display` text-property of the form

    Stefan>     (space :align-to FOO)

    Stefan> This works great when the previous text ends before FOO, but wh=
en we
    Stefan> mis-calculate (or didn't calculate at all) and the previous tex=
t already
    Stefan> extends further than the desired alignment of the following tex=
t, such
    Stefan> space is reduced down to 0 pixels which is often not what we wa=
nt.

    Stefan> Sometimes one can workaround this by placing 2 spaces in the bu=
ffer: one
    Stefan> with the :align-to and another fixed size space.  But it can be
    Stefan> cumbersome to do that and it leads to undesirable artifacts (e.=
g. the
    Stefan> cursor can be placed between the two space).

    Stefan> So, I'd like to extend our `space` specifications so as to be a=
ble to
    Stefan> specify a minimum width.  I came up with the patch below which =
lets you
    Stefan> write:

    Stefan>     (space :align-to FOO :min-width BAR)

    Stefan> which seems to work fine, but while trying to update the Elisp =
doc for
    Stefan> it I realized that maybe a better option is to extend the accep=
table
    Stefan> forms for FOO so it can be of the form:

    Stefan>     (space :align-to (max FOO (+ BAR current-x)))

Hmm, I think I probably prefer the former. Perhaps when you've
documented the semantics of your :min-relative-width addition I=CA=BCll be
able to judge better :-)

Robert

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#37858: 27.0.50; Ensure a minimum width for `space` display prop
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 22 Oct 2019 15:09:02 +0000
Resent-Message-ID: <handler.37858.B37858.157175693622622 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefan Monnier <monnier@HIDDEN>
Cc: 37858 <at> debbugs.gnu.org
Date: Tue, 22 Oct 2019 18:08:43 +0300
Message-Id: <837e4w24xw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <jwvy2xdams1.fsf@HIDDEN> (message from Stefan Monnier
 on Mon, 21 Oct 2019 16:03:58 -0400)
References: <jwvy2xdams1.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Stefan Monnier <monnier@HIDDEN>
> Date: Mon, 21 Oct 2019 16:03:58 -0400
> 
> So, I'd like to extend our `space` specifications so as to be able to
> specify a minimum width.  I came up with the patch below which lets you
> write:
> 
>     (space :align-to FOO :min-width BAR)
> 
> which seems to work fine, but while trying to update the Elisp doc for
> it I realized that maybe a better option is to extend the acceptable
> forms for FOO so it can be of the form:
> 
>     (space :align-to (max FOO (+ BAR current-x)))

Since :align-to already supports expressions of the forms described in
the node "Pixel Specification", to have the latter you'd need:

  . implement a new OP called 'max' (and probably also 'min' for a
    good measure);
  . implement a new POS called, say, 'beg', which will evaluate to the
    x coordinate of where the space display property begins

and then you will have your feature for free, I think.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 29 Oct 2020 20:32:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 29 16:32:56 2020
Received: from localhost ([127.0.0.1]:55066 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kYEbQ-0006se-Gr
	for submit <at> debbugs.gnu.org; Thu, 29 Oct 2020 16:32:56 -0400
Received: from mail-ej1-f48.google.com ([209.85.218.48]:38894)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1kYEbP-0006sQ-OW
 for control <at> debbugs.gnu.org; Thu, 29 Oct 2020 16:32:56 -0400
Received: by mail-ej1-f48.google.com with SMTP id za3so5631254ejb.5
 for <control <at> debbugs.gnu.org>; Thu, 29 Oct 2020 13:32:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:mime-version:date:message-id:subject:to;
 bh=insdqO8PEzSq+ZpuB8v6cBfuzxl+ZACr+QIOaTY5Yio=;
 b=uM1ET5Du0xNgjuYA2umsPBrtUuw2150O/vWq5kC7bKwE7gCHZkUWTNDQUwxK9w23Es
 VmJItmv9/hihlGwZ7Fnflf02nCjwCEpLFtQGhl/Xi5XE6Hr+ADEKf2nHtAl1RLrdipcf
 rDt+q5oHdLx/7NK2McxVZS3it0WuJ7gmZfouSmrVomiA5OJ3XDJs2hqPLg9qOvxHv5Ko
 PFtOsF50aPhLqRxfLruzdAJUZY8HSJU/ASz152oPWcO3WPmtv4NPrVUFcAxVtupwf/Kh
 SHNxhK28daJeOkJwEj7L3f9BSW0r6MUR7EipBHIAT7fLory+5SveoS9LF5unAxdwcpRf
 o/XQ==
X-Gm-Message-State: AOAM531plWbhZ4T+3lmO0biSorl/vzeTSmDHRphwJTkaVRsXXerwmuav
 e3SpV/cMrJ7h1Sxt0ZVU2/PHz1UZu1NivKneqkGdTrWm
X-Google-Smtp-Source: ABdhPJwavW1UrDcgM0u6fSimMjS233ImUuoWzkX8sfBz+pyysCOoUjbfMlz98AmdCICLEpshAXKHOuIFVt98q2Rp0HQ=
X-Received: by 2002:a17:906:a40b:: with SMTP id
 l11mr5710640ejz.25.1604003569669; 
 Thu, 29 Oct 2020 13:32:49 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 29 Oct 2020 13:32:48 -0700
From: Stefan Kangas <stefan@HIDDEN>
MIME-Version: 1.0
Date: Thu, 29 Oct 2020 13:32:48 -0700
Message-ID: <CADwFkmmEWQniZpRcAzSfh+83KkqqnP3Jd3+E0+uYZBKNTQ6=mQ@HIDDEN>
Subject: 
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  forcemerge 37858 37880 thanks 
 Content analysis details:   (2.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (stefankangas[at]gmail.com)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
 mail domains are different
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.218.48 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.218.48 listed in wl.mailspike.net]
 2.0 BLANK_SUBJECT          Subject is present but empty
 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
 EnvelopeFrom freemail headers are different
 0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
 lines
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  forcemerge 37858 37880 thanks 
 
 Content analysis details:   (1.5 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [209.85.218.48 listed in wl.mailspike.net]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [209.85.218.48 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (stefankangas[at]gmail.com)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
  0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.0 SPF_PASS               SPF: sender matches SPF record
  2.0 BLANK_SUBJECT          Subject is present but empty
  0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
  0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
                             lines
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

forcemerge 37858 37880
thanks

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 12:08:01 +0000
Resent-Message-ID: <handler.37858.B37858.165192525812949 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165192525812949
          (code B ref 37858); Sat, 07 May 2022 12:08:01 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 12:07:38 +0000
Received: from localhost ([127.0.0.1]:50703 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnJDl-0003Mg-Kf
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 08:07:37 -0400
Received: from quimby.gnus.org ([95.216.78.240]:47578)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>)
 id 1nnJDj-0003MO-Ob; Sat, 07 May 2022 08:07:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=ehkNe1p7lyCiP/LZNYMNny34hxJYNZKct19/ZF22gpI=; b=TA099xlZDx5/O8GPTNej+B8ql5
 8Ym5Wb2wz+5XO21GQgi4aCIq3ygIpZg5WFOkp7xlzUIk0wxxB4kxrWd1F0TCy1pdujB/aYEThY92a
 Fx0LwwLN8Jcwoeb+7Vi7l1TmvDZE5GTlsJUhYIqu2Dpe4EHD2jYxjjSbiAJIsKifmqu8=;
Received: from [84.212.220.105] (helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1nnJDa-0002UA-72; Sat, 07 May 2022 14:07:28 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <jwvy2xdams1.fsf@HIDDEN>
X-Now-Playing: Neil Young with Crazy Horse's _Archives Vol. II (10): Odeon
 Budokan (1976)_: "Cortez the Killer"
Date: Sat, 07 May 2022 14:07:24 +0200
In-Reply-To: <jwvy2xdams1.fsf@HIDDEN> (Stefan Monnier's message of
 "Mon, 21 Oct 2019 16:03:58 -0400")
Message-ID: <87o809pmv7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Stefan Monnier <monnier@HIDDEN> writes: > So, I'd
 like to extend our `space` specifications so as to be able to > specify a
 minimum width. I came up with the patch below which lets you > write: > >
 (space :align-to FOO :min-width BAR) > > w [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Monnier <monnier@HIDDEN> writes:

> So, I'd like to extend our `space` specifications so as to be able to
> specify a minimum width.  I came up with the patch below which lets you
> write:
>
>     (space :align-to FOO :min-width BAR)
>
> which seems to work fine, but while trying to update the Elisp doc for
> it I realized that maybe a better option is to extend the acceptable
> forms for FOO so it can be of the form:
>
>     (space :align-to (max FOO (+ BAR current-x)))

I think I'd actually prefer the first form -- it's easy to reason about,
and does what most usage cases want (i.e., align if possible, but if
not, then at least leave some space so that things don't run into each
other).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 14:31:02 +0000
Resent-Message-ID: <handler.37858.B37858.165193381029787 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165193381029787
          (code B ref 37858); Sat, 07 May 2022 14:31:02 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 14:30:10 +0000
Received: from localhost ([127.0.0.1]:52659 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnLRc-0007j9-Hg
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 10:30:09 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34204)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>)
 id 1nnLRa-0007i9-K2; Sat, 07 May 2022 10:30:03 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 27AD9100280;
 Sat,  7 May 2022 10:29:57 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 877B6100138;
 Sat,  7 May 2022 10:29:55 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1651933795;
 bh=JArbycOeo6+rxif5bCw9yLzop1flCaV2A4ZGcsYY0KI=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=S+FYSFrsC/e5+0M4Zli3atQFljucaOsxxiHMW9r+VWx5p/T8/AHnRSCp8kbg8ipoc
 jkE8nEeJcDLxT+x/kVBIV0dp4JmI21BHAmLyXrptZ9QNGvqkp3cb55UEOJf4dtiEqy
 GdpZRQ9LOoo2A6F+q8GNN6LniHfaMPqImz++8CRAq+xHuImP/DeI1sIgIqhHar2z2L
 jzasy2ZUi2pHatSuE8d/bRq9kRjbVFY6jdetFSH30quTfbGztpBQZzyEW/Ys1tfGto
 sfPHYhMPhkwAuEgMMasO2I0F1T0msisNbbmwSylRiMHh1grfRHEc+dtOwUwRE1LPC/
 RDf0kC3NY7Pqw==
Received: from alfajor (modemcable034.207-20-96.mc.videotron.ca [96.20.207.34])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5F0D512082C;
 Sat,  7 May 2022 10:29:55 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvo809h11s.fsf-monnier+emacs@HIDDEN>
References: <jwvy2xdams1.fsf@HIDDEN> <87o809pmv7.fsf@HIDDEN>
Date: Sat, 07 May 2022 10:29:54 -0400
In-Reply-To: <87o809pmv7.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sat,
 07 May 2022 14:07:24 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.075 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Lars Ingebrigtsen [2022-05-07 14:07:24] wrote:
> Stefan Monnier <monnier@HIDDEN> writes:
>> So, I'd like to extend our `space` specifications so as to be able to
>> specify a minimum width.  I came up with the patch below which lets you
>> write:
>>
>>     (space :align-to FOO :min-width BAR)
>>
>> which seems to work fine, but while trying to update the Elisp doc for
>> it I realized that maybe a better option is to extend the acceptable
>> forms for FOO so it can be of the form:
>>
>>     (space :align-to (max FOO (+ BAR current-x)))
>
> I think I'd actually prefer the first form -- it's easy to reason about,
> and does what most usage cases want (i.e., align if possible, but if
> not, then at least leave some space so that things don't run into each
> other).

The patch I came up with back then doesn't work right.  IIRC it's
because we need to change both the redisplay code and the
`current-column` code and it only changed one of the two.

IIRC, I decided then that the right fix is to rewrite the
`current-column` code to use the redisplay code (instead of trying to
mimic it), but I didn't get around to that (and IIRC it's not
completely straightforward because `current-column` currently behaves
differently *on purpose* in some cases (most importantly w.r.t treating
ellipsis-erased text) so fixing it right will imply changes in behavior
and figuring out how to do it without breaking existing uses).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 14:39:02 +0000
Resent-Message-ID: <handler.37858.B37858.165193430930642 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: larsi@HIDDEN, 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165193430930642
          (code B ref 37858); Sat, 07 May 2022 14:39:02 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 14:38:29 +0000
Received: from localhost ([127.0.0.1]:52676 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnLZk-0007y6-SY
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 10:38:29 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33656)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1nnLZi-0007xr-LZ; Sat, 07 May 2022 10:38:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:39988)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnLZc-0007Dz-NP; Sat, 07 May 2022 10:38:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=VH6BwBfsz2Va5j0BycRvvQUYQ4uMhlbufIaHnyruae8=; b=cdXllzmm0Fkb
 wWvYQdEDBl/tbwRjksVHWHJoEErN2IHBszdiJ3D9RuVLPpOoJkdj7vmv2T0zcL9rjnshU3ZhtcY7C
 PM0VzKcc8JunNVfnf4zJJramCNkVjdT4C1tsSb0ROWzxfTHx6IiC1bzrYA5uQORZPrCqS2m8RUK6B
 NFJiZX7aCmXlFMhpHX7z4zq+mVfWwgaMfLNhE3IjweEbJzcncKmyfDp0QBY3CvcaXdEs5WfCyq3Eq
 MLPRq5BV9epu9Io0sKijdQ6bnbej0IP9XH9rywogqE6dCUwh8aq5/k43J9D1ISELLVfUhsPh7igX1
 6GKQU1M7Vnif9GHSi/WiJQ==;
Received: from [87.69.77.57] (port=4350 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnLZc-0008Cx-75; Sat, 07 May 2022 10:38:20 -0400
Date: Sat, 07 May 2022 17:38:10 +0300
Message-Id: <83o809xval.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvo809h11s.fsf-monnier+emacs@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <jwvy2xdams1.fsf@HIDDEN> <87o809pmv7.fsf@HIDDEN>
 <jwvo809h11s.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
> Date: Sat, 07 May 2022 10:29:54 -0400
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> The patch I came up with back then doesn't work right.  IIRC it's
> because we need to change both the redisplay code and the
> `current-column` code and it only changed one of the two.
> 
> IIRC, I decided then that the right fix is to rewrite the
> `current-column` code to use the redisplay code (instead of trying to
> mimic it), but I didn't get around to that (and IIRC it's not
> completely straightforward because `current-column` currently behaves
> differently *on purpose* in some cases (most importantly w.r.t treating
> ellipsis-erased text) so fixing it right will imply changes in behavior
> and figuring out how to do it without breaking existing uses).

When did you last look at what current-column does in the context of
the issue being discussed here?

I'm not sure it does what you had in mind, but some changes were done
there recently, and the behavior in similar contexts did change.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 15:59:02 +0000
Resent-Message-ID: <handler.37858.B37858.165193913114561 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: larsi@HIDDEN, 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165193913114561
          (code B ref 37858); Sat, 07 May 2022 15:59:02 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 15:58:51 +0000
Received: from localhost ([127.0.0.1]:52737 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnMpX-0003mm-KW
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 11:58:51 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51273)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>)
 id 1nnMpW-0003mV-Iw; Sat, 07 May 2022 11:58:50 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D4869441133;
 Sat,  7 May 2022 11:58:44 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6739E440F24;
 Sat,  7 May 2022 11:58:43 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1651939123;
 bh=uQWEj59+C64PCE4lSHYJYgMnducMD3TCNBXDsh6lkUc=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=QfFBnyzcnepBEUIF1wVThc0e1KRwihhKsv6kPhZmMaueNkjtWsxmmcKsSjj74M/yA
 quBaBbX/9lyqNeH3yvD+PmAic/9I+C/qh/B93EOzl5mOsxhrvsi9QFBNe3ccxh08EO
 EnM101CIeeDKDzixZpvTHyP0h6U4JHk0rsIOR7ioVrRu7fTjNicHlYZbVNjlpJeJNn
 gWSUgmK7qU9+yOrcNfESGn3mTugJb6rnBcrc5yhHuTb6CwHxYYQSmVZ+M6Zs26P71m
 3aKmWLHRueMNoXGpb2ca0kbH5axpwc0xine/1z2PX8nNbzaNiSdaNa/7liaA/T7m9b
 wYbotY9WQv5PQ==
Received: from pastel (unknown [45.72.221.51])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CE58120315;
 Sat,  7 May 2022 11:58:43 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvzgjt2val.fsf-monnier+emacs@HIDDEN>
References: <jwvy2xdams1.fsf@HIDDEN> <87o809pmv7.fsf@HIDDEN>
 <jwvo809h11s.fsf-monnier+emacs@HIDDEN> <83o809xval.fsf@HIDDEN>
Date: Sat, 07 May 2022 11:58:41 -0400
In-Reply-To: <83o809xval.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 07 May
 2022 17:38:10 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.051 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii [2022-05-07 17:38:10] wrote:
> When did you last look at what current-column does in the context of
> the issue being discussed here?

It was soon after I posted this bug report.

> I'm not sure it does what you had in mind, but some changes were done
> there recently, and the behavior in similar contexts did change.

I haven't looked at recent changes in this area, so maybe things would
be a bit easier now, tho looking at `scan_for_column` in `master`,
I still see that we re-implement in `check_display_width` (part of) the
code used in `xdisp.c` to handle the display property, so AFAICT the
duplication is still present.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 16:08:01 +0000
Resent-Message-ID: <handler.37858.B37858.165193963223890 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: larsi@HIDDEN, 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165193963223890
          (code B ref 37858); Sat, 07 May 2022 16:08:01 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 16:07:12 +0000
Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnMxc-0006DF-HB
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 12:07:12 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43286)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1nnMxb-0006Cz-4C; Sat, 07 May 2022 12:07:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40786)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnMxV-0002DL-Jy; Sat, 07 May 2022 12:07:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=bYb+1BItsM1l1BuJ1Kp0hpw1fYA9hxuUabGQo0Ys0zU=; b=bs1r180nHMih
 9355OEj8CED5NyfhhqFBzDTq4kNU+EKGlE3yMa7EUSmIZO6prVJNywuGPSFf1BivijBU30a0FSLFl
 j0Ajr6IIRGCV/MOXV2/KsVhNVUTE9ErNL08tshN9p1LwMVi0F3suBkwKvPbn5MGrvKRJc/yP+DsNe
 vwnP4gs99ReBzJt7R6NfnOfaY70VNewDeZyMlQlQiqJ7eYW5Jy85gg+fnbqv1rdCtPpkR3pM9jFjv
 Oaj19zIos2s40rp3jRzsJa7bRUkqu0DVeJ+l5yDjmuKbnVLAQlCXztTMPmHlQ2a+O06FYtJQceAjo
 B5DgHRtlPz3pcQ4DZ4k/sA==;
Received: from [87.69.77.57] (port=2170 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnMxV-0004I1-3e; Sat, 07 May 2022 12:07:05 -0400
Date: Sat, 07 May 2022 19:06:55 +0300
Message-Id: <83k0axxr6o.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvzgjt2val.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Sat, 07 May 2022 11:58:41 -0400)
References: <jwvy2xdams1.fsf@HIDDEN> <87o809pmv7.fsf@HIDDEN>
 <jwvo809h11s.fsf-monnier+emacs@HIDDEN> <83o809xval.fsf@HIDDEN>
 <jwvzgjt2val.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: larsi@HIDDEN,  37880 <at> debbugs.gnu.org,  37858 <at> debbugs.gnu.org
> Date: Sat, 07 May 2022 11:58:41 -0400
> 
> I haven't looked at recent changes in this area, so maybe things would
> be a bit easier now, tho looking at `scan_for_column` in `master`,
> I still see that we re-implement in `check_display_width` (part of) the
> code used in `xdisp.c` to handle the display property, so AFAICT the
> duplication is still present.

There's no duplication.  We simply use the same infrastructure as the
display code does.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#37858: bug#37880: 27.0.50; Changing font size in Info-mode messes up formatting
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 May 2022 16:21:02 +0000
Resent-Message-ID: <handler.37858.B37858.165194045225426 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 37858
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: monnier@HIDDEN
Cc: larsi@HIDDEN, 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
Received: via spool by 37858-submit <at> debbugs.gnu.org id=B37858.165194045225426
          (code B ref 37858); Sat, 07 May 2022 16:21:02 +0000
Received: (at 37858) by debbugs.gnu.org; 7 May 2022 16:20:52 +0000
Received: from localhost ([127.0.0.1]:52827 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnNAp-0006c1-Mm
	for submit <at> debbugs.gnu.org; Sat, 07 May 2022 12:20:52 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45338)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1nnNAn-0006bl-IR; Sat, 07 May 2022 12:20:50 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:41420)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnNAh-0004LK-C8; Sat, 07 May 2022 12:20:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=/K0+23AQ5uHMu9t1oHXUOowUfHPxJNKVvPRk6bdw55g=; b=kX+SBKe07L5M
 xKbqhtqS1wNJC6QUwxtemKRJlMQr5hJeX8XGnz3GiRolWxy6AyzmXyjcCwlgUciYcvib+S3B7z4yM
 aNLInj0NKF1isd3aoc/yDjD9a4Py0XCEDsN9o1kb97Z6vUgI2R6eWc6XRudTxPIbZEt1qyUQ8TmIZ
 +2giH+bxi/uBYostKKOZgEi3N2RhcZetpnAF4qGzkQ1d+/I2bruf3VWOUs57+mCxXyJZ/wlHEGi9/
 ZSIk2PpRsX3JmXP9Cuv12MpYJepk0tIC05W3zyag9+IHi+Mr2h+VDBsTXxrD4hvcqtV6E9G3A1rrQ
 YPcz59iE3A1m5f4a2qGGyA==;
Received: from [87.69.77.57] (port=3009 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nnNAg-0005y8-SR; Sat, 07 May 2022 12:20:43 -0400
Date: Sat, 07 May 2022 19:20:33 +0300
Message-Id: <83fsllxqjy.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <83k0axxr6o.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 07
 May 2022 19:06:55 +0300)
References: <jwvy2xdams1.fsf@HIDDEN> <87o809pmv7.fsf@HIDDEN>
 <jwvo809h11s.fsf-monnier+emacs@HIDDEN> <83o809xval.fsf@HIDDEN>
 <jwvzgjt2val.fsf-monnier+emacs@HIDDEN> <83k0axxr6o.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: larsi@HIDDEN, 37880 <at> debbugs.gnu.org, 37858 <at> debbugs.gnu.org
> Date: Sat, 07 May 2022 19:06:55 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > From: Stefan Monnier <monnier@HIDDEN>
> > Cc: larsi@HIDDEN,  37880 <at> debbugs.gnu.org,  37858 <at> debbugs.gnu.org
> > Date: Sat, 07 May 2022 11:58:41 -0400
> > 
> > I haven't looked at recent changes in this area, so maybe things would
> > be a bit easier now, tho looking at `scan_for_column` in `master`,
> > I still see that we re-implement in `check_display_width` (part of) the
> > code used in `xdisp.c` to handle the display property, so AFAICT the
> > duplication is still present.
> 
> There's no duplication.  We simply use the same infrastructure as the
> display code does.

And, btw, I don't think I agree with your assertion that we should use
the display routines for current-column and friends.  The
column-oriented functions count actual (not canonical) columns,
whereas display code counts pixels.  It makes little sense to me to
call the display code, which will load fonts, call jit-lock, and
whatnot, just to count columns like current-column expects.

Last modified: Sat, 7 May 2022 16:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.