GNU bug report logs - #37863
[PATCH] gnu: emacs-helm-projectile: Apply patch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37863 in the body.
You can then email your comments to 37863 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Webber <montokapro <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Stephen Webber <montokapro <at> gmail.com>
Subject: [PATCH] gnu: emacs-helm-projectile: Apply patch.
Date: Mon, 21 Oct 2019 22:16:40 -0500

* gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Apply patch.
* gnu/packages/patches/emacs-helm-projectile-require-dash.patch: New file.
---
 gnu/packages/emacs-xyz.scm                          |  4 +++-
 .../emacs-helm-projectile-require-dash.patch        | 13 +++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/emacs-helm-projectile-require-dash.patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8c3c50efdc..5ed2cf67bc 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6967,7 +6967,9 @@ as well as features for editing search results.")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
+        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))
+       (patches
+        (search-patches "emacs-helm-projectile-require-dash.patch"))))
     (build-system emacs-build-system)
     (propagated-inputs
      `(("emacs-dash" ,emacs-dash)
diff --git a/gnu/packages/patches/emacs-helm-projectile-require-dash.patch b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
new file mode 100644
index 0000000000..9da3deff50
--- /dev/null
+++ b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
@@ -0,0 +1,13 @@
+Make dash dependency explicit - this issue is resolved in master and is
+documented at https://github.com/bbatsov/helm-projectile/issues/120
+
+--- a/helm-projectile.el
++++ b/helm-projectile.el
+@@ -41,6 +41,7 @@
+ 
+ (require 'projectile)
+ (require 'cl-lib)
++(require 'dash)
+ (require 'grep)
+ (require 'helm)
+ (require 'helm-types)
-- 
2.23.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37863 <at> debbugs.gnu.org, Stephen Webber <montokapro <at> gmail.com>
Subject: Re: [bug#37863] [PATCH] gnu: emacs-helm-projectile: Apply patch.
Date: Mon, 28 Oct 2019 15:45:55 +0100

Hello Stephen,

As this project seems unmaintained and the last release was in 2016, I
think the best option would be to package a 0.14.0-1 based on
helm-projectile last commit.

Thanks,

Mathieu

Stephen Webber writes:

> * gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Apply patch.
> * gnu/packages/patches/emacs-helm-projectile-require-dash.patch: New file.
> ---
>  gnu/packages/emacs-xyz.scm                          |  4 +++-
>  .../emacs-helm-projectile-require-dash.patch        | 13 +++++++++++++
>  2 files changed, 16 insertions(+), 1 deletion(-)
>  create mode 100644 gnu/packages/patches/emacs-helm-projectile-require-dash.patch
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8c3c50efdc..5ed2cf67bc 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -6967,7 +6967,9 @@ as well as features for editing search results.")
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
> +        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))
> +       (patches
> +        (search-patches "emacs-helm-projectile-require-dash.patch"))))
>      (build-system emacs-build-system)
>      (propagated-inputs
>       `(("emacs-dash" ,emacs-dash)
> diff --git a/gnu/packages/patches/emacs-helm-projectile-require-dash.patch b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> new file mode 100644
> index 0000000000..9da3deff50
> --- /dev/null
> +++ b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> @@ -0,0 +1,13 @@
> +Make dash dependency explicit - this issue is resolved in master and is
> +documented at https://github.com/bbatsov/helm-projectile/issues/120
> +
> +--- a/helm-projectile.el
> ++++ b/helm-projectile.el
> +@@ -41,6 +41,7 @@
> + 
> + (require 'projectile)
> + (require 'cl-lib)
> ++(require 'dash)
> + (require 'grep)
> + (require 'helm)
> + (require 'helm-types)

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Webber <montokapro <at> gmail.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 37863 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#37863] [PATCH] gnu: emacs-helm-projectile: Apply patch.
Date: Tue, 29 Oct 2019 00:06:30 +0000

[Message part 1 (text/plain, inline)]

Mathieu,

Great! I chose this PR because I wanted to learn when patching was deemed
appropriate. Thank you for the suggestion.

On Mon, Oct 28, 2019 at 2:45 PM Mathieu Othacehe <m.othacehe <at> gmail.com>
wrote:

>
> Hello Stephen,
>
> As this project seems unmaintained and the last release was in 2016, I
> think the best option would be to package a 0.14.0-1 based on
> helm-projectile last commit.
>
> Thanks,
>
> Mathieu
>
> Stephen Webber writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Apply patch.
> > * gnu/packages/patches/emacs-helm-projectile-require-dash.patch: New
> file.
> > ---
> >  gnu/packages/emacs-xyz.scm                          |  4 +++-
> >  .../emacs-helm-projectile-require-dash.patch        | 13 +++++++++++++
> >  2 files changed, 16 insertions(+), 1 deletion(-)
> >  create mode 100644
> gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> >
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> > index 8c3c50efdc..5ed2cf67bc 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -6967,7 +6967,9 @@ as well as features for editing search results.")
> >               (commit (string-append "v" version))))
> >         (file-name (git-file-name name version))
> >         (sha256
> > -        (base32
> "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
> > +        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))
> > +       (patches
> > +        (search-patches "emacs-helm-projectile-require-dash.patch"))))
> >      (build-system emacs-build-system)
> >      (propagated-inputs
> >       `(("emacs-dash" ,emacs-dash)
> > diff --git
> a/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> > new file mode 100644
> > index 0000000000..9da3deff50
> > --- /dev/null
> > +++ b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> > @@ -0,0 +1,13 @@
> > +Make dash dependency explicit - this issue is resolved in master and is
> > +documented at https://github.com/bbatsov/helm-projectile/issues/120
> > +
> > +--- a/helm-projectile.el
> > ++++ b/helm-projectile.el
> > +@@ -41,6 +41,7 @@
> > +
> > + (require 'projectile)
> > + (require 'cl-lib)
> > ++(require 'dash)
> > + (require 'grep)
> > + (require 'helm)
> > + (require 'helm-types)
>
>

[Message part 2 (text/html, inline)]

Message #20 received at 37863 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Webber <montokapro <at> gmail.com>
To: 37863 <at> debbugs.gnu.org
Cc: Stephen Webber <montokapro <at> gmail.com>
Subject: [PATCH v2] gnu: emacs-helm-projectile: Update package.
Date: Mon, 28 Oct 2019 20:46:58 -0500

* gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Update package.
---
 gnu/packages/emacs-xyz.scm | 48 +++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ce8739a77..67f9c8c3be 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6955,29 +6955,33 @@ for search-based navigation of buffers.")
 as well as features for editing search results.")
       (license license:gpl3+))))
 
+;; There hasn't been a tag or release since 2016, so we take the latest
+;; commit.
 (define-public emacs-helm-projectile
-  (package
-    (name "emacs-helm-projectile")
-    (version "0.14.0")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/bbatsov/helm-projectile.git")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-dash" ,emacs-dash)
-       ("emacs-helm" ,emacs-helm)
-       ("emacs-projectile" ,emacs-projectile)))
-    (home-page "https://github.com/bbatsov/helm-projectile")
-    (synopsis "Helm integration for Projectile")
-    (description
-     "This Emacs library provides a Helm interface for Projectile.")
-    (license license:gpl3+)))
+  (let ((commit "5328b74dddcee8d1913803ca8167868831a07463")
+        (version "0.14.0")
+        (revision "1"))
+    (package
+      (name "emacs-helm-projectile")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/bbatsov/helm-projectile.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0a811cblrvc8llpv771b8dppgxs6bwjyvjy3qn2xns4nigvn93s0"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-helm" ,emacs-helm)
+         ("emacs-projectile" ,emacs-projectile)))
+      (home-page "https://github.com/bbatsov/helm-projectile")
+      (synopsis "Helm integration for Projectile")
+      (description
+       "This Emacs library provides a Helm interface for Projectile.")
+      (license license:gpl3+))))
 
 (define-public emacs-taskrunner
   (let ((commit "3afd4a546d42339543d3d4e51b175fc3e82b3358")
-- 
2.23.0

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37863-done <at> debbugs.gnu.org, Stephen Webber <montokapro <at> gmail.com>
Subject: Re: [bug#37863] [PATCH v2] gnu: emacs-helm-projectile: Update package.
Date: Tue, 29 Oct 2019 09:27:10 +0100

Pushed, thanks :)

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.