GNU bug report logs - #37912
[PATCH] gnu: elixir: Update to 1.9.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37912 in the body.
You can then email your comments to 37912 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oskar Köök <oskar <at> maatriks.ee>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: elixir: Update to 1.9.2.
Date: Thu, 24 Oct 2019 22:45:22 +0200 (CEST)

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-gnu-elixir-Update-to-1.9.2.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37912 <at> debbugs.gnu.org
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Fri, 25 Oct 2019 14:16:12 +0200

Hello,

When building elixir with this patch, I have the following error:

--8<---------------cut here---------------start------------->8---
Finished in 363.7 seconds (2.5s on load, 361.1s on tests)
9 doctests, 625 tests, 6 failures

Randomized with seed 237287
make: *** [Makefile:113: test_mix] Error 1

Test suite failed, dumping logs.
command "make" "test" "PREFIX=/gnu/store/q95v9n7c0nhrkqmn1xhr785zqi4mp81k-elixir-1.9.2" failed with status 2
builder for `/gnu/store/clqdccpnxbz4wg4c37shsn59d1y4b9wq-elixir-1.9.2.drv' failed with exit code 1
build of /gnu/store/clqdccpnxbz4wg4c37shsn59d1y4b9wq-elixir-1.9.2.drv failed
View build log at '/var/log/guix/drvs/cl/qdccpnxbz4wg4c37shsn59d1y4b9wq-elixir-1.9.2.drv.bz2'.
guix build: error: build of `/gnu/store/clqdccpnxbz4wg4c37shsn59d1y4b9wq-elixir-1.9.2.drv' failed
--8<---------------cut here---------------end--------------->8---

any idea why?

Thanks,

Mathieu

Message #14 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Oskar Köök <oskar <at> maatriks.ee>
To: <37912 <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Thu, 31 Oct 2019 15:35:42 +0100 (CET)

[Message part 1 (text/plain, inline)]

Sorry, first time using Guix.

Some Elixir tests are failing, caused by a new feature. I have locally fixed most of the issues related to this (I can now manually run the Makefile in the generated Guix folder without any tests failing), but I am stuck on a part where the tests spawn binaries and wait for a certain file to be created in a certain location. This does not work during the Guix build.

I will examine further over the weekend. If I can not fix these tests, is it acceptable to disable them? I can verify that the behaviour being tested works manually.

Oskar

[Message part 2 (text/html, inline)]

Message #17 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oskar Köök <oskar <at> maatriks.ee>, 37912 <at> debbugs.gnu.org
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Thu, 31 Oct 2019 23:54:49 +0100

[Message part 1 (text/plain, inline)]

Oskar Köök <oskar <at> maatriks.ee> writes:

> Sorry, first time using Guix.
>
> Some Elixir tests are failing, caused by a new feature. I have locally fixed most of the issues related to this (I can now manually run the Makefile in the generated Guix folder without any tests failing), but I am stuck on a part where the tests spawn binaries and wait for a certain file to be created in a certain location. This does not work during the Guix build.

Perhaps it requires a network connection?  Or /bin/sh?  Those are the
most common sources of things failing in the build container but not on
a "regular" system.

> I will examine further over the weekend. If I can not fix these tests, is it acceptable to disable them? I can verify that the behaviour being tested works manually.

We should find out why they are failing in either case.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Oskar Köök <oskar <at> maatriks.ee>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 37912 <37912 <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Fri, 1 Nov 2019 14:45:04 +0100 (CET)

[Message part 1 (text/plain, inline)]

Thank you for your response!

You were right, /bin/sh was the issue. I did some grepping and found Elixir was generating files that depend on /bin/sh. I am now able to build Elixir 1.9.2 on Guix.

I am attaching the patch to this e-mail. Please format/fix the code as necessary, I am not too familiar with Guile and other Scheme/Lisp languages.

Oskar


Nov 1, 2019, 00:54 by mbakke <at> fastmail.com:

> Oskar Köök <oskar <at> maatriks.ee> writes:
>
>> Sorry, first time using Guix.
>>
>> Some Elixir tests are failing, caused by a new feature. I have locally fixed most of the issues related to this (I can now manually run the Makefile in the generated Guix folder without any tests failing), but I am stuck on a part where the tests spawn binaries and wait for a certain file to be created in a certain location. This does not work during the Guix build.
>>
>
> Perhaps it requires a network connection?  Or /bin/sh?  Those are the
> most common sources of things failing in the build container but not on
> a "regular" system.
>
>> I will examine further over the weekend. If I can not fix these tests, is it acceptable to disable them? I can verify that the behaviour being tested works manually.
>>
>
> We should find out why they are failing in either case.  :-)
>

[Message part 2 (text/html, inline)]

[0001-gnu-elixir-Update-to-1.9.2.patch (text/x-patch, attachment)]

Message #23 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Oskar Köök <oskar <at> maatriks.ee>
To: 37912 <37912 <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Fri, 1 Nov 2019 15:09:25 +0100 (CET)

[Message part 1 (text/plain, inline)]

Although I must note that the end-result ends up ruining the whole point of Elixir Releases.

The point of an Elixir release is that you can package an application into a stand-alone item. It will copy elixir & erlang (etc) as well as your application into a single package, so you can run it without having elixir & erlang installed on your system.

I guess the single dependency here is /bin/sh: as long as it exists, you can run the application from any system.

If you were to generate a release with Guix, you would end up with scripts that depend on the Guix store. So you can not run the stand-alone without Guix.

What is the solution to this? I would personally prefer to keep the actual behaviour (if possible) and if needed, disable the tests.

Oskar

[Message part 2 (text/html, inline)]

Message #26 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oskar Köök <oskar <at> maatriks.ee>, 37912
 <37912 <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Sun, 03 Nov 2019 17:52:06 +0100

[Message part 1 (text/plain, inline)]

Oskar Köök <oskar <at> maatriks.ee> writes:

> Although I must note that the end-result ends up ruining the whole point of Elixir Releases.
>
> The point of an Elixir release is that you can package an application into a stand-alone item. It will copy elixir & erlang (etc) as well as your application into a single package, so you can run it without having elixir & erlang installed on your system.
>
> I guess the single dependency here is /bin/sh: as long as it exists, you can run the application from any system.
>
> If you were to generate a release with Guix, you would end up with scripts that depend on the Guix store. So you can not run the stand-alone without Guix.
>
> What is the solution to this? I would personally prefer to keep the actual behaviour (if possible) and if needed, disable the tests.

The typical solution here is to reset the shebang after running the
tests.  I know there are a couple of packages doing this, but can't
recall which at the moment.

Can you try that?  Thanks for working on it!

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 37912-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oskar Köök <oskar <at> maatriks.ee>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 37912 <37912-done <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Sat, 16 Nov 2019 17:34:57 +0100

Hi Oskar,

Oskar Köök <oskar <at> maatriks.ee> skribis:

>>From f2eb88f567f93e578e3c2df76046fed4f45645f8 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Oskar=20K=C3=B6=C3=B6k?= <oskarkook <at> maatriks.ee>
> Date: Thu, 24 Oct 2019 23:37:38 +0300
> Subject: [PATCH] gnu: elixir: Update to 1.9.2.
>
> * gnu/packages/elixir.scm (elixir): Update to 1.9.2.

Thanks for the updated patch!  I believe this addresses the comments
that Marius made, and it builds fine for me, so I went ahead and applied
it.

Thank you!

Ludo’.

Message #34 received at 37912 <at> debbugs.gnu.org (full text, mbox):

From: Oskar Köök <oskar <at> maatriks.ee>
To: 37912 <37912 <at> debbugs.gnu.org>
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Sat, 16 Nov 2019 20:01:16 +0100 (CET)

[Message part 1 (text/plain, inline)]

Hi

Thanks. I went ahead and did some further reading on the constraints of Elixir Releases and in the end it seems the current behaviour is actually just fine.

The documentation itself notes that there is already effectively a dependency on package managers:
> In addition to matching the target triple, it is also important that thetarget has all of the system packages that your application will need atruntime. A common one is the need for OpenSSL when building an applicationthat uses :crypto or :ssl, which is dynamically linked to ERTS. The othercommon source for native dependencies like this comes from dependenciescontaining NIFs (natively-implemented functions) which may expect todynamically link to libraries they use.
> These system packages are typically managed using the system package manager,but if necessary, you can also bundle the compiled object files in the release,as long as they were compiled for the same target.

This means that if you're creating an Elixir Release with Elixir built in Guix, you should also have the needed Guix packages installed on your target. Optionally the user can create a script that modifies the release to be compatible with the target (e.g. replace /gnu/store/* references with /bin/*).

Oskar


Nov 16, 2019, 18:34 by ludo <at> gnu.org:

> Hi Oskar,
>
> Oskar Köök <oskar <at> maatriks.ee> skribis:
>
> >>From f2eb88f567f93e578e3c2df76046fed4f45645f8 Mon Sep 17 00:00:00 2001
>
>> From: =?UTF-8?q?Oskar=20K=C3=B6=C3=B6k?= <oskarkook <at> maatriks.ee>
>> Date: Thu, 24 Oct 2019 23:37:38 +0300
>> Subject: [PATCH] gnu: elixir: Update to 1.9.2.
>>
>> * gnu/packages/elixir.scm (elixir): Update to 1.9.2.
>>
>
> Thanks for the updated patch!  I believe this addresses the comments
> that Marius made, and it builds fine for me, so I went ahead and applied
> it.
>
> Thank you!
>
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #37 received at 37912-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, Oskar Köök <oskar <at> maatriks.ee>
Cc: 37912 <37912-done <at> debbugs.gnu.org>
Subject: Re: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2.
Date: Sun, 17 Nov 2019 19:29:05 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Oskar,
>
> Oskar Köök <oskar <at> maatriks.ee> skribis:
>
>>>From f2eb88f567f93e578e3c2df76046fed4f45645f8 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Oskar=20K=C3=B6=C3=B6k?= <oskarkook <at> maatriks.ee>
>> Date: Thu, 24 Oct 2019 23:37:38 +0300
>> Subject: [PATCH] gnu: elixir: Update to 1.9.2.
>>
>> * gnu/packages/elixir.scm (elixir): Update to 1.9.2.
>
> Thanks for the updated patch!  I believe this addresses the comments
> that Marius made, and it builds fine for me, so I went ahead and applied
> it.
>
> Thank you!

Whoops, this patch fell through the cracks, thanks for taking care of it.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.