GNU bug report logs - #37919
[PATCH] gnu: electron-cash: Update to 4.0.10.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37919 in the body.
You can then email your comments to 37919 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Fri, 25 Oct 2019 11:35:55 +0200

Some icons are not showing properly in the application because it wants
PyQt 5.12.* and Guix only has PyQt 5.11.3 so far. The current packaged version
of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
why. Anyway, it doesn't prevent the application from working (sending and
receiving transactions, etc).

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Fri, 25 Oct 2019 11:35:56 +0200

* gnu/packages/finance.scm (electron-cash): Update to 4.0.10.
  [inputs]: Add python-dateutil.
  [documentation]: Keep line width below 80.
---
 gnu/packages/finance.scm | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 960e3adeb3..1f2d9ada04 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -76,6 +76,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
+  #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages upnp)
   #:use-module (gnu packages version-control)
@@ -413,7 +414,7 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
   (package
     (inherit electrum)
     (name "electron-cash")
-    (version "4.0.7")
+    (version "4.0.10")
     (source
      (origin
        (method url-fetch)
@@ -424,20 +425,24 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
                            ".tar.gz"))
        (sha256
         (base32
-         "0xswmr68cm1c77lzisi3z812jzqczm9dfrshfhdq42zz5kaz4gnn"))
+         "1rcywlma6hk52ymisx536jvkdwa73rhn1jxhsbs4wbvajl90w9s8"))
        (modules '((guix build utils)))
        (snippet
         '(begin
            ;; Delete the bundled dependencies.
            (delete-file-recursively "packages")
            #t))))
+    (inputs
+     `(("python-dateutil" ,python-dateutil)
+       ,@(package-inputs electrum)))
     (home-page "https://electroncash.org/")
     (synopsis "Bitcoin Cash wallet")
     (description
-     "Electroncash is a lightweight Bitcoin Cash client, based on a client-server
-protocol.  It supports Simple Payment Verification (SPV) and deterministic key
-generation from a seed.  Your secret keys are encrypted and are never sent to
-other machines/servers.  Electroncash does not download the Bitcoin Cash blockchain.")
+     "Electroncash is a lightweight Bitcoin Cash client, based on
+a client-server protocol.  It supports Simple Payment Verification (SPV) and
+deterministic key generation from a seed.  Your secret keys are encrypted and
+are never sent to other machines/servers.  Electroncash does not download the
+Bitcoin Cash blockchain.")
     (license license:expat)))
 
 (define-public monero
-- 
2.23.0

Message #11 received at 37919 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 37919 <at> debbugs.gnu.org
Subject: Re: [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Fri, 25 Oct 2019 13:41:30 +0300

[Message part 1 (text/plain, inline)]

On Fri, Oct 25, 2019 at 11:35:55AM +0200, Guillaume Le Vaillant wrote:
> Some icons are not showing properly in the application because it wants
> PyQt 5.12.* and Guix only has PyQt 5.11.3 so far.

qt-5.12 and pyqt-5.12 are coming soon™ with the staging branch.

>                                                   The current packaged version
> of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
> why. Anyway, it doesn't prevent the application from working (sending and
> receiving transactions, etc).
> 

If it already has the problem then I don't see it being a blocker. Are
you sure the new version doesn't want qt-5.13+? We haven't started with
that yet.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37919 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37919 <at> debbugs.gnu.org
Subject: Re: [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Fri, 25 Oct 2019 13:40:43 +0200

Efraim Flashner skribis:

> If it already has the problem then I don't see it being a blocker. Are
> you sure the new version doesn't want qt-5.13+? We haven't started with
> that yet.

Yes, when the program starts it shows the following warning:

--8<---------------cut here---------------start------------->8---
Electron Cash on Linux requires PyQt5 5.12+.

You have version 5.11.3 installed.

Please upgrade otherwise you may experience font rendering issues
with emojis and other unicode characters used by Electron Cash.
--8<---------------cut here---------------end--------------->8---

Message #17 received at 37919 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 37919 <at> debbugs.gnu.org
Subject: Re: [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Tue, 26 Nov 2019 11:48:14 +0100

Hello!

What’s the conclusion regarding this upgrade?  Should we apply it or
not?  :-)

  https://issues.guix.gnu.org/issue/37919

TIA,
Ludo’.

Message #20 received at 37919 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 37919 <at> debbugs.gnu.org
Subject: Re: [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Wed, 27 Nov 2019 11:20:55 +0100

Ludovic Courtès skribis:

> Hello!
>
> What’s the conclusion regarding this upgrade?  Should we apply it or
> not?  :-)
>
>   https://issues.guix.gnu.org/issue/37919
>
> TIA,
> Ludo’.

As there's been another release of electron-cash since, I think we could
close this issue, wait for the staging branch which has Qt 5.12 to be
merged, and make a new upgrade patch for electron-cash then.

Message #25 received at 37919-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 37919-done <at> debbugs.gnu.org
Subject: Re: [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
Date: Thu, 28 Nov 2019 09:30:06 +0100

Hi Guillaume,

Guillaume Le Vaillant <glv <at> posteo.net> skribis:

> Ludovic Courtès skribis:
>
>> Hello!
>>
>> What’s the conclusion regarding this upgrade?  Should we apply it or
>> not?  :-)
>>
>>   https://issues.guix.gnu.org/issue/37919
>>
>> TIA,
>> Ludo’.
>
> As there's been another release of electron-cash since, I think we could
> close this issue, wait for the staging branch which has Qt 5.12 to be
> merged, and make a new upgrade patch for electron-cash then.

Sounds good, closing it!

I think we’ll all have to take care of ‘staging’, it needs more
attention.  :-)

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.