GNU bug report logs - #37934
makefile colors messed up by ://

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Sat, 26 Oct 2019 14:07:02 UTC

Severity: normal

Tags: confirmed, patch

Merged with 17400, 33681, 33900, 35299, 36245, 45037, 46052, 46221, 48052, 76759

Found in version 26.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37934 in the body.
You can then email your comments to 37934 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37934; Package emacs. (Sat, 26 Oct 2019 14:07:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 26 Oct 2019 14:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: makefile colors messed up by ://
Date: Sat, 26 Oct 2019 19:45:37 +0800

$ cat makefile
x:
	echo This line is the correct color.
	echo This line is not. Because it contains the string file:// in it.
$ emacs -nw -Q makefile
emacs-version "26.3"
Added tag(s) confirmed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 30 Oct 2019 11:11:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37934; Package emacs. (Wed, 30 Oct 2019 11:13:01 GMT) Full text and rfc822 format available.

Message #10 received at 37934 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 37934 <at> debbugs.gnu.org
Subject: Re: makefile colors messed up by ://
Date: Wed, 30 Oct 2019 12:12:00 +0100

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> $ cat makefile
> x:
> 	echo This line is the correct color.
> 	echo This line is not. Because it contains the string file:// in it.

I can confirm that this bug is still in Emacs.  The problem is this regexp:

(defvar makefile-dependency-regex
  ;; Allow for two nested levels $(v1:$(v2:$(v3:a=b)=c)=d)
  "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n$#})]+?[})]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#:=]\\)+?\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)"
  "Regex used to find dependency lines in a makefile.")

Of which I can only say...  "eek".

I wonder -- has anybody considered rewriting make-mode.el using
syntax-ppss?  Or is the syntax just too intractable for that?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Forcibly Merged 37934 48052. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 27 Apr 2021 00:14:02 GMT) Full text and rfc822 format available.
Forcibly Merged 17400 33681 33900 35299 36245 37934 45037 46052 46221 48052. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 27 Apr 2021 00:18:02 GMT) Full text and rfc822 format available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 27 Sep 2021 10:43:02 GMT) Full text and rfc822 format available.
Merged 17400 33681 33900 35299 36245 37934 45037 46052 46221 48052 76759. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 05 Mar 2025 13:29:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 07 Apr 2025 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 31 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.