GNU bug report logs - #37945
Saving file erases minor mode font locking.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37945 in the body.
You can then email your comments to 37945 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Prashant Sachdeva <sachdevaprash <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: Saving file erases minor mode font locking.
Date: Sun, 27 Oct 2019 10:45:09 -0700

[Message part 1 (text/plain, inline)]

When saving files, the lisp files for some style files (e.g. expl3, minted)
call font-latex-update-font-lock, which has the following lines to revert
the font locking to defaults (around line 1287-88 of font-latex.el):

(setq font-lock-set-defaults nil)
(font-lock-set-defaults)

This removes any font locking done by minor modes (e.g. hl-todo-mode,
outshine-mode). There should be another way of applying these styles that
does not override previously set font properties, or reapplies the font
lock applied by minor modes.

Emacs  : GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, Carbon Version
158 AppKit 1671.6)
 of 2019-10-19
Package: 12.1.2

Also covered as a bug in hl-todo-mode
<https://github.com/tarsius/hl-todo/issues/26#issuecomment-546637535>.

- Prashant

[Message part 2 (text/html, inline)]

Message #8 received at 37945 <at> debbugs.gnu.org (full text, mbox):

From: Dominik Schrempf <dominik.schrempf <at> gmail.com>
To: 37945 <at> debbugs.gnu.org
Subject: [Auctex] Revert font locking to defaults
Date: Tue, 09 Jun 2020 13:20:48 +0200

Dear all,

I wanted to inquire on the status of the mentioned report since
the issue has not been resolved. Custom font lock is still broken with LaTeX
files in Emacs.

See https://github.com/tarsius/hl-todo/issues/26.

Best,
Dominik

Message #11 received at 37945 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Dominik Schrempf <dominik.schrempf <at> gmail.com>
Cc: 37945 <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Wed, 10 Jun 2020 20:59:47 +0200

Dominik Schrempf <dominik.schrempf <at> gmail.com> writes:

> I wanted to inquire on the status of the mentioned report since the
> issue has not been resolved. Custom font lock is still broken with
> LaTeX files in Emacs.

If you can, you can test-drive the AUCTeX branch
obsolete-font-latex-update-font-lock where I hopefully fixed that issue
(and maybe introduced other breakage while doing it).

Feedback welcome!
Tassilo

Message #14 received at 37945 <at> debbugs.gnu.org (full text, mbox):

From: Dominik Schrempf <dominik.schrempf <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 37945 <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Thu, 11 Jun 2020 13:34:31 +0200

Hi,

thanks a lot for working on this. I tested the mentioned branch and indeed, it
works flawlessly. As far as I can see now, no other regressions were introduced,
and I sincerely hope it stays like this!

Best,
Dominik

Tassilo Horn <tsdh <at> gnu.org> writes:

> Dominik Schrempf <dominik.schrempf <at> gmail.com> writes:
>
>> I wanted to inquire on the status of the mentioned report since the
>> issue has not been resolved. Custom font lock is still broken with
>> LaTeX files in Emacs.
>
> If you can, you can test-drive the AUCTeX branch
> obsolete-font-latex-update-font-lock where I hopefully fixed that issue
> (and maybe introduced other breakage while doing it).
>
> Feedback welcome!
> Tassilo

Message #17 received at 37945 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Dominik Schrempf <dominik.schrempf <at> gmail.com>
Cc: 37945 <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Thu, 11 Jun 2020 20:55:37 +0200

Dominik Schrempf <dominik.schrempf <at> gmail.com> writes:

Hi Dominik,

> thanks a lot for working on this.  I tested the mentioned branch and
> indeed, it works flawlessly.  As far as I can see now, no other
> regressions were introduced,

That's good news.  I give it some days of testing by others and then
I'll merge it into master.  So hopefully it'll be fixed in GNU AUCTeX
12.2.4.

> and I sincerely hope it stays like this!

Gosh, don't put too much pressure on me! :-)

Bye,
Tassilo

Message #22 received at 37945-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Dominik Schrempf <dominik.schrempf <at> gmail.com>
Cc: 37945-done <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Sun, 14 Jun 2020 14:20:47 +0200

Tassilo Horn <tsdh <at> gnu.org> writes:

>> thanks a lot for working on this.  I tested the mentioned branch and
>> indeed, it works flawlessly.  As far as I can see now, no other
>> regressions were introduced,
>
> That's good news.  I give it some days of testing by others and then
> I'll merge it into master.  So hopefully it'll be fixed in GNU AUCTeX
> 12.2.4.

Ok, the branch is now merged into master and we'll be doing a new ELPA
release in some days.

I'm closing this report now.  Thanks a lot for testing!

Bye,
Tassilo

Message #25 received at 37945-done <at> debbugs.gnu.org (full text, mbox):

From: Dominik Schrempf <dominik.schrempf <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 37945-done <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Sun, 14 Jun 2020 18:19:19 +0200

Thank you!

Tassilo Horn <tsdh <at> gnu.org> writes:

> Tassilo Horn <tsdh <at> gnu.org> writes:
>
>>> thanks a lot for working on this.  I tested the mentioned branch and
>>> indeed, it works flawlessly.  As far as I can see now, no other
>>> regressions were introduced,
>>
>> That's good news.  I give it some days of testing by others and then
>> I'll merge it into master.  So hopefully it'll be fixed in GNU AUCTeX
>> 12.2.4.
>
> Ok, the branch is now merged into master and we'll be doing a new ELPA
> release in some days.
>
> I'm closing this report now.  Thanks a lot for testing!
>
> Bye,
> Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.