GNU bug report logs - #37979
[PATCH 1/1] * audio.scm (define public lilv): enable python bindings

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Florian Paul Schmidt <florian_paul.schmidt@HIDDEN>; Keywords: patch; dated Tue, 29 Oct 2019 14:39:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 37979 <at> debbugs.gnu.org:


Received: (at 37979) by debbugs.gnu.org; 30 Oct 2019 09:48:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 30 05:48:45 2019
Received: from localhost ([127.0.0.1]:49261 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iPkaq-0004Vg-CG
	for submit <at> debbugs.gnu.org; Wed, 30 Oct 2019 05:48:45 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:35333)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <m.othacehe@HIDDEN>) id 1iPkak-0004V7-WA
 for 37979 <at> debbugs.gnu.org; Wed, 30 Oct 2019 05:48:39 -0400
Received: by mail-wm1-f66.google.com with SMTP id x5so1386673wmi.0
 for <37979 <at> debbugs.gnu.org>; Wed, 30 Oct 2019 02:48:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=references:user-agent:from:to:cc:subject:in-reply-to:date
 :message-id:mime-version;
 bh=AFGLqkVEyup6xunCCKuGHKeOFs7b6oQQOQJgkFA4mzw=;
 b=PP639d7VBA5j1xkj5RDZC6U8fdmWJIVqfQvKhi70Ou1aQYbQD3EekPazKK0PNFd3wP
 hFpEF9y2pR1F1hl070wu/TURNVYaqm6O5UQMwEUSqpl7zQbXvo9FT3X34DxV9oqdHDDo
 +cmybvkTi5nQGoViZlTAoR/BajJSjBBi6vag8q3vMvnwzKg1OjW4bFmu+U4QR5eiXjCu
 9Hyw3DJPEI9uk15WMo3fql8iHd0Z1egFseiYKXZFtAEYs/r4VP3Qk65TadWpuWRIyk4/
 N10JATwao/t3FMP3jaaMcPlfXxyG6QhuQkj9ultsgF1T8JKYhxyYKBSw/dhP1xmmeB4L
 86hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:references:user-agent:from:to:cc:subject
 :in-reply-to:date:message-id:mime-version;
 bh=AFGLqkVEyup6xunCCKuGHKeOFs7b6oQQOQJgkFA4mzw=;
 b=jAJIbEi1mU8WtkB0vLRY0H+iJPyXEGpvWXXbAITcAID4KPNPYfN36o0Io1YXE4Rwkr
 7BLFWrwoeSwHNMaeYtVfv+TJHdg6RjJ/4een6kLw0MqRr+N6STrzGWtnFvL+nlGUN2TC
 afiFm2HmXuhgcsoseJzFTMtC6PCm5HivqFWAbjuSBzUxMG306XgHrhQIWr5zEVXPE1ih
 BAjXkcfGgor8NpFqDmkG4aox3vHdgJB3VwpblS+g2+oJgRR210dAWzmoi8U4a1RYOI2u
 hJhuiaWc4Bm1RBCvbGUXkJory3Nqj5wW0eNC80Y7t8FchvyfwyvyDql6iSmnvBLajnFy
 MCHQ==
X-Gm-Message-State: APjAAAXvjN6yE+DAiQi93mjW6nOTZSkwrh2AHrloiMY1SQiqYA/pA6jg
 LLHmAqsYF6OJQFyRB8konPSKpkDh
X-Google-Smtp-Source: APXvYqw34yuYCoHsCKhBRyJPiydqDZbT0Th561aWM4I+Mm7ITSj/bXpk+tPq2dXzWEca5oZwyJcEtQ==
X-Received: by 2002:a1c:544b:: with SMTP id p11mr8367934wmi.46.1572428912738; 
 Wed, 30 Oct 2019 02:48:32 -0700 (PDT)
Received: from meru (lfbn-ann-1-367-71.w86-200.abo.wanadoo.fr. [86.200.83.71])
 by smtp.gmail.com with ESMTPSA id
 e24sm1997790wme.26.2019.10.30.02.48.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 30 Oct 2019 02:48:31 -0700 (PDT)
References: <20191029104423.2513c959@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Mathieu Othacehe <m.othacehe@HIDDEN>
To: guix-patches@HIDDEN
Subject: Re: [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable
 python bindings
In-reply-to: <20191029104423.2513c959@HIDDEN>
Date: Wed, 30 Oct 2019 10:48:30 +0100
Message-ID: <87v9s6bm35.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 37979
Cc: 37979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hello,

You can use with-directory-excursion instead of doing:

--8<---------------cut here---------------start------------->8---
(chdir "bindings/python")
...
(chdir "../..")
--8<---------------cut here---------------end--------------->8---

Also the commit title should be:

gnu: lilv: Enable python bindings.

Can you please send a v2 :) ?

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#37979; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Oct 2019 09:48:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 30 05:48:39 2019
Received: from localhost ([127.0.0.1]:49258 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iPkal-0004VL-14
	for submit <at> debbugs.gnu.org; Wed, 30 Oct 2019 05:48:39 -0400
Received: from lists.gnu.org ([209.51.188.17]:43923)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <m.othacehe@HIDDEN>) id 1iPkai-0004VB-GO
 for submit <at> debbugs.gnu.org; Wed, 30 Oct 2019 05:48:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60191)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <m.othacehe@HIDDEN>) id 1iPkah-0002wN-Du
 for guix-patches@HIDDEN; Wed, 30 Oct 2019 05:48:36 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <m.othacehe@HIDDEN>) id 1iPkag-0004cH-Fz
 for guix-patches@HIDDEN; Wed, 30 Oct 2019 05:48:35 -0400
Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:52343)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <m.othacehe@HIDDEN>)
 id 1iPkag-0004YW-9Z
 for guix-patches@HIDDEN; Wed, 30 Oct 2019 05:48:34 -0400
Received: by mail-wm1-x343.google.com with SMTP id p21so1364465wmg.2
 for <guix-patches@HIDDEN>; Wed, 30 Oct 2019 02:48:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=references:user-agent:from:to:cc:subject:in-reply-to:date
 :message-id:mime-version;
 bh=AFGLqkVEyup6xunCCKuGHKeOFs7b6oQQOQJgkFA4mzw=;
 b=PP639d7VBA5j1xkj5RDZC6U8fdmWJIVqfQvKhi70Ou1aQYbQD3EekPazKK0PNFd3wP
 hFpEF9y2pR1F1hl070wu/TURNVYaqm6O5UQMwEUSqpl7zQbXvo9FT3X34DxV9oqdHDDo
 +cmybvkTi5nQGoViZlTAoR/BajJSjBBi6vag8q3vMvnwzKg1OjW4bFmu+U4QR5eiXjCu
 9Hyw3DJPEI9uk15WMo3fql8iHd0Z1egFseiYKXZFtAEYs/r4VP3Qk65TadWpuWRIyk4/
 N10JATwao/t3FMP3jaaMcPlfXxyG6QhuQkj9ultsgF1T8JKYhxyYKBSw/dhP1xmmeB4L
 86hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:references:user-agent:from:to:cc:subject
 :in-reply-to:date:message-id:mime-version;
 bh=AFGLqkVEyup6xunCCKuGHKeOFs7b6oQQOQJgkFA4mzw=;
 b=UR3HPV0FvUAHUaUiX3E++Kjo1M+cheWwpMF2K5X4KGIihOleEiPWf0OmUL56LWTIk2
 ftajgMr9htVPZoN9ywQFUCzQtou/eafMkFGn1gU6PCA2GH7jvn55tZR28NBH8oWDgxYt
 XzadOUsBRjVCiH0SgHXi8sd+ab1nOtX9EGF8aadRdV/NGd793Hx/k0YGYd1KHH/fknnd
 5UCZDxMN/O7UQICCZWdN6Z8gsoUeDciELGKoZYjTxef7/zshuRHjQJfJW3gfDIUKEiGR
 W6cX41Okw4GgaIJiCOppGp7pm8Hp1EQQNbUtOjlQFboMotGlJL6lvVn/BlWjspqUIgIm
 2nrg==
X-Gm-Message-State: APjAAAX6KfanZPmlkEJQiXuO0LJtb6wJqOwY0p1dDeJ4Y5rf5NEQrUhE
 Zux6qMtqHbqiBYjTy2CQDPGw/zGa
X-Google-Smtp-Source: APXvYqw34yuYCoHsCKhBRyJPiydqDZbT0Th561aWM4I+Mm7ITSj/bXpk+tPq2dXzWEca5oZwyJcEtQ==
X-Received: by 2002:a1c:544b:: with SMTP id p11mr8367934wmi.46.1572428912738; 
 Wed, 30 Oct 2019 02:48:32 -0700 (PDT)
Received: from meru (lfbn-ann-1-367-71.w86-200.abo.wanadoo.fr. [86.200.83.71])
 by smtp.gmail.com with ESMTPSA id
 e24sm1997790wme.26.2019.10.30.02.48.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 30 Oct 2019 02:48:31 -0700 (PDT)
References: <20191029104423.2513c959@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Mathieu Othacehe <m.othacehe@HIDDEN>
To: guix-patches@HIDDEN
Subject: Re: [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable
 python bindings
In-reply-to: <20191029104423.2513c959@HIDDEN>
Date: Wed, 30 Oct 2019 10:48:30 +0100
Message-ID: <87v9s6bm35.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2a00:1450:4864:20::343
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: 37979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


Hello,

You can use with-directory-excursion instead of doing:

--8<---------------cut here---------------start------------->8---
(chdir "bindings/python")
...
(chdir "../..")
--8<---------------cut here---------------end--------------->8---

Also the commit title should be:

gnu: lilv: Enable python bindings.

Can you please send a v2 :) ?

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#37979; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 29 Oct 2019 14:38:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 29 10:38:15 2019
Received: from localhost ([127.0.0.1]:48437 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iPSdQ-0002kR-Md
	for submit <at> debbugs.gnu.org; Tue, 29 Oct 2019 10:38:15 -0400
Received: from lists.gnu.org ([209.51.188.17]:60339)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <florian_paul.schmidt@HIDDEN>)
 id 1iPOK2-0001r5-Q4
 for submit <at> debbugs.gnu.org; Tue, 29 Oct 2019 06:01:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53053)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <florian_paul.schmidt@HIDDEN>)
 id 1iPOK1-0001Cz-Be
 for guix-patches@HIDDEN; Tue, 29 Oct 2019 06:01:54 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: **
X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_NONE,
 RECEIVED_FROM_WINDOWS_HOST,URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <florian_paul.schmidt@HIDDEN>)
 id 1iPOJA-0002uu-DX
 for guix-patches@HIDDEN; Tue, 29 Oct 2019 06:01:05 -0400
Received: from uhrz-exch-pmb08.ad.uni-bielefeld.de ([129.70.208.134]:40775
 helo=smtp.uni-bielefeld.de)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <florian_paul.schmidt@HIDDEN>)
 id 1iPOJ6-0002pi-J7
 for guix-patches@HIDDEN; Tue, 29 Oct 2019 06:00:58 -0400
Received: from localhost (129.70.76.171) by
 uhrz-exch-pmb08.ad.uni-bielefeld.de (129.70.208.134) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1847.3; Tue, 29 Oct 2019 10:45:45 +0100
Date: Tue, 29 Oct 2019 10:45:41 +0100
From: Florian Paul Schmidt <florian_paul.schmidt@HIDDEN>
To: <guix-patches@HIDDEN>
Subject: [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
Message-ID: <20191029104423.2513c959@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/rHDZf=HehUlVsbGoxgMpEPL"
X-Originating-IP: [129.70.76.171]
X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy]
X-Received-From: 129.70.208.134
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 29 Oct 2019 10:38:11 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

--MP_/rHDZf=HehUlVsbGoxgMpEPL
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--MP_/rHDZf=HehUlVsbGoxgMpEPL
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="0001-audio.scm-define-public-lilv-enable-python-bindings-.patch"

From 5afa9eac9c34c2e74114f96a6fe746a571b752ee Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <florian_paul.schmidt@HIDDEN>
Date: Tue, 29 Oct 2019 10:34:45 +0100
Subject: [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
 to be built

---
 gnu/packages/audio.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 88f3b5eccd..6438e4e3c6 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1828,6 +1828,7 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
     (build-system waf-build-system)
     (arguments
      `(#:tests? #f                      ; no check target
+       #:configure-flags (list "--bindings")
        #:phases
        (modify-phases %standard-phases
          (add-before
@@ -1836,6 +1837,16 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
             (setenv "LDFLAGS"
                     (string-append "-Wl,-rpath="
                                    (assoc-ref outputs "out") "/lib"))
+            #t))
+         (add-after
+           'unpack 'full-store-path-to-shared-library
+           (lambda* (#:key outputs #:allow-other-keys)
+             (chdir "bindings/python")
+             (substitute*
+                 "lilv.py"
+               (("liblilv-0.so") (string-append (assoc-ref outputs "out")
+                                                "/lib/liblilv-0.so")))
+             (chdir "../../")
             #t)))))
     ;; Required by lilv-0.pc.
     (propagated-inputs
@@ -1844,8 +1855,9 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
        ("sord" ,sord)
        ("sratom" ,sratom)))
     (native-inputs
-     `(("pkg-config" ,pkg-config)))
-    (home-page "https://drobilla.net/software/lilv/")
+     `(("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://drobilla.net/software/lilv")
     (synopsis "Library to simplify use of LV2 plugins in applications")
     (description
      "Lilv is a C library to make the use of LV2 plugins as simple as possible
-- 
2.23.0


--MP_/rHDZf=HehUlVsbGoxgMpEPL--




Acknowledgement sent to Florian Paul Schmidt <florian_paul.schmidt@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#37979; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.