GNU bug report logs - #38014
26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message

Previous Next

Package: emacs;

Reported by: <lin.sun <at> zoom.us>

Date: Fri, 1 Nov 2019 03:14:01 UTC

Severity: normal

Tags: patch

Merged with 38416, 39094

Found in versions 26.3.50, 27.0.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38014 in the body.
You can then email your comments to 38014 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#38014; Package emacs. (Fri, 01 Nov 2019 03:14:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to <lin.sun <at> zoom.us>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 01 Nov 2019 03:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <lin.sun <at> zoom.us>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in
 makefile-move-to-macro to avoid error message
Date: Fri, 1 Nov 2019 10:59:44 +0800

[PATCH] * makefile-edit.el: regexp-quote the param in
makefile-move-to-macro.

Fix the error message from `makefile-move-to-macro' when there is '$'
or '\\' in param for re-search-forward, with `(global-ede-mode t)' and
`(semantic-mode t)'. Enable ede and semantic mode, then open a
Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)'
will trigger this issue.
---
 lisp/cedet/ede/makefile-edit.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/cedet/ede/makefile-edit.el
b/lisp/cedet/ede/makefile-edit.el
index 7d8a44b..add1675 100644
--- a/lisp/cedet/ede/makefile-edit.el
+++ b/lisp/cedet/ede/makefile-edit.el
@@ -78,7 +78,7 @@ makefile-move-to-macro
 If NEXT is non-nil, move to the next occurrence of MACRO."
   (let ((oldpt (point)))
     (when (not next) (goto-char (point-min)))
-    (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)
+    (if (re-search-forward (concat "^\\s-*" (regexp-quote macro)
"\\s-*[+:?]?=") nil t)
        t
       (goto-char oldpt)
       nil)))
--
2.2.0
Merged 38014 38416 39094. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 12 Jan 2020 13:59:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38014; Package emacs. (Sun, 19 Jan 2020 02:32:02 GMT) Full text and rfc822 format available.

Message #10 received at 38014 <at> debbugs.gnu.org (full text, mbox):

From: <lin.sun <at> zoom.us>
To: <38014 <at> debbugs.gnu.org>
Subject: bug#38014: Acknowledgement (26.3.50;
 [PATCH] * makefile-edit.el: regexp-quote the param in
 makefile-move-to-macro to avoid error message)
Date: Sun, 19 Jan 2020 10:31:07 +0800

Close this ticket please. 
The original issue is fixed in #39094, both emacs 27.50 and emacs master.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38014; Package emacs. (Sun, 19 Jan 2020 02:37:01 GMT) Full text and rfc822 format available.

Message #13 received at 38014 <at> debbugs.gnu.org (full text, mbox):

From: <lin.sun <at> zoom.us>
To: <38014 <at> debbugs.gnu.org>
Subject: Recall: bug#38014: Acknowledgement (26.3.50;
 [PATCH] * makefile-edit.el: regexp-quote the param in
 makefile-move-to-macro to avoid error message)
Date: Sun, 19 Jan 2020 10:36:13 +0800

[Message part 1 (text/plain, inline)]
lin.sun <at> zoom.us would like to recall the message, "bug#38014:
Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param
in makefile-move-to-macro to avoid error message)".

[winmail.dat (application/ms-tnef, attachment)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 16 Feb 2020 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 69 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.