GNU bug report logs - #38059
[PATCH 0/3] services: Add pagekite-service-type.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38059 in the body.
You can then email your comments to 38059 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: Add pagekite.
Date: Mon, 04 Nov 2019 14:44:08 +0000

This patch series adds PageKite, an easy way to make TCP servers (like HTTP or SSH) accessible on the internet, even from behind NAT or restrictive firewalls. I'm also working on writing a PageKite service, but it's not done yet and the package is still useful without it.

https://pagekite.net/

-- 
Alex Griffin

Message #8 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38059 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add python-socksipychain.
Date: Mon, 04 Nov 2019 14:47:23 +0000

[Message part 1 (text/plain, inline)]

-- 
Alex Griffin

[0001-gnu-Add-python-socksipychain.patch (text/x-patch, attachment)]

Message #11 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38059 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add pagekite.
Date: Mon, 04 Nov 2019 14:47:48 +0000

[Message part 1 (text/plain, inline)]

-- 
Alex Griffin

[0002-gnu-Add-pagekite.patch (text/x-patch, attachment)]

Message #14 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38059 <at> debbugs.gnu.org
Subject: [PATCH 3/3] services: Add pagekite-service-type
Date: Wed, 06 Nov 2019 17:44:39 +0000

[Message part 1 (text/plain, inline)]

This patch adds a PageKite service, so you can finally run that Guix home server without fiddling with dyndns, firewall rules, and port forwarding!

-- 
Alex Griffin

[0003-services-Add-pagekite-service-type.patch (text/x-patch, attachment)]

Message #19 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38059 <at> debbugs.gnu.org
Subject: [PATCH 3/3] services: Add pagekite-service-type.
Date: Wed, 06 Nov 2019 18:19:43 +0000

[Message part 1 (text/plain, inline)]

This patch fixes a bug where the service wouldn't compile if you omitted `extra-file`, as well as some minor mistakes in the comments and documentation.

-- 
Alex Griffin

[0003-services-Add-pagekite-service-type.patch (text/x-patch, attachment)]

Message #22 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 1/2] gnu: Add python-socksipychain.
Date: Sun, 10 Nov 2019 12:21:15 +0100

Hi Alex,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> From 4b3e2d8a6e5897659ebc06bc809277ee6fc29121 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Sat, 2 Nov 2019 13:43:21 -0500
> Subject: [PATCH 1/2] gnu: Add python-socksipychain.
>
> * gnu/packages/python-xyz.scm (python-socksipychain, python2-socksipychain):
> New variables.

LGTM!  It would be great to avoid the python2 variant (Python 2.x is a
few months away from EOL!), but let’s discuss it in the next patch.

Thanks,
Ludo’.

Message #25 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 2/2] gnu: Add pagekite.
Date: Sun, 10 Nov 2019 12:22:58 +0100

"Alex Griffin" <a <at> ajgrf.com> skribis:

> From 835678c62d341ea4cd8d93f6475ac955198ef276 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Sat, 2 Nov 2019 14:11:51 -0500
> Subject: [PATCH 2/2] gnu: Add pagekite.
>
> * gnu/packages/web.scm (pagekite): New variable.

[...]

> +    (arguments
> +     `(#:python ,python-2

Can it work with Python 3.x?  It would be really great.  Perhaps there
are not-yet-upstreamed patches floating around for that?

> +    (synopsis "Make localhost servers publicly visible")
> +    (description
> +     "PageKite implements a tunneled reverse proxy which makes it easy to make
> +a service (such as an HTTP or SSH server) on localhost visible to the wider
> +Internet, even behind NAT or restrictive firewalls.  A managed front-end relay
> +service is available at https://pagekite.net/, or you can run your own.")
                           ^
Use @url here.

Thanks,
Ludo’.

Message #28 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 3/3] services: Add pagekite-service-type.
Date: Sun, 10 Nov 2019 12:31:30 +0100

Hi,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> From 46a5e48f5e89be4da3611bd11b55ed0e325c6538 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Mon, 4 Nov 2019 19:29:24 -0600
> Subject: [PATCH 3/3] services: Add pagekite-service-type.
>
> * gnu/services/networking.scm (pagekite-service-type): New service type.
> (<pagekite-configuration>): New record type.
> (pagekite-shepherd-service): New procedure.
> * doc/guix.texi (Networking Services): Document it.

[...]

> +(define pagekite-configuration-file
> +  (match-lambda
> +    (($ <pagekite-configuration> package kitename kitesecret
> +                                 frontend kites extra-file)

[...]

> +(define (pagekite-shepherd-service config)
> +  (match config
> +    (($ <pagekite-configuration> package kitename kitesecret
> +                                 frontend kites extra-file)

I recommend using ‘match-record’ in these two cases since it matches
fields by name and is thus less error-prone.

> +        (start #~(make-forkexec-constructor/container

Nice.  :-)

Is there some meaningful test that could be written for this service?  I
suppose it’d be hard to test without also running a relay.  Anyway, if
you can think of a non-trivial test that could detect regressions,
you’re welcome to add it to (gnu tests …).

Otherwise LGTM!

Thanks,
Ludo’.

Message #31 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 2/2] gnu: Add pagekite.
Date: Mon, 11 Nov 2019 01:05:18 +0000

On Sun, Nov 10, 2019, at 11:22 AM, Ludovic Courtès wrote:
> "Alex Griffin" <a <at> ajgrf.com> skribis:
> > +    (arguments
> > +     `(#:python ,python-2
> 
> Can it work with Python 3.x?  It would be really great.  Perhaps there
> are not-yet-upstreamed patches floating around for that?

There are indeed some [WIP patches][1], but I couldn't get them working. I think it's likely that PageKite will get Python 3 support before Python 2 is EOL. There's a discussion [here][2] with maintainers from both Fedora and Debian expressing concern. At the moment, though, I don't think I can package it with Python 3 unless I finish porting it myself.

[1]: https://github.com/pagekite/PyPagekite/pull/71
[2]: https://github.com/pagekite/PyPagekite/issues/40

-- 
Alex Griffin

Message #34 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 3/3] services: Add pagekite-service-type.
Date: Mon, 11 Nov 2019 01:11:07 +0000

On Sun, Nov 10, 2019, at 11:31 AM, Ludovic Courtès wrote:
> Is there some meaningful test that could be written for this service?  I
> suppose it’d be hard to test without also running a relay.  Anyway, if
> you can think of a non-trivial test that could detect regressions,
> you’re welcome to add it to (gnu tests …).
> 
> Otherwise LGTM!

It might be possible to run both the frontend and backend on localhost and test it that way. The service currently only supports running as a backend, though. Let me know what you think.

Thanks,
-- 
Alex Griffin

Message #37 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 2/2] gnu: Add pagekite.
Date: Mon, 11 Nov 2019 15:02:32 +0100

Hi Alex,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> On Sun, Nov 10, 2019, at 11:22 AM, Ludovic Courtès wrote:
>> "Alex Griffin" <a <at> ajgrf.com> skribis:
>> > +    (arguments
>> > +     `(#:python ,python-2
>> 
>> Can it work with Python 3.x?  It would be really great.  Perhaps there
>> are not-yet-upstreamed patches floating around for that?
>
> There are indeed some [WIP patches][1], but I couldn't get them working. I think it's likely that PageKite will get Python 3 support before Python 2 is EOL. There's a discussion [here][2] with maintainers from both Fedora and Debian expressing concern. At the moment, though, I don't think I can package it with Python 3 unless I finish porting it myself.
>
> [1]: https://github.com/pagekite/PyPagekite/pull/71
> [2]: https://github.com/pagekite/PyPagekite/issues/40

OK, sounds good.  Perhaps just add a comment referring to these two URLs
for future reference, and we’ll leave at that for now.

Thank you,
Ludo’.

Message #40 received at 38059 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38059 <at> debbugs.gnu.org
Subject: Re: [bug#38059] [PATCH 3/3] services: Add pagekite-service-type.
Date: Mon, 11 Nov 2019 15:04:41 +0100

"Alex Griffin" <a <at> ajgrf.com> skribis:

> On Sun, Nov 10, 2019, at 11:31 AM, Ludovic Courtès wrote:
>> Is there some meaningful test that could be written for this service?  I
>> suppose it’d be hard to test without also running a relay.  Anyway, if
>> you can think of a non-trivial test that could detect regressions,
>> you’re welcome to add it to (gnu tests …).
>> 
>> Otherwise LGTM!
>
> It might be possible to run both the frontend and backend on localhost and test it that way. The service currently only supports running as a backend, though. Let me know what you think.

Then I think you can push it as-is, with an eye on implementing the
missing bits later.  :-)

The goal is to ensure we ship services that actually work, and to make
it easy to test for regressions when we upgrade the package or modify
the service.

Thanks!

Ludo’.

Message #45 received at 38059-done <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38059-done <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#38059] [PATCH 3/3] services: Add pagekite-service-type.
Date: Mon, 11 Nov 2019 20:18:56 +0000

On Mon, Nov 11, 2019, at 2:04 PM, Ludovic Courtès wrote:
> Then I think you can push it as-is, with an eye on implementing the
> missing bits later.  :-)
> 
> The goal is to ensure we ship services that actually work, and to make
> it easy to test for regressions when we upgrade the package or modify
> the service.

Pushed as a2161c861f! I'll keep an eye on the status of Python 3 support see if I can't extend the service and tests when I have time.

-- 
Alex Griffin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.