GNU bug report logs - #38097
Add gnome-xyz for themes and shell extensions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38097 in the body.
You can then email your comments to 38097 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: Add gnome-xyz for themes and shell extensions
Date: Thu, 07 Nov 2019 10:46:14 +0100

[Message part 1 (text/plain, inline)]

This patch series adds (gnu packages gnome-xyz) for GNOME themes[1] and
extensions[2].  I've initialized it with some packages that I
personally use.  Another potential candidate for inclusion into this
file would for instance be the Matcha GTK theme (bug#38095).

I'm not 100% sure on the licenses.  In some places, I only found
LICENSE files without a comment specifying "or later" elsewhere --
perhaps I've overlooked some.  For now, I'm using the stricter versions
(sans "+").

[1] https://www.gnome-look.org/
[2] https://extensions.gnome.org/

[0001-gnu-Add-delft-icon-theme.patch (text/x-patch, attachment)]

[0002-gnu-add-gnome-shell-extension-dash-to-dock.patch (text/x-patch, attachment)]

[0003-gnu-add-gnome-shell-extension-noannoyance.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 38097 <at> debbugs.gnu.org
Subject: Re: [bug#38097] Add gnome-xyz for themes and shell extensions
Date: Thu, 07 Nov 2019 12:36:14 +0100

Hello,

Overall this looks fine, thanks. The indentation of the first patch is
wrong. Also you have several lines hitting the 78 columns limit. You
need to wrap them manually.

I'm ok with the introduction of (gnu packages gnome-xyz) and using it
for Matcha theme.

Can you please send an updated version?

Thanks,

Mathieu

> This patch series adds (gnu packages gnome-xyz) for GNOME themes[1] and
> extensions[2].  I've initialized it with some packages that I
> personally use.  Another potential candidate for inclusion into this
> file would for instance be the Matcha GTK theme (bug#38095).
>
> I'm not 100% sure on the licenses.  In some places, I only found
> LICENSE files without a comment specifying "or later" elsewhere --
> perhaps I've overlooked some.  For now, I'm using the stricter versions
> (sans "+").
>
> [1] https://www.gnome-look.org/
> [2] https://extensions.gnome.org/

Message #14 received at 38097 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: m.othacehe <at> gmail.com
Cc: 38097 <at> debbugs.gnu.org
Subject: [bug#38097] Add gnome-xyz for themes and shell extensions
Date: Thu, 07 Nov 2019 19:34:23 +0100

[Message part 1 (text/plain, inline)]

> Overall this looks fine, thanks. The indentation of the first patch
> is
> wrong. Also you have several lines hitting the 78 columns limit. You
> need to wrap them manually.
Forgetting to hit TAB, my old nemesis.  I assume this limit counts for
ChangeLog entries too, does it?

> Can you please send an updated version?
Of course.  I've reformatted all three of them and added them again
here as attachments.  I also ran `guix lint` this time with the
formatting checks enabled, as I should have before sending the first
one :)

Regards,

Leo

[0001-gnu-Add-delft-icon-theme.patch (text/x-patch, attachment)]

[0002-gnu-add-gnome-shell-extension-dash-to-dock.patch (text/x-patch, attachment)]

[0003-gnu-add-gnome-shell-extension-noannoyance.patch (text/x-patch, attachment)]

Message #19 received at 38097-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 38097-done <at> debbugs.gnu.org
Subject: Re: [bug#38097] Add gnome-xyz for themes and shell extensions
Date: Fri, 08 Nov 2019 22:36:19 +0100

Hello,

> Forgetting to hit TAB, my old nemesis.  I assume this limit counts for
> ChangeLog entries too, does it?

Yes it counts, but using magit your lines are automatically wrapped :)

>> Can you please send an updated version?
> Of course.  I've reformatted all three of them and added them again
> here as attachments.  I also ran `guix lint` this time with the
> formatting checks enabled, as I should have before sending the first
> one :)

I edited the commit titles a bit before pushing.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.