GNU bug report logs - #38103
Dracula emacs theme

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38103 in the body.
You can then email your comments to 38103 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: bluekeys <bluekeys <at> bluekeys.eu>
To: guix-patches <at> gnu.org
Subject: Dracula emacs theme
Date: Thu, 07 Nov 2019 14:13:43 +0000

Hi,

The attached patch adds the dracula emacs theme to emacs-xyz.scm
My first patch to free software.

Feedback welcome!

<#part type="text/x-patch" filename="~/src/guix/0001-Create-emacs-dracula-theme-module.patch" disposition=inline description="emacs-dracula-theme patch">
<#/part>

David

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 38103 <at> debbugs.gnu.org
Subject: Re: [bug#38103] Dracula emacs theme
Date: Thu, 07 Nov 2019 16:55:54 +0100

Hello!

> The attached patch adds the dracula emacs theme to emacs-xyz.scm
> My first patch to free software.

Welcome! And thanks for this first contribution :)

Regarding the patch, I think you have a problem with your mailer, I can
only see:

> < #part type="text/x-patch" filename="~/src/guix/0001-Create-emacs-dracula-theme-module.patch" disposition=inline description="emacs-dracula-theme patch">
> < #/part>

and not the patch itself.

Mathieu

Message #14 received at 38103 <at> debbugs.gnu.org (full text, mbox):

From: bluekeys <at> bluekeys.eu
To: 38103 <at> debbugs.gnu.org 
Subject: Re: [bug#38103] Dracula emacs theme
Date: Sat, 09 Nov 2019 16:29:13 +0000

[Message part 1 (text/plain, inline)]

Hi,

Second attempt to attach the patch. 

[0001-Create-emacs-dracula-theme-module.patch (text/x-patch, attachment)]

Message #17 received at 38103 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: bluekeys <at> bluekeys.eu, 38103 <at> debbugs.gnu.org
Subject: Re: [bug#38103] Dracula emacs theme
Date: Sun, 10 Nov 2019 21:14:09 +0100

[Message part 1 (text/plain, inline)]

bluekeys <at> bluekeys.eu writes:

> Hi,
>
> Second attempt to attach the patch. 

Looks good!

[...]
  
> +(define-public emacs-dracula-theme
> +  (package
> +    (name "emacs-dracula-theme")
> +    (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/dracula/emacs.git")
> +             (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))

Could add a (let (commit ...)) binding for the commit hash so we don't
have to repeat it twice?  See the surrounding packages for examples.

Please also add a 'file-name' field here.

> +       (sha256
> +        (base32
> +         "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://draculatheme.com/emacs")
> +    (synopsis "A dark theme for emacs")

Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.

> +    (description
> +     "A dark theme for emacs and 50+ apps")

Can you expand a bit on the "50+ apps" part?  Perhaps something along
the lines of "Dracula is a dark color theme implemented for more than 50
different applications.  This package provides the Emacs theme."

Can you send an updated patch?  Thanks, and welcome!  :-)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 38103 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: bluekeys <at> bluekeys.eu, 38103 <at> debbugs.gnu.org
Subject: Re: [bug#38103] Dracula emacs theme
Date: Mon, 09 Dec 2019 22:50:17 -0600

Marius Bakke <mbakke <at> fastmail.com> writes:

> bluekeys <at> bluekeys.eu writes:
>
>> Hi,
>>
>> Second attempt to attach the patch. 
>
> Looks good!
>
> [...]
>   
>> +(define-public emacs-dracula-theme
>> +  (package
>> +    (name "emacs-dracula-theme")
>> +    (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/dracula/emacs.git")
>> +             (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))
>
> Could add a (let (commit ...)) binding for the commit hash so we don't
> have to repeat it twice?  See the surrounding packages for examples.
>
> Please also add a 'file-name' field here.
>
>> +       (sha256
>> +        (base32
>> +         "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://draculatheme.com/emacs")
>> +    (synopsis "A dark theme for emacs")
>
> Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.
>
>> +    (description
>> +     "A dark theme for emacs and 50+ apps")
>
> Can you expand a bit on the "50+ apps" part?  Perhaps something along
> the lines of "Dracula is a dark color theme implemented for more than 50
> different applications.  This package provides the Emacs theme."
>
> Can you send an updated patch?  Thanks, and welcome!  :-)
>

Hi Marius and bluekeys!

I just wanted to bump this so we can get it pushed. If you would like
some help, bluekeys please do not hesitate to ask us either here or on
the #guix Freenode IRC.

Also, when you send your revised patch do include yourself in the
copyright section of the header! You deserve that designation for your
contribution.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

Message #25 received at 38103-close <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: 38103-close <at> debbugs.gnu.org
Subject: Re: [bug#38103] Dracula emacs theme
Date: Tue, 02 Jun 2020 07:19:42 +0200

[Message part 1 (text/plain, inline)]

close 38103

this has been added recently.
-- 
Lady Nancy Astor: "Winston, if you were my husband, I'd put poison in your coffee."
Winston Churchill: "Nancy, if you were my wife, I'd drink it."

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.