GNU bug report logs - #38115
[PATCH] gnu: Add dpf-plugins.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38115 in the body.
You can then email your comments to 38115 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add dpf-plugins.
Date: Fri, 08 Nov 2019 09:58:08 +0100

From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 08:55:22 +0000
Subject: [PATCH] gnu: Add dpf-plugins.

* gnu/packages/music.scm: (dpf-plugins): New variable.
---
 gnu/packages/music.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..e78b01d4a3 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4699,3 +4700,49 @@ You can also get metadata about the playing track 
such as the artist and title
 for integration into status line generators or other command-line 
tools.")
     (home-page "https://github.com/altdesktop/playerctl")
     (license license:lgpl3+)))
+
+(define-public dpf-plugins
+  (package
+    (name "dpf-plugins")
+    (version "1.3")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/DISTRHO/DPF-Plugins.git")
+            (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0a89hiqflg8y55aphiff64g9jli88lxzwzw4grfk48n7r1mp49hf"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'skip-dssi-binaries
+           (lambda _
+             (substitute* "Makefile"
+                          (("cp -r bin.*-dssi.*$") ":;\n"))
+             #t))
+         (add-before 'build 'set-CC-variable
+           (lambda _ (setenv "CC" "gcc") #t))
+             (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("dssi" ,dssi)
+       ("mesa" ,mesa)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2" ,lv2)))
+    (home-page "https://github.com/DISTRHO/DPF-Plugins")
+    (synopsis "Audio plugin collection")
+    (description "Collection of DPF-based audio plugins in LADSPA, 
DSSI, LV2 and VST2
+formats. This package includes the following plugins: glBars, Kars, 
Max-Gen examples
+(MaBitcrush, MaFreeverb, MaGigaverb, MaPitchshift), Mini-Series 
(3BandEQ. 3BandSplitter,
+PingPongPan), ndc-Plugs (Amplitude Imposer, Cycle Shifter, Soul Force), 
MVerb, Nekobi,
+and ProM.")
+    (license `(license:isc license:gpl3 license:lgpl3 license:mit 
license:gpl2))))
-- 
2.24.0

Message #8 received at 38115 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38115 <at> debbugs.gnu.org
Subject: Re: [bug#38115] [PATCH] gnu: Add dpf-plugins.
Date: Sun, 10 Nov 2019 23:45:54 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

>  From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 08:55:22 +0000
> Subject: [PATCH] gnu: Add dpf-plugins.
>
> * gnu/packages/music.scm: (dpf-plugins): New variable.

[...]

> +    (arguments
> +     `(#:tests? #f  ; no "check" target
> +       #:make-flags
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'skip-dssi-binaries
> +           (lambda _
> +             (substitute* "Makefile"
> +                          (("cp -r bin.*-dssi.*$") ":;\n"))
> +             #t))

Can you expand on this comment?  What are these binaries, and why do we
need to prevent them from being installed?

> +    (license `(license:isc license:gpl3 license:lgpl3 license:mit 
> license:gpl2))))

Does this work?  I would expect each of the license entries to have to
be 'unquoted', i.e. `(,license:isc).  Alternatively you can use (list
...) here.

When a package has multiple licenses like here, please add a comment
about it.  Is there a "main" license, (roughly) which files are under
what license?

Apart from that LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38115 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38115 <at> debbugs.gnu.org
Subject: Re: [bug#38115] [PATCH] gnu: Add dpf-plugins.
Date: Mon, 11 Nov 2019 04:48:51 +0000

[Message part 1 (text/plain, inline)]

> > +    (arguments
> > +     `(#:tests? #f  ; no "check" target
> > +       #:make-flags
> > +       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'skip-dssi-binaries
> > +           (lambda _
> > +             (substitute* "Makefile"
> > +                          (("cp -r bin.*-dssi.*$") ":;\n"))
> > +             #t))
> 
> Can you expand on this comment?  What are these binaries, and why do
> we
> need to prevent them from being installed?
I was having trouble building them, but I managed to get them building
now (was missing liblo). Removed this part

> 
> > +    (license `(license:isc license:gpl3 license:lgpl3 license:mit 
> > license:gpl2))))
> 
> Does this work?  I would expect each of the license entries to have
> to
> be 'unquoted', i.e. `(,license:isc).  Alternatively you can use (list
> ...) here.
> 
> When a package has multiple licenses like here, please add a comment
> about it.  Is there a "main" license, (roughly) which files are under
> what license?
Fixed and added more info

[0001-gnu-Add-dpf-plugins.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38115-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38115-done <at> debbugs.gnu.org
Subject: Re: [bug#38115] [PATCH] gnu: Add dpf-plugins.
Date: Wed, 13 Nov 2019 23:30:31 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> From 065b91fd765d8df510bcf969c9f41ae792733632 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 08:55:22 +0000
> Subject: [PATCH] gnu: Add dpf-plugins.
>
> * gnu/packages/music.scm: (dpf-plugins): New variable.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.