GNU bug report logs - #38117
[PATCH] gnu: Add helm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38117 in the body.
You can then email your comments to 38117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add helm.
Date: Fri, 08 Nov 2019 10:30:48 +0100

From 3f496aa17eeb192ba363327e6cfd6fe0be533a56 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:25:08 +0000
Subject: [PATCH] gnu: Add helm.

* gnu/packages/music.scm: (helm): New variable.
---
 gnu/packages/music.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..cf883d034f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4699,3 +4700,56 @@ You can also get metadata about the playing track 
such as the artist and title
 for integration into status line generators or other command-line 
tools.")
     (home-page "https://github.com/altdesktop/playerctl")
     (license license:lgpl3+)))
+
+(define-public helm
+  (package
+    (name "helm")
+    (version "0.9.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/mtytel/helm.git")
+            (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "17ys2vvhncx9i3ydg3xwgz1d3gqv4yr5mqi7vr0i0ca6nad6x3d4"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+             "lv2" "standalone")
+       #:phases
+       (modify-phases
+        %standard-phases
+        (add-after 'unpack 
'include-pnglib-code-and-remove-usr-from-paths
+           (lambda _
+             (substitute* "standalone/builds/linux/Makefile"
+                          (("JUCE_INCLUDE_PNGLIB_CODE=0")
+                           "JUCE_INCLUDE_PNGLIB_CODE=1"))
+             (substitute* "builds/linux/LV2/Makefile"
+                          (("JUCE_INCLUDE_PNGLIB_CODE=0")
+                           "JUCE_INCLUDE_PNGLIB_CODE=1"))
+             (substitute* "Makefile" (("/usr") ""))
+             #t))
+        (delete 'configure))))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("curl" ,curl)
+       ("freetype2" ,freetype)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("libxcursor" ,libxcursor)
+       ("libxinerama", libxinerama)
+       ("jack", jack-1)
+       ("mesa" ,mesa)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2", lv2)))
+    (home-page "https://tytel.org/helm/")
+    (synopsis "Polyphonic synth with lots of modulation")
+    (description "Helm is a cross-platform polyphonic synthesizer 
available standalone
+and as an LV2 plugin.")
+    (license license:gpl3+)))
-- 
2.24.0

Message #8 received at 38117 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38117 <at> debbugs.gnu.org
Subject: Re: [bug#38117] [PATCH] gnu: Add helm.
Date: Sun, 10 Nov 2019 23:29:40 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

>  From 3f496aa17eeb192ba363327e6cfd6fe0be533a56 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:25:08 +0000
> Subject: [PATCH] gnu: Add helm.
>
> * gnu/packages/music.scm: (helm): New variable.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38117 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38117 <at> debbugs.gnu.org
Subject: Re: [bug#38117] [PATCH] gnu: Add helm.
Date: Mon, 18 Nov 2019 12:16:24 +0100

Hello,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From 3f496aa17eeb192ba363327e6cfd6fe0be533a56 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:25:08 +0000
> Subject: [PATCH] gnu: Add helm.
>
> * gnu/packages/music.scm: (helm): New variable.

I applied it but it fails for me at the end:

--8<---------------cut here---------------start------------->8---
starting phase `reset-gzip-timestamps'
Backtrace:
           9 (primitive-load "/gnu/store/qaparaqbwqw4v0hwfd50s37mikz…")
In ice-9/eval.scm:
   191:35  8 (_ _)
In ice-9/boot-9.scm:
    829:9  7 (catch _ _ #<procedure 7ffff5bc0518 at /gnu/store/w3jl…> …)
In srfi/srfi-1.scm:
   863:16  6 (every1 #<procedure 7ffff4c111e0 at /gnu/store/w3jlc8p…> …)
In /gnu/store/w3jlc8pk8416m7h677r5vq92b66h8cqd-module-import/guix/build/gnu-build-system.scm:
   839:30  5 (_ _)
    594:5  4 (reset-gzip-timestamps #:outputs _)
In srfi/srfi-1.scm:
    640:9  3 (for-each #<procedure process-directory (directory)> (#))
    640:9  2 (for-each #<procedure reset-gzip-timestamp (file #:key…> …)
In /gnu/store/w3jlc8pk8416m7h677r5vq92b66h8cqd-module-import/guix/build/utils.scm:
   262:14  1 (reset-gzip-timestamp "/gnu/store/04j1kvzkx8n5ldbcbckh…" …)
In unknown file:
           0 (open "/gnu/store/04j1kvzkx8n5ldbcbckhcmbw4n3vzrwz-hel…" …)

ERROR: In procedure open:
In procedure open-fdes: Permission denied
builder for `/gnu/store/xj20qjw2mgp2yc59hmafmkgg780n1ci7-helm-0.9.0.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

Could you take a look?

As an aside, the patch had been mangled on its way.  Could you send it
as an attachment or with ‘git send-email’ next time?

Thank you!

Ludo’.

Message #16 received at 38117 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38117 <at> debbugs.gnu.org
Subject: Re: [bug#38117] [PATCH] gnu: Add helm.
Date: Tue, 26 Nov 2019 04:43:42 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo,

> I applied it but it fails for me at the end:
> 
> --8<---------------cut here---------------start------------->8---
> starting phase `reset-gzip-timestamps'
> Backtrace:
>            9 (primitive-load
> "/gnu/store/qaparaqbwqw4v0hwfd50s37mikz…")
> In ice-9/eval.scm:
>    191:35  8 (_ _)
> In ice-9/boot-9.scm:
>     829:9  7 (catch _ _ #<procedure 7ffff5bc0518 at /gnu/store/w3jl…>
> …)
> In srfi/srfi-1.scm:
>    863:16  6 (every1 #<procedure 7ffff4c111e0 at /gnu/store/w3jlc8p…>
> …)
> In /gnu/store/w3jlc8pk8416m7h677r5vq92b66h8cqd-module-
> import/guix/build/gnu-build-system.scm:
>    839:30  5 (_ _)
>     594:5  4 (reset-gzip-timestamps #:outputs _)
> In srfi/srfi-1.scm:
>     640:9  3 (for-each #<procedure process-directory (directory)>
> (#))
>     640:9  2 (for-each #<procedure reset-gzip-timestamp (file #:key…>
> …)
> In /gnu/store/w3jlc8pk8416m7h677r5vq92b66h8cqd-module-
> import/guix/build/utils.scm:
>    262:14  1 (reset-gzip-timestamp "/gnu/store/04j1kvzkx8n5ldbcbckh…"
> …)
> In unknown file:
>            0 (open "/gnu/store/04j1kvzkx8n5ldbcbckhcmbw4n3vzrwz-hel…" 
> …)
> 
> ERROR: In procedure open:
> In procedure open-fdes: Permission denied
> builder for `/gnu/store/xj20qjw2mgp2yc59hmafmkgg780n1ci7-helm-
> 0.9.0.drv' failed with exit code 1
> --8<---------------cut here---------------end--------------->8---
> 
> Could you take a look?

Weird, it used to work (I even installed it and used the plugin!) but
now I get this too. I would debug it but I have no idea what the error
means or what to look for, the project seems to get built ok (I can see
the generated LV2/VST plugins in the build directory).

> As an aside, the patch had been mangled on its way.  Could you send
> it
> as an attachment or with ‘git send-email’ next time?

Reattaching it as a patch, hopefully someone with more experience can
take it from here.

Alex

[0001-gnu-Add-helm.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #21 received at 38117-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38117-done <at> debbugs.gnu.org
Subject: Re: [bug#38117] [PATCH] gnu: Add helm.
Date: Tue, 26 Nov 2019 11:14:44 +0100

Hello,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> Weird, it used to work (I even installed it and used the plugin!) but
> now I get this too. I would debug it but I have no idea what the error
> means or what to look for, the project seems to get built ok (I can see
> the generated LV2/VST plugins in the build directory).

The ‘changelog.gz’ file and man pages were read-only.  I added a phase
like this:

         (add-before 'reset-gzip-timestamps 'make-gz-files-writable
           (lambda* (#:key outputs #:allow-other-keys)
             (for-each make-file-writable
                       (find-files (string-append (assoc-ref outputs "out"))
                                   ".*\\.gz$"))
             #t))

Now it’s all right!  I will push shortly.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.