GNU bug report logs -
#38118
[PATCH] gnu: Add avldrums-lv2.
Previous Next
Reported by: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:39:02 UTC
Severity: normal
Tags: patch
Done: Marius Bakke <mbakke <at> fastmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38118 in the body.
You can then email your comments to 38118 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#38118
; Package
guix-patches
.
(Fri, 08 Nov 2019 09:39:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Alexandros Theodotou <alex <at> zrythm.org>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Fri, 08 Nov 2019 09:39:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From aae805260db2b830a35459ae219c780e6619cc14 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:35:38 +0000
Subject: [PATCH] gnu: Add avldrums-lv2.
* gnu/packages/music.scm: (avldrums-lv2): New variable.
---
gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..38d30c5438 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -4699,3 +4700,45 @@ You can also get metadata about the playing track
such as the artist and title
for integration into status line generators or other command-line
tools.")
(home-page "https://github.com/altdesktop/playerctl")
(license license:lgpl3+)))
+
+(define-public avldrums-lv2
+ (package
+ (name "avldrums-lv2")
+ (version "0.4.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/x42/avldrums.lv2.git")
+ (commit (string-append "v" version))
+ (recursive? #t))) ; for the 'robtk' submodule
+ (file-name (string-append name "-v" version))
+ (sha256
+ (base32
+ "1z70rcq6z3gkb4fm8dm9hs31bslwr97zdh2n012fzki9b9rdj5qv"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no "check" target
+ #:make-flags
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'set-CC-variable
+ (lambda _ (setenv "CC" "gcc") #t))
+ (delete 'configure))))
+ (inputs
+ `(("cairo" ,cairo)
+ ("dssi" ,dssi)
+ ("glu" ,glu)
+ ("mesa" ,mesa)
+ ("pango" ,pango)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("lv2" ,lv2)))
+ (home-page "http://x42-plugins.com/x42/x42-avldrums")
+ (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux
Drumkits")
+ (description "avldrums.lv2 is a drum sample player LV2 plugin
dedicated to Glen MacArthur's
+AVLdrums. This plugin provides a convenient way to sequence and mix
MIDI drums and
+comes as two separate drumkits: Black Pearl and Red Zeppelin.")
+ (license license:gpl2+)))
--
2.24.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#38118
; Package
guix-patches
.
(Sun, 10 Nov 2019 22:28:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 38118 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:
> From aae805260db2b830a35459ae219c780e6619cc14 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:35:38 +0000
> Subject: [PATCH] gnu: Add avldrums-lv2.
>
> * gnu/packages/music.scm: (avldrums-lv2): New variable.
[...]
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/x42/avldrums.lv2.git")
> + (commit (string-append "v" version))
> + (recursive? #t))) ; for the 'robtk' submodule
Can we package robtk separately?
> + (home-page "http://x42-plugins.com/x42/x42-avldrums")
HTTPS ^
> + (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux
> Drumkits")
> + (description "avldrums.lv2 is a drum sample player LV2 plugin
> dedicated to Glen MacArthur's
> +AVLdrums. This plugin provides a convenient way to sequence and mix
> MIDI drums and
> +comes as two separate drumkits: Black Pearl and Red Zeppelin.")
Make sure to run 'guix lint' before resending these patches, to catch
infraction issues :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#38118
; Package
guix-patches
.
(Mon, 11 Nov 2019 04:08:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 38118 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Marius,
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri
> > + (git-reference
> > + (url "https://github.com/x42/avldrums.lv2.git")
> > + (commit (string-append "v" version))
> > + (recursive? #t))) ; for the 'robtk' submodule
>
> Can we package robtk separately?
The author expects it to be included in the plugin's sources, much like
DPF (DISTRHO plugin framework) based plugins. I don't know if it is
possible to package it, or at least if any of the plugins using it can
build with a packaged version without modifications. The Redkite
toolkit is a bit better because it outputs a .a library that you can
statically link with instead of having to include its sources, so that
was easy to package.
By the way, Arch does the same thing for this package. I believe Debian
too, but not 100% sure about Debian.
> Make sure to run 'guix lint' before resending these patches, to catch
> infraction issues :-)
Done, thank you!
[0001-gnu-Add-avldrums-lv2.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#38118
; Package
guix-patches
.
(Mon, 11 Nov 2019 05:16:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 38118 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Oops, copy-paste fail. Added 2 spaces between sentences.
[0001-gnu-Add-avldrums-lv2.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Marius Bakke <mbakke <at> fastmail.com>
:
You have taken responsibility.
(Wed, 13 Nov 2019 22:34:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Alexandros Theodotou <alex <at> zrythm.org>
:
bug acknowledged by developer.
(Wed, 13 Nov 2019 22:34:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 38118-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:
> From e6d30dd87ae46bfba50de7a0e549a13a0368dfcc Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:35:38 +0000
> Subject: [PATCH] gnu: Add avldrums-lv2.
>
> * gnu/packages/music.scm: (avldrums-lv2): New variable.
Thanks! Applied with indentation fixes like the other patches. This is
the last review I had time for today.
In the future, when sending many related patches at once, please send as
a "patch series" (commits on top of each other) instead of individual
patches all branching out from the same commit.
The reason is that applying the first patch to music.scm broke the other
patches for music.scm, because the context became different. I managed
to work around it with a workflow involving
`git am --show-current-patch | git apply`, but it would be better if all
applied cleanly when committed in order. :-)
Anyway, impressive first series of patches! I look forward to the next
one. ;-)
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 12 Dec 2019 12:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 142 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.