GNU bug report logs - #38119
[PATCH] gnu: Add redkite.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38119 in the body.
You can then email your comments to 38119 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add redkite.
Date: Fri, 08 Nov 2019 10:58:12 +0100

Adding this to audio because it's a GUI toolkit for audio plugins.

From 2991c39c555873b8bed3db3139ce6d35bb156a8e Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:47:25 +0000
Subject: [PATCH] gnu: Add redkite.

* gnu/packages/audio.scm: (redkite): New variable.
---
 gnu/packages/audio.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..e13833bf23 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3773,3 +3774,30 @@ other Gnaural instances, allowing synchronous 
sessions between many users.")
 a sound card, encodes it into Ogg Vorbis and/or mp3, and sends the 
audio
 stream to one or more IceCast and/or ShoutCast servers.")
     (license license:gpl3+)))
+
+(define-public redkite
+  (package
+    (name "redkite")
+    (version "0.6.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+          (string-append "https://gitlab.com/iurie/redkite/-/archive/v"
+                         version "/redkite-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0qif1x3s96zi81zkg11zkszf2i5mvfyrg9b3z2lr0jpzihgblk7y"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ; no tests included
+    (inputs
+     `(("cairo" ,cairo)
+       ("glibc" ,glibc)))
+    (native-inputs
+     `(("pkg-config", pkg-config)))
+    (synopsis "Small GUI toolkit")
+    (description "Redkite is a small GUI toolkit developed in C++17 and
+inspired from other well known GUI toolkits.")
+    (home-page "https://gitlab.com/iurie/redkite")
+    (license license:gpl3+)))
-- 
2.24.0

Message #8 received at 38119 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38119 <at> debbugs.gnu.org
Subject: Re: [bug#38119] [PATCH] gnu: Add redkite.
Date: Sun, 10 Nov 2019 23:23:45 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Adding this to audio because it's a GUI toolkit for audio plugins.
>
>  From 2991c39c555873b8bed3db3139ce6d35bb156a8e Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:47:25 +0000
> Subject: [PATCH] gnu: Add redkite.
>
> * gnu/packages/audio.scm: (redkite): New variable.

Thanks!

[...]

> +        (uri
> +          (string-append "https://gitlab.com/iurie/redkite/-/archive/v"
> +                         version "/redkite-v" version ".tar.gz"))

This can be condensed to two lines.

> +    (native-inputs
> +     `(("pkg-config", pkg-config)))
> +    (synopsis "Small GUI toolkit")
> +    (description "Redkite is a small GUI toolkit developed in C++17 and
> +inspired from other well known GUI toolkits.")

Can you expand on this description a bit?  What makes it different from
(or similar to) other GUI toolkits?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38119 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38119 <at> debbugs.gnu.org
Subject: Re: [bug#38119] [PATCH] gnu: Add redkite.
Date: Mon, 11 Nov 2019 03:26:25 +0000

[Message part 1 (text/plain, inline)]

Marius,

Thanks for the reviews! Updated.

The new description feels a bit too formal - the upstream descriptions
were too short so I had to come up with something. Feel free to edit
it.

[0001-gnu-Add-redkite.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38119-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38119-done <at> debbugs.gnu.org
Subject: Re: [bug#38119] [PATCH] gnu: Add redkite.
Date: Wed, 13 Nov 2019 23:27:54 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Marius,
>
> Thanks for the reviews! Updated.
>
> The new description feels a bit too formal - the upstream descriptions
> were too short so I had to come up with something. Feel free to edit
> it.

Looks good to me!  We can always adjust it later.

On a related note, it feels weird to have a GUI toolkit in audio.scm,
but I could not think of a better place for it.  Suggestions welcome.

> From f50684e58e8b4c6f8bc105dd9f0650fcb366b875 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:47:25 +0000
> Subject: [PATCH] gnu: Add redkite.
>
> * gnu/packages/audio.scm: (redkite): New variable.

Applied, thanks!

[...]

> +    (home-page "https://gitlab.com/iurie/redkite")

The URL redirects to 'gitlab.com/geontime/redkite', so I updated it.

I also made a follow-up patch that downloads a git checkout instead of
an autogenerated tarball, because the tarball hash might change in the
future when GitLab generates a new one.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.