GNU bug report logs - #38120
[PATCH] gnu: Add geonkick.

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Fri, 8 Nov 2019 10:14:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38120 in the body.
You can then email your comments to 38120 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38120; Package guix-patches. (Fri, 08 Nov 2019 10:14:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alexandros Theodotou <alex <at> zrythm.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 08 Nov 2019 10:14:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add geonkick.
Date: Fri, 08 Nov 2019 11:13:12 +0100
From 09c3a68bfd70d80984a5956fad0596bb7c3e07ac Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 10:11:50 +0000
Subject: [PATCH] gnu: Add geonkick.

* gnu/packages/music.scm: (geonkick): New variable.
---
 gnu/packages/music.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..eae05499a1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4699,3 +4700,42 @@ You can also get metadata about the playing track 
such as the artist and title
 for integration into status line generators or other command-line 
tools.")
     (home-page "https://github.com/altdesktop/playerctl")
     (license license:lgpl3+)))
+
+(define-public geonkick
+  (package
+    (name "geonkick")
+    (version "1.9.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append 
"https://gitlab.com/iurie/geonkick/-/archive/v"
+                            version "/geonkick-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; no tests included
+       #:configure-flags
+       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
+                            (assoc-ref %build-inputs "redkite"))
+             (string-append "-DCMAKE_INSTALL_PREFIX="
+                            (assoc-ref %outputs "out")))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("jack", jack-1) ; for the standalone
+       ("libsndfile", libsndfile)
+       ("libx11", libx11)))
+    (native-inputs
+     `(("lv2", lv2)
+       ("pkg-config", pkg-config)
+       ("sord", sord)
+       ("rapidjson", rapidjson)
+       ("redkite", redkite)))
+    (synopsis "Percussion synthesizer")
+    (description "Geonkick is a synthesizer that can synthesize 
elements of
+percussion such as kicks, snares, hit-hats, shakers, claps and sticks. 
It can
+also play and mix samples.")
+    (home-page "https://gitlab.com/iurie/geonkick")
+    (license license:gpl3+)))
-- 
2.24.0





Information forwarded to guix-patches <at> gnu.org:
bug#38120; Package guix-patches. (Sun, 10 Nov 2019 22:18:01 GMT) Full text and rfc822 format available.

Message #8 received at 38120 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38120 <at> debbugs.gnu.org
Subject: Re: [bug#38120] [PATCH] gnu: Add geonkick.
Date: Sun, 10 Nov 2019 23:17:21 +0100
[Message part 1 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:

>  From 09c3a68bfd70d80984a5956fad0596bb7c3e07ac Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +       ("jack", jack-1) ; for the standalone

Standalone what?  :-)

Otherwise LGTM modulo indentation issues.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38120; Package guix-patches. (Mon, 11 Nov 2019 03:15:02 GMT) Full text and rfc822 format available.

Message #11 received at 38120 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38120 <at> debbugs.gnu.org
Subject: Re: [bug#38120] [PATCH] gnu: Add geonkick.
Date: Mon, 11 Nov 2019 03:14:10 +0000
[Message part 1 (text/plain, inline)]
Updated
[0001-gnu-Add-geonkick.patch (text/x-patch, attachment)]

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Wed, 13 Nov 2019 22:31:03 GMT) Full text and rfc822 format available.

Notification sent to Alexandros Theodotou <alex <at> zrythm.org>:
bug acknowledged by developer. (Wed, 13 Nov 2019 22:31:03 GMT) Full text and rfc822 format available.

Message #16 received at 38120-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38120-done <at> debbugs.gnu.org
Subject: Re: [bug#38120] [PATCH] gnu: Add geonkick.
Date: Wed, 13 Nov 2019 23:30:07 +0100
[Message part 1 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:

> From 98c080f2f27d9f7a99dd635948dc062bde75ed1c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +(define-public geonkick
> +  (package
> +    (name "geonkick")
> +    (version "1.9.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://gitlab.com/iurie/geonkick/-/archive/v"
> +                            version "/geonkick-v" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))

As with redkite, I followed the redirect and changed to a git checkout.

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests included
> +       #:configure-flags
> +       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
> +                            (assoc-ref %build-inputs "redkite"))
> +             (string-append "-DCMAKE_INSTALL_PREFIX="
> +                            (assoc-ref %outputs "out")))))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("jack" ,jack-1) ; for the standalone JACK application
> +       ("libsndfile" ,libsndfile)
> +       ("libx11" ,libx11)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)
> +       ("sord" ,sord)
> +       ("rapidjson" ,rapidjson)
> +       ("redkite" ,redkite)))

I moved rapidjson and redkite to inputs, because the package embeds
their static libraries, so the architecture has to match when
cross-compiling.

Applied!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 12 Dec 2019 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.