GNU bug report logs - #38126
[PATCH] gnu: Add libltc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38126 in the body.
You can then email your comments to 38126 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add libltc.
Date: Fri, 08 Nov 2019 11:47:17 +0100

From 061201b2179f5ac1c0a3cce89a256d7722c31978 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 10:45:11 +0000
Subject: [PATCH] gnu: Add libltc.

* gnu/packages/audio.scm: (libltc): New variable.
---
 gnu/packages/audio.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..acfd517bee 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3773,3 +3774,30 @@ other Gnaural instances, allowing synchronous 
sessions between many users.")
 a sound card, encodes it into Ogg Vorbis and/or mp3, and sends the 
audio
 stream to one or more IceCast and/or ShoutCast servers.")
     (license license:gpl3+)))
+
+(define-public libltc
+  (package
+    (name "libltc")
+    (version "1.3.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "https://github.com/x42/libltc/releases/download/v"
+               version "/libltc-" version ".tar.gz"))
+        (sha256
+          (base32
+            "173h9dgmain3nyrwk6q2d7yl4fnh4vacag4s2p01n5b7nyrkxrjh"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f)) ; tests fail
+    (inputs
+     `(("glibc" ,glibc)))
+    (native-inputs
+     `(("doxygen" ,doxygen)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "Linear/Logitudinal Time Code (LTC) Library")
+    (description "Libltc is a POSIX-C Library for handling 
Linear/Logitudinal
+Time Code (LTC).")
+    (home-page "http://x42.github.io/libltc/")
+    (license license:lgpl3+)))
-- 
2.24.0

Message #8 received at 38126 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38126 <at> debbugs.gnu.org
Subject: Re: [bug#38126] [PATCH] gnu: Add libltc.
Date: Sun, 10 Nov 2019 23:05:16 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

>  From 061201b2179f5ac1c0a3cce89a256d7722c31978 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:45:11 +0000
> Subject: [PATCH] gnu: Add libltc.
>
> * gnu/packages/audio.scm: (libltc): New variable.

[...]

> +(define-public libltc
> +  (package
> +    (name "libltc")
> +    (version "1.3.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://github.com/x42/libltc/releases/download/v"
> +               version "/libltc-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "173h9dgmain3nyrwk6q2d7yl4fnh4vacag4s2p01n5b7nyrkxrjh"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; tests fail

Could you give some information as to why the tests fail?  Often it's
simply because of '/bin/sh' references and similar.  You can investigate
a failed build with 'guix build --keep-failed'.

> +    (inputs
> +     `(("glibc" ,glibc)))

glibc is always available and does not need to be explicitly provided.

> +    (native-inputs
> +     `(("doxygen" ,doxygen)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Linear/Logitudinal Time Code (LTC) Library")
> +    (description "Libltc is a POSIX-C Library for handling 
> Linear/Logitudinal
> +Time Code (LTC).")
> +    (home-page "http://x42.github.io/libltc/")
                     ^^^
                   HTTPS
> +    (license license:lgpl3+)))
> -- 
> 2.24.0

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38126 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38126 <at> debbugs.gnu.org
Subject: Re: [bug#38126] [PATCH] gnu: Add libltc.
Date: Mon, 11 Nov 2019 02:35:55 +0000

[Message part 1 (text/plain, inline)]

Patch updated

[0001-gnu-Add-libltc.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38126-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38126-done <at> debbugs.gnu.org
Subject: Re: [bug#38126] [PATCH] gnu: Add libltc.
Date: Wed, 13 Nov 2019 23:25:47 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> From 54e5a26b1a2d95370167d09591c2d12bf7b87503 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:45:11 +0000
> Subject: [PATCH] gnu: Add libltc.
>
> * gnu/packages/audio.scm: (libltc): New variable.

This was missing a module import for (gnu packages documentation).

I also tweaked synopsis and description slightly.  Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.