GNU bug report logs - #38127
[PATCH] gnu: Add x42-plugins.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38127 in the body.
You can then email your comments to 38127 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add x42-plugins.
Date: Fri, 08 Nov 2019 11:55:53 +0100

NOTE: this patch depends on
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38121 and
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38126

From ee2e983068b3dd11aaed7c703388904749e77a44 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 10:54:00 +0000
Subject: [PATCH] gnu: Add x42-plugins.

* gnu/packages/music.scm: (x42-plugins): New variable.
---
 gnu/packages/music.scm | 55 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..a6caf4d0ff 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4699,3 +4700,57 @@ You can also get metadata about the playing track 
such as the artist and title
 for integration into status line generators or other command-line 
tools.")
     (home-page "https://github.com/altdesktop/playerctl")
     (license license:lgpl3+)))
+
+(define-public x42-plugins
+  (package
+    (name "x42-plugins")
+    (version "20191013")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "http://gareus.org/misc/x42-plugins/x42-plugins-"
+               version ".tar.xz"))
+        (sha256
+          (base32
+            "18kn1bmc0s6dp834kc51ibifzzn3bxwya4p8s8yq9f4mpmkghi24"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             "LIBZITACONVOLVER=-lzita-convolver"
+             (string-append
+              "FONTFILE=" (assoc-ref %build-inputs "font-dejavu")
+              "/share/fonts/truetype/DejaVuSans-Bold.ttf"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _ (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("fftwf" ,fftwf)
+       ("jack" ,jack-1)
+       ("fftw" ,fftw)
+       ("ftgl" ,ftgl)
+       ("glib" ,glib)
+       ("glibc" ,glibc)
+       ("glu" ,glu)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("libsamplerate" ,libsamplerate)
+       ("libx11" ,libx11)
+       ("libltc" ,libltc)
+       ("pango" ,pango)
+       ("zita-convolver" ,zita-convolver)))
+    (native-inputs
+     `(("help2man" ,help2man)
+       ("liblo" ,liblo)
+       ("lv2" ,lv2)
+       ("font-dejavu" ,font-dejavu)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "Collection of LV2/JACK audio/MIDI processing plugins")
+    (description "x42-plugins is a collection of over 80 cross-platform 
LV2
+audio and MIDI plugins that can also run as standalone JACK 
applications.")
+    (home-page "https://x42-plugins.com/x42/")
+    (license license:gpl2+)))
-- 
2.24.0

Message #8 received at 38127 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38127 <at> debbugs.gnu.org
Subject: Re: [bug#38127] [PATCH] gnu: Add x42-plugins.
Date: Sun, 10 Nov 2019 23:00:03 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> NOTE: this patch depends on
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38121 and
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38126
>  From ee2e983068b3dd11aaed7c703388904749e77a44 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:54:00 +0000
> Subject: [PATCH] gnu: Add x42-plugins.
>
> * gnu/packages/music.scm: (x42-plugins): New variable.

The patch LGTM overall, but indentation seems to be off.  Can you run
this through "./etc/indent-code.el"?

[...]

> +    (synopsis "Collection of LV2/JACK audio/MIDI processing plugins")
> +    (description "x42-plugins is a collection of over 80 cross-platform 
> LV2
> +audio and MIDI plugins that can also run as standalone JACK 
> applications.")
> +    (home-page "https://x42-plugins.com/x42/")
> +    (license license:gpl2+)))

I notice in the FAQ that "Some binaries are provided as demo.  A
license/signature file is required to remove the evaluation
restrictions".

If there are such binaries in the source tarball, they must be removed
with a source 'snippet' to ensure 'guix build --source' contains only
free software.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38127 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38127 <at> debbugs.gnu.org
Subject: Re: [bug#38127] [PATCH] gnu: Add x42-plugins.
Date: Mon, 11 Nov 2019 01:53:02 +0000

[Message part 1 (text/plain, inline)]

Thanks for the pointers!

> The patch LGTM overall, but indentation seems to be off.  Can you run
> this through "./etc/indent-code.el"?
That script gives me weird indentation that I don't see in any
packages, like:
(define-public dpf-plugins
  (package
   (name
   ^ missing space

Hopefully the updated patch looks better, I tried to match the other
packages in music.scm.

> > +audio and MIDI plugins that can also run as standalone JACK 
> > applications.")
> > +    (home-page "https://x42-plugins.com/x42/")
> > +    (license license:gpl2+)))
> 
> I notice in the FAQ that "Some binaries are provided as demo.  A
> license/signature file is required to remove the evaluation
> restrictions".
> 
> If there are such binaries in the source tarball, they must be
> removed
> with a source 'snippet' to ensure 'guix build --source' contains only
> free software.
This tarball only contains sources and is specifically targeted at
distro packagers (see https://github.com/x42/x42-plugins). I believe
the binaries are provided as separate downloads on the website.

[0001-gnu-Add-x42-plugins.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38127-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38127-done <at> debbugs.gnu.org
Subject: Re: [bug#38127] [PATCH] gnu: Add x42-plugins.
Date: Wed, 13 Nov 2019 23:26:20 +0100

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

>> > +audio and MIDI plugins that can also run as standalone JACK 
>> > applications.")
>> > +    (home-page "https://x42-plugins.com/x42/")
>> > +    (license license:gpl2+)))
>> 
>> I notice in the FAQ that "Some binaries are provided as demo.  A
>> license/signature file is required to remove the evaluation
>> restrictions".
>> 
>> If there are such binaries in the source tarball, they must be
>> removed
>> with a source 'snippet' to ensure 'guix build --source' contains only
>> free software.
> This tarball only contains sources and is specifically targeted at
> distro packagers (see https://github.com/x42/x42-plugins). I believe
> the binaries are provided as separate downloads on the website.

OK, that's reassuring.  Thanks for checking!

> From 05ffc94c834f99b3cb56a9ebc97096958a07981e Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 10:54:00 +0000
> Subject: [PATCH] gnu: Add x42-plugins.
>
> * gnu/packages/music.scm: (x42-plugins): New variable.

[...]

> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("fftwf" ,fftwf)
> +       ("jack" ,jack-1)
> +       ("fftw" ,fftw)

I removed 'fftw', since it appeared unused.  Let me know if that was
mistaken.  I also sorted these alphabetically out of preference.

Applied!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.