GNU bug report logs - #38157
[PATCH] gnu: Add font-dseg.

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Sun, 10 Nov 2019 03:22:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38157 in the body.
You can then email your comments to 38157 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38157; Package guix-patches. (Sun, 10 Nov 2019 03:22:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alexandros Theodotou <alex <at> zrythm.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 10 Nov 2019 03:22:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add font-dseg.
Date: Sun, 10 Nov 2019 03:20:05 +0000
[Message part 1 (text/plain, inline)]
There's probably an easy way to remove the dot from the version but I
can't figure it out. Any modifications welcome.
[0001-gnu-Add-font-dseg.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38157; Package guix-patches. (Sun, 10 Nov 2019 12:36:02 GMT) Full text and rfc822 format available.

Message #8 received at 38157 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38157 <at> debbugs.gnu.org
Subject: Re: [bug#38157] [PATCH] gnu: Add font-dseg.
Date: Sun, 10 Nov 2019 13:35:15 +0100
[Message part 1 (text/plain, inline)]
Alexandros,

Thanks for all these patches!  I look forward to trying Zrythm 
when it comes to Guix.

Alexandros Theodotou 写道:
> There's probably an easy way to remove the dot from the version 
> but I
> can't figure it out. Any modifications welcome.

You could

   (apply string-append (string-split version #\.))
or

   (string-join (string-split version #\.) "")

I think I prefer the STRING-APPEND version but both are fine.

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38157; Package guix-patches. (Sun, 10 Nov 2019 18:12:02 GMT) Full text and rfc822 format available.

Message #11 received at 38157 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 38157 <at> debbugs.gnu.org
Subject: Re: [bug#38157] [PATCH] gnu: Add font-dseg.
Date: Sun, 10 Nov 2019 18:11:12 +0000
[Message part 1 (text/plain, inline)]
Hi Tobias,

> You could
> 
>     (apply string-append (string-split version #\.))
> or
> 
>     (string-join (string-split version #\.) "")
> 
> I think I prefer the STRING-APPEND version but both are fine.

Thank you for the pointer! Patch updated.

Just a general note that there are some additional WOFF fonts in the
zip, but I think those are only relevant for websites so I am only
installing the truetype fonts. 

I also tested and verified that Zrythm can now find the font.
[0001-gnu-Add-font-dseg.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 19 Nov 2019 09:52:02 GMT) Full text and rfc822 format available.

Notification sent to Alexandros Theodotou <alex <at> zrythm.org>:
bug acknowledged by developer. (Tue, 19 Nov 2019 09:52:02 GMT) Full text and rfc822 format available.

Message #16 received at 38157-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38157-done <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: [bug#38157] [PATCH] gnu: Add font-dseg.
Date: Tue, 19 Nov 2019 10:51:19 +0100
[Message part 1 (text/plain, inline)]
Hello Alexandros,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From ec6c88abe3de6346087d821539e43afb3dff42c8 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Sun, 10 Nov 2019 01:25:28 +0000
> Subject: [PATCH] gnu: Add font-dseg.
>
> * gnu/packages/fonts.scm (font-dseg): New variable.

Nice.  Applied with the minor changes below: addressing a ‘guix lint’
warning, and using an even more appropriate string function.  ;-)

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 7fe0aee20b..83c97444bf 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1537,7 +1537,7 @@ have been designed to be very distinguishable from each other.")
           (string-append "https://github.com/keshikan/DSEG/"
                          "releases/download/v" version
                          "/fonts-DSEG_v"
-                         (apply string-append (string-split version #\.))
+                         (string-concatenate (string-split version #\.))
                          ".zip"))
         (sha256
           (base32
@@ -1561,6 +1561,7 @@ have been designed to be very distinguishable from each other.")
     (home-page "https://www.keshikan.net/fonts-e.html")
     (synopsis "DSEG: 7-segment and 14-segment fonts")
     (description
-     "DSEG is a font family that imitates seven and fourteen segment
-display (7SEG,14SEG). DSEG includes the roman alphabet and symbol glyphs.")
+     "DSEG is a font family that imitates seven- and fourteen-segment LCD
+displays (7SEG, 14SEG).  DSEG includes the roman alphabet and symbol glyphs.
+This package provides the TrueType fonts.")
     (license license:silofl1.1)))

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 17 Dec 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 103 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.