GNU bug report logs - #38213
27.0.50; add tooltip move-frame handling to mouse-avoidance-mode

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Fri, 15 Nov 2019 00:11:01 UTC

Severity: normal

Tags: fixed

Fixed in version 27.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38213 in the body.
You can then email your comments to 38213 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 00:11:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Juri Linkov <juri <at> linkov.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 15 Nov 2019 00:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; add tooltip move-frame handling to mouse-avoidance-mode
Date: Fri, 15 Nov 2019 01:32:03 +0200
Some recent change caused tooltip frames to emit a new kind of event
'move-frame' (not sure should I try bisecting to find that commit)
that forces the mouse pointer in mouse-avoidance-mode to move
and thus removing the tooltip frame immediately after displaying it.

This patch adds handling of the new event 'move-frame':

diff --git a/lisp/avoid.el b/lisp/avoid.el
index 43e5062b76..9d6e502343 100644
--- a/lisp/avoid.el
+++ b/lisp/avoid.el
@@ -338,7 +338,7 @@ mouse-avoidance-ignore-p
 	     (let ((modifiers (event-modifiers (car last-input-event))))
 	       (or (memq (car last-input-event)
 			 '(mouse-movement scroll-bar-movement
-			   select-window focus-out))
+			   select-window focus-out move-frame))
 		   (memq 'click modifiers)
 		   (memq 'double modifiers)
 		   (memq 'triple modifiers)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 08:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 15 Nov 2019 09:13:25 +0100
> Some recent change caused tooltip frames to emit a new kind of event
> 'move-frame' (not sure should I try bisecting to find that commit)

MOVE_FRAME_EVENT exists since 2017-04-11, commit
ea6c880aa68bcc8f0e388ecbd8c552392488b38f.

martin




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 08:28:01 GMT) Full text and rfc822 format available.

Message #11 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50;
 add tooltip move-frame handling to mouse-avoidance-mode
Date: Fri, 15 Nov 2019 10:26:45 +0200
> From: Juri Linkov <juri <at> linkov.net>
> Date: Fri, 15 Nov 2019 01:32:03 +0200
> 
> Some recent change caused tooltip frames to emit a new kind of event
> 'move-frame' (not sure should I try bisecting to find that commit)
> that forces the mouse pointer in mouse-avoidance-mode to move
> and thus removing the tooltip frame immediately after displaying it.
> 
> This patch adds handling of the new event 'move-frame':

Shouldn't we instead avoid emitting this event when a tooltip frame is
positioned?  Otherwise, we will have to make such adaptations in many
places.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 08:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Juri Linkov <juri <at> linkov.net>
Cc: 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 15 Nov 2019 09:53:37 +0100
> Shouldn't we instead avoid emitting this event when a tooltip frame is
> positioned?  Otherwise, we will have to make such adaptations in many
> places.

Doesn't the tooltip frame get removed because 'mouse-avoidance-mode'
reacts to a movement of the normal frame that "hosts" the tooltip
frame.

martin




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 09:51:02 GMT) Full text and rfc822 format available.

Message #17 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 38213 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 15 Nov 2019 11:50:10 +0200
> Cc: 38213 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> Date: Fri, 15 Nov 2019 09:53:37 +0100
> 
>  > Shouldn't we instead avoid emitting this event when a tooltip frame is
>  > positioned?  Otherwise, we will have to make such adaptations in many
>  > places.
> 
> Doesn't the tooltip frame get removed because 'mouse-avoidance-mode'
> reacts to a movement of the normal frame that "hosts" the tooltip
> frame.

But the normal frame which hosts the tooltip is not moved in this
scenario.  To reproduce, turn on mouse-avoidance-mode (I used 'jump'
as the avoidance technique), then start Dired, and move the mouse to
the file name under cursor.  Here, the tooltip appears and immediately
disappears, and I see no movement of the "hosting" frame anywhere.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 16:37:02 GMT) Full text and rfc822 format available.

Message #20 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 38213 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 15 Nov 2019 17:35:42 +0100
[Message part 1 (text/plain, inline)]
> But the normal frame which hosts the tooltip is not moved in this
> scenario.  To reproduce, turn on mouse-avoidance-mode (I used 'jump'
> as the avoidance technique), then start Dired, and move the mouse to
> the file name under cursor.  Here, the tooltip appears and immediately
> disappears, and I see no movement of the "hosting" frame anywhere.

Hmm...  So you think that something like the attached should be
applied?

martin
[move-frame.diffs (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 15 Nov 2019 16:59:05 GMT) Full text and rfc822 format available.

Message #23 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 38213 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 15 Nov 2019 18:57:57 +0200
> Cc: juri <at> linkov.net, 38213 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> Date: Fri, 15 Nov 2019 17:35:42 +0100
> 
>  > But the normal frame which hosts the tooltip is not moved in this
>  > scenario.  To reproduce, turn on mouse-avoidance-mode (I used 'jump'
>  > as the avoidance technique), then start Dired, and move the mouse to
>  > the file name under cursor.  Here, the tooltip appears and immediately
>  > disappears, and I see no movement of the "hosting" frame anywhere.
> 
> Hmm...  So you think that something like the attached should be
> applied?

Yes, I think so.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Sat, 16 Nov 2019 08:20:02 GMT) Full text and rfc822 format available.

Message #26 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 38213 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Sat, 16 Nov 2019 09:19:13 +0100
>> Hmm...  So you think that something like the attached should be
>> applied?
>
> Yes, I think so.

Applied.

martin




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Thu, 21 Nov 2019 23:04:18 GMT) Full text and rfc822 format available.

Message #29 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Thu, 21 Nov 2019 23:31:13 +0200
tags 38213 fixed
close 38213 27.0.50
quit

>>> Hmm...  So you think that something like the attached should be
>>> applied?
>>
>> Yes, I think so.
>
> Applied.

Thanks.  I still can't find an explanation why there was no problem
until recently, but since it works now I'm closing this report.




Added tag(s) fixed. Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Thu, 21 Nov 2019 23:04:19 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.0.50, send any further explanations to 38213 <at> debbugs.gnu.org and Juri Linkov <juri <at> linkov.net> Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Thu, 21 Nov 2019 23:04:19 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Fri, 22 Nov 2019 08:10:18 GMT) Full text and rfc822 format available.

Message #36 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Fri, 22 Nov 2019 09:09:17 +0100
> Thanks.  I still can't find an explanation why there was no problem
> until recently, but since it works now I'm closing this report.

Maybe because you only used GTK's native tooltips until recently?

martin




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38213; Package emacs. (Tue, 26 Nov 2019 22:33:02 GMT) Full text and rfc822 format available.

Message #39 received at 38213 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 38213 <at> debbugs.gnu.org
Subject: Re: bug#38213: 27.0.50; add tooltip move-frame handling to
 mouse-avoidance-mode
Date: Wed, 27 Nov 2019 00:12:45 +0200
>> Thanks.  I still can't find an explanation why there was no problem
>> until recently, but since it works now I'm closing this report.
>
> Maybe because you only used GTK's native tooltips until recently?

This is exactly what happened (I didn't know that GTK builds use native tooltips)




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 25 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.