GNU bug report logs - #38217
[PATCH] gnu: rtmidi: Update to 4.0.0.

Previous Next

Package: guix-patches;

Reported by: Pierre Langlois <pierre.langlois <at> gmx.com>

Date: Fri, 15 Nov 2019 09:32:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38217 in the body.
You can then email your comments to 38217 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#38217; Package guix-patches. (Fri, 15 Nov 2019 09:32:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 15 Nov 2019 09:32:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: [PATCH] gnu: rtmidi: Update to 4.0.0.
Date: Fri, 15 Nov 2019 09:31:11 +0000

[Message part 1 (text/plain, inline)]
Hello Guix!

Here's an update for the rtmidi package. I've had to fix the
powertabeditor package to be able to find the RtMidi.h header which has
now moved into a subdirectory. It looks like the issue is fixed upstream
in the build system but no release have been made yet so I've added a
TODO to remove the hack later.

WDYT?

Thanks,
Pierre


[0001-gnu-rtmidi-Update-to-4.0.0.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#38217; Package guix-patches. (Fri, 15 Nov 2019 11:01:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>, 38217 <at> debbugs.gnu.org
Subject: Re: [bug#38217] [PATCH] gnu: rtmidi: Update to 4.0.0.
Date: Fri, 15 Nov 2019 12:00:32 +0100

Hello Pierre,

> Here's an update for the rtmidi package. I've had to fix the
> powertabeditor package to be able to find the RtMidi.h header which has
> now moved into a subdirectory. It looks like the issue is fixed upstream
> in the build system but no release have been made yet so I've added a
> TODO to remove the hack later.
>
> WDYT?

This patch LTGM! I have an error when closing powertabeditor but this
might be unrelated to this patch:

--8<---------------cut here---------------start------------->8---
Unhandled exception: Parse error at offset 18446744073709551615: The document is empty.
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [???]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [???]
/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [TuningDictionary::ensureLoaded]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [TuningDictionary::save]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [PowerTabEditor::closeEvent]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QWidget::event]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QMainWindow::event]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplicationPrivate::notify_helper]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplication::notify]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::notifyInternal2]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QWidgetPrivate::close_helper]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [???]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [???]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplicationPrivate::notify_helper]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplication::notify]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::notifyInternal2]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QGuiApplicationPrivate::processCloseEvent]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QGuiApplicationPrivate::processWindowSystemEvent]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QWindowSystemInterface::sendWindowSystemEvents]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5 [???]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QEventLoop::exec]
/gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::exec]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [main]
/gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29/lib/libc.so.6 [__libc_start_main]
/gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [_start]
--8<---------------cut here---------------end--------------->8---

Mathieu
Information forwarded to guix-patches <at> gnu.org:
bug#38217; Package guix-patches. (Fri, 15 Nov 2019 11:01:02 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#38217; Package guix-patches. (Fri, 15 Nov 2019 13:25:01 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>, 38217 <at> debbugs.gnu.org,
 guix-patches <at> gnu.org
Subject: Re: [bug#38217] [PATCH] gnu: rtmidi: Update to 4.0.0.
Date: Fri, 15 Nov 2019 13:24:28 +0000

Hi Mathieu,

Mathieu Othacehe writes:

> Hello Pierre,
>
>> Here's an update for the rtmidi package. I've had to fix the
>> powertabeditor package to be able to find the RtMidi.h header which has
>> now moved into a subdirectory. It looks like the issue is fixed upstream
>> in the build system but no release have been made yet so I've added a
>> TODO to remove the hack later.
>>
>> WDYT?
>
> This patch LTGM! I have an error when closing powertabeditor but this
> might be unrelated to this patch:
>
> --8<---------------cut here---------------start------------->8---
> Unhandled exception: Parse error at offset 18446744073709551615: The document is empty.
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [???]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [???]
> /gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
> /gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
> /gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/libstdc++.so.6 [???]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [TuningDictionary::ensureLoaded]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [TuningDictionary::save]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [PowerTabEditor::closeEvent]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QWidget::event]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QMainWindow::event]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplicationPrivate::notify_helper]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplication::notify]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::notifyInternal2]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QWidgetPrivate::close_helper]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [???]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [???]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplicationPrivate::notify_helper]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Widgets.so.5 [QApplication::notify]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::notifyInternal2]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QGuiApplicationPrivate::processCloseEvent]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QGuiApplicationPrivate::processWindowSystemEvent]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Gui.so.5 [QWindowSystemInterface::sendWindowSystemEvents]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5 [???]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QEventLoop::exec]
> /gnu/store/gl2mzs7ybzzfmy2yparzhrb6k0yqhxw2-qtbase-5.11.3/lib/libQt5Core.so.5 [QCoreApplication::exec]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [main]
> /gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29/lib/libc.so.6 [__libc_start_main]
> /gnu/store/4pj5nbb1j5s6049h6jjk580v6rp21wc3-powertabeditor-2.0.0-alpha10/bin/powertabeditor [_start]
> --8<---------------cut here---------------end--------------->8---

Oh thanks for trying it out!

I'm also seeing this error on master so I guess we should be OK with
this patch. Funny thing is, I see this error as a GUI pop-up when
running it under GDB, but on its own I just get an abort, not sure what
that's about. I've only tested it with `guix environment --ad-hoc
powertabeditor gdb` though.

The issue seems harmless as it just happens when you close the it, but
I don't personally use powertabeditor so I can't be sure.

Thanks,
Pierre
Information forwarded to guix-patches <at> gnu.org:
bug#38217; Package guix-patches. (Fri, 15 Nov 2019 13:25:02 GMT) Full text and rfc822 format available.
Reply sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
You have taken responsibility. (Fri, 15 Nov 2019 13:33:01 GMT) Full text and rfc822 format available.
Notification sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
bug acknowledged by developer. (Fri, 15 Nov 2019 13:33:01 GMT) Full text and rfc822 format available.

Message #22 received at 38217-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 38217-done <at> debbugs.gnu.org
Subject: Re: [bug#38217] [PATCH] gnu: rtmidi: Update to 4.0.0.
Date: Fri, 15 Nov 2019 14:32:16 +0100

> The issue seems harmless as it just happens when you close the it, but
> I don't personally use powertabeditor so I can't be sure.

Ok, I pushed it then.

Thanks,

Mathieu
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 14 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 133 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.