GNU bug report logs - #38290
[PATCH] gnu: nmoldyn: New source code location.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38290 in the body.
You can then email your comments to 38290 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: nmoldyn: New source code location.
Date: Tue, 19 Nov 2019 19:49:27 +0100

* gnu/packages/chemistry.scm (nmoldyn): New source code location.
Following the annoucement of Bitbucket to delete all
Mercurial repositories in June 2020, the source code has
been migrated to GitHub.
---
 gnu/packages/chemistry.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm
index b6345b9d27..3bdd406a47 100644
--- a/gnu/packages/chemistry.scm
+++ b/gnu/packages/chemistry.scm
@@ -243,13 +243,14 @@ analogy is that InChI is the bar-code for chemistry and chemical structures.")
     (version "3.0.11")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://bitbucket.org/khinsen/"
-                           "nmoldyn3/downloads/nMOLDYN-"
-                           version ".tar.gz"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/khinsen/nMOLDYN3")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "1mvmz3lkr217kdrd8cvdr1d82y58wp1403c9rnd943mijgq8xb5a"))))
+         "016h4bqg419p6s7bcx55q5iik91gqmk26hbnfgj2j6zl0j36w51r"))))
     (build-system python-build-system)
     (inputs
      `(("python-matplotlib" ,(with-numpy-1.8 python2-matplotlib))
-- 
2.24.0

Message #8 received at 38290 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 38290 <at> debbugs.gnu.org
Subject: Re: [bug#38290] [PATCH] gnu: nmoldyn: New source code location.
Date: Thu, 21 Nov 2019 10:11:44 +0100

Hello!

Konrad Hinsen <konrad.hinsen <at> fastmail.net> skribis:

> * gnu/packages/chemistry.scm (nmoldyn): New source code location.
> Following the annoucement of Bitbucket to delete all
> Mercurial repositories in June 2020, the source code has
> been migrated to GitHub.

[...]

> -       (method url-fetch)
> -       (uri (string-append "https://bitbucket.org/khinsen/"
> -                           "nmoldyn3/downloads/nMOLDYN-"
> -                           version ".tar.gz"))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/khinsen/nMOLDYN3")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
>         (sha256
>          (base32
> -         "1mvmz3lkr217kdrd8cvdr1d82y58wp1403c9rnd943mijgq8xb5a"))))
> +         "016h4bqg419p6s7bcx55q5iik91gqmk26hbnfgj2j6zl0j36w51r"))))

It’s weird that the content hash differs.  Did you try to diff the hg
checkout and the Git checkout?

Thanks,
Ludo’.

Message #11 received at 38290 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 38290 <at> debbugs.gnu.org
Subject: Re: [bug#38290] [PATCH] gnu: nmoldyn: New source code location.
Date: Thu, 21 Nov 2019 10:13:34 +0100

Ludovic Courtès <ludo <at> gnu.org> skribis:

>> -       (method url-fetch)
>> -       (uri (string-append "https://bitbucket.org/khinsen/"
>> -                           "nmoldyn3/downloads/nMOLDYN-"
>> -                           version ".tar.gz"))
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/khinsen/nMOLDYN3")
>> +             (commit (string-append "v" version))))
>> +       (file-name (git-file-name name version))
>>         (sha256
>>          (base32
>> -         "1mvmz3lkr217kdrd8cvdr1d82y58wp1403c9rnd943mijgq8xb5a"))))
>> +         "016h4bqg419p6s7bcx55q5iik91gqmk26hbnfgj2j6zl0j36w51r"))))
>
> It’s weird that the content hash differs.  Did you try to diff the hg
> checkout and the Git checkout?

Oh forget it, I see we’re going from a tarball to a checkout, hence the
difference.

LGTM!  :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.