GNU bug report logs - #38295
manual-config php-fpm mismatch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38295 in the body.
You can then email your comments to 38295 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: bug-guix <at> gnu.org
Subject: manual-config php-fpm mismatch
Date: Wed, 20 Nov 2019 12:43:43 +0200

[Message part 1 (text/plain, inline)]

In (gnu services web) for <php-fpm-configuration> it says that default
for 'socket-group' is "nginx". In the manual, in 8.8.16 (Web Services),
it says the socket-group default is php-fpm.

Obviously when deploying the code trumps the manual, but what is it
supposed to be?


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 38295 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 38295 <at> debbugs.gnu.org
Subject: Re: bug#38295: manual-config php-fpm mismatch
Date: Wed, 20 Nov 2019 16:43:27 +0100

[Message part 1 (text/plain, inline)]

Efraim,

Efraim Flashner 写道：
> In (gnu services web) for <php-fpm-configuration> it says that 
> default
> for 'socket-group' is "nginx". In the manual, in 8.8.16 (Web 
> Services),
> it says the socket-group default is php-fpm.

Good catch.

> Obviously when deploying the code trumps the manual, but what is 
> it
> supposed to be?

I think the code should follow the manual.  More privsep == 
better.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 38295-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 38295-done <at> debbugs.gnu.org
Subject: Re: bug#38295: manual-config php-fpm mismatch
Date: Thu, 21 Nov 2019 12:11:51 +0200

[Message part 1 (text/plain, inline)]

On Wed, Nov 20, 2019 at 04:43:27PM +0100, Tobias Geerinckx-Rice via Bug reports for GNU Guix wrote:
> Efraim,
> 
> Efraim Flashner 写道：
> > In (gnu services web) for <php-fpm-configuration> it says that default
> > for 'socket-group' is "nginx". In the manual, in 8.8.16 (Web Services),
> > it says the socket-group default is php-fpm.
> 
> Good catch.
> 

I've been hanging out in that code for the past week or so and I find I
can move around the code faster than the manual in a webpage.

> > Obviously when deploying the code trumps the manual, but what is it
> > supposed to be?
> 
> I think the code should follow the manual.  More privsep == better.

After some searching I didn't see an nginx user or group so there's
another reason. I'll go ahead and patch it.

> 
> Kind regards,
> 
> T G-R



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38295 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 38295 <at> debbugs.gnu.org
Subject: Re: bug#38295: manual-config php-fpm mismatch
Date: Thu, 21 Nov 2019 12:39:42 +0200

[Message part 1 (text/plain, inline)]

On Thu, Nov 21, 2019 at 12:11:51PM +0200, Efraim Flashner wrote:
> On Wed, Nov 20, 2019 at 04:43:27PM +0100, Tobias Geerinckx-Rice via Bug reports for GNU Guix wrote:
> > Efraim,
> > 
> > Efraim Flashner 写道：
> > > In (gnu services web) for <php-fpm-configuration> it says that default
> > > for 'socket-group' is "nginx". In the manual, in 8.8.16 (Web Services),
> > > it says the socket-group default is php-fpm.
> > 
> > Good catch.
> > 
> 
> I've been hanging out in that code for the past week or so and I find I
> can move around the code faster than the manual in a webpage.
> 
> > > Obviously when deploying the code trumps the manual, but what is it
> > > supposed to be?
> > 
> > I think the code should follow the manual.  More privsep == better.
> 
> After some searching I didn't see an nginx user or group so there's
> another reason. I'll go ahead and patch it.
> 

Actually I see that nginx is run as user/group nginx, so the
socket-group is probably supposed to be nginx.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 38295-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 38295-done <at> debbugs.gnu.org
Subject: Re: bug#38295: manual-config php-fpm mismatch
Date: Tue, 26 Nov 2019 14:07:09 +0200

[Message part 1 (text/plain, inline)]

After looking at the manual and the sources some more, I saw that for
the apache2 service it has the socket directory owned by httpd, so it
stands to reason that the code is correct, and by default the socket
directory for php-fpm is nginx.

Patch pushed to fix this


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.