GNU bug report logs - #38304
[PATCH]: Make more services one-shot

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Efraim Flashner <efraim@HIDDEN>; Keywords: patch; dated Wed, 20 Nov 2019 19:47:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 38304 <at> debbugs.gnu.org:


Received: (at 38304) by debbugs.gnu.org; 20 Nov 2019 19:54:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 20 14:54:49 2019
Received: from localhost ([127.0.0.1]:50953 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iXW3t-00088O-2z
	for submit <at> debbugs.gnu.org; Wed, 20 Nov 2019 14:54:49 -0500
Received: from flashner.co.il ([178.62.234.194]:54254)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim@HIDDEN>) id 1iXW3o-000886-Vv
 for 38304 <at> debbugs.gnu.org; Wed, 20 Nov 2019 14:54:47 -0500
Received: from localhost (unknown [141.226.13.108])
 by flashner.co.il (Postfix) with ESMTPSA id 0CFC1401AA
 for <38304 <at> debbugs.gnu.org>; Wed, 20 Nov 2019 19:54:38 +0000 (UTC)
Date: Wed, 20 Nov 2019 21:54:08 +0200
From: Efraim Flashner <efraim@HIDDEN>
To: 38304 <at> debbugs.gnu.org
Subject: Re: [bug#38304] [PATCH]: Make more services one-shot
Message-ID: <20191120195408.GW15074@E5400>
References: <20191120194544.GV15074@E5400>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="ZGDvG9BNY5+B3nxW"
Content-Disposition: inline
In-Reply-To: <20191120194544.GV15074@E5400>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
User-Agent: Mutt/1.12.2 (2019-09-21)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38304
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--ZGDvG9BNY5+B3nxW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 20, 2019 at 09:45:44PM +0200, Efraim Flashner wrote:
> After changing the sysctl service to use one-shot I found 3 more that
> look like they'd be good choices.
>=20

Actually, it looks like agetty and mingetty both rely on the host-name
service, so that one doesn't look like a good choice after all.

> From 64126d7a861a415bf4faafb30687928742db4f2b Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@HIDDEN>
> Date: Wed, 20 Nov 2019 21:36:56 +0200
> Subject: [PATCH 1/3] services: host-name: Make service one-shot.
>=20
> * gnu/services/base.scm (host-name-service-type): Remove 'respawn?'
> keyword from shepherd-service-type, add 'one-shot?'.
> ---
>  gnu/services/base.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index b1eff89ecc..7cd42bb30a 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -705,7 +705,7 @@ to add @var{device} to the kernel's entropy pool.  Th=
e service will fail if
>        (provision '(host-name))
>        (start #~(lambda _
>                   (sethostname #$name)))
> -      (respawn? #f)))))
> +      (one-shot? #t)))))
> =20
>  (define (host-name-service name)
>    "Return a service that sets the host name to @var{name}."
> --=20
> 2.24.0
>=20

> From 6c13de1914503afb3533a0fe032b4db767011874 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@HIDDEN>
> Date: Wed, 20 Nov 2019 21:38:18 +0200
> Subject: [PATCH 2/3] services: console-keymap-service-type: Make service
>  one-shot.
>=20
> * gnu/services/base.scm (console-keymap-service-type): Remove 'respawn?'
> keyword from shepherd-service-type, add 'one-shot?'.
> ---
>  gnu/services/base.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index 7cd42bb30a..022bb501ba 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -746,7 +746,7 @@ to add @var{device} to the kernel's entropy pool.  Th=
e service will fail if
>        (start #~(lambda _
>                   (zero? (system* #$(file-append kbd "/bin/loadkeys")
>                                   #$@files))))
> -      (respawn? #f)))))
> +      (one-shot? #t)))))
> =20
>  (define-deprecated (console-keymap-service #:rest files)
>    #f
> --=20
> 2.24.0
>=20

> From 153d02caa1333788df435ca4ffbf915c50d9cb01 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@HIDDEN>
> Date: Wed, 20 Nov 2019 21:40:50 +0200
> Subject: [PATCH 3/3] services: console-font-shepherd-services: Make servi=
ce
>  one-shot.
>=20
> * gnu/services/base.scm (console-font-shepherd-services): Remove 'stop'
> and 'respawn?' keywords from shepherd-service-type, add 'one-shot?'.
> ---
>  gnu/services/base.scm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index 022bb501ba..cef2d4cb2b 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -797,8 +797,7 @@ to add @var{device} to the kernel's entropy pool.  Th=
e service will fail if
>                                          "-C" #$device #$font))
>                            ((0 71) #t)
>                            (else #f))))
> -             (stop #~(const #t))
> -             (respawn? #f)))))
> +             (one-shot? #t)))))
>         tty+font))
> =20
>  (define console-font-service-type
> --=20
> 2.24.0
>=20




--=20
Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--ZGDvG9BNY5+B3nxW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3Vmd8ACgkQQarn3Mo9
g1Gw+g/+Okj7lvNo8Y6JZIB5h1QAaGkGy7BARklokYkeTKRZ+vsUjz7+OBBder4M
QrDO7aDhpP088on5/f897u7mfTxG+pkS+elKtfwd6S6PWcQEEufOCEde5gIiJgUJ
FWHjbpgv/TWvyT2gaCiFRQwPSWdqB5/WCwF4YGI0pAiFAkUPI5SFfXGSgwRxTXfX
p8DO/d3nKvRjX1C+DZQcxxdujRySav90v11+7bcw9QranRnzLnqKmJU4bASXx+l/
jfTt4alJ4F6JSpzQ8yjP35JqHpxQutMYVrYhyQpN8AOXlIdEIEp7Uio8ljA9wHd1
JFnWvKZ/ASz+GBA9P7H/qJ3baAksBGSzQXTB3fBqAeqWJgaL61DROXBYKKMj3++K
03aqZAkZ/H6DF+zLevCFjY+fo/v7Q9Ld0Y83rW5+Zz9RKtGfVq+d2yX/D44X25xa
AfbTK+cmuq8WxCxxzuA8XDvfb53tl5sgn0Ld0r33VC6j/dM3yWk47cyAzO0RT1C9
zc1rmpr+Lgl3SSezAlam0RDqnoKoQd3aHgwrxRvXRxzaiOazPZ1eunDiDKHMRVaE
DjVAtb0ym1VX6uWB5DuBd62F09PK4TCuioc2ps8bPevOJsAEKgIY0Up6Eq0dI6tB
glFThR9GJbYwUS1JjJzP9ls9ydw6X0BzuNNj6uCn3iY8AYEPOfQ=
=GvYp
-----END PGP SIGNATURE-----

--ZGDvG9BNY5+B3nxW--
Information forwarded to guix-patches@HIDDEN:
bug#38304; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Nov 2019 19:46:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 20 14:46:48 2019
Received: from localhost ([127.0.0.1]:50948 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iXVw8-0007vg-6T
	for submit <at> debbugs.gnu.org; Wed, 20 Nov 2019 14:46:48 -0500
Received: from lists.gnu.org ([209.51.188.17]:33860)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim@HIDDEN>) id 1iXVw4-0007vW-ND
 for submit <at> debbugs.gnu.org; Wed, 20 Nov 2019 14:46:45 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50245)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <efraim@HIDDEN>) id 1iXVw0-0005iA-Aw
 for guix-patches@HIDDEN; Wed, 20 Nov 2019 14:46:41 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <efraim@HIDDEN>) id 1iXVvz-0005zO-4A
 for guix-patches@HIDDEN; Wed, 20 Nov 2019 14:46:40 -0500
Received: from flashner.co.il ([178.62.234.194]:51574)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <efraim@HIDDEN>) id 1iXVvf-0005tt-5o
 for guix-patches@HIDDEN; Wed, 20 Nov 2019 14:46:39 -0500
Received: from localhost (unknown [141.226.13.108])
 by flashner.co.il (Postfix) with ESMTPSA id 23488401AA
 for <guix-patches@HIDDEN>; Wed, 20 Nov 2019 19:46:15 +0000 (UTC)
Date: Wed, 20 Nov 2019 21:45:44 +0200
From: Efraim Flashner <efraim@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH]: Make more services one-shot
Message-ID: <20191120194544.GV15074@E5400>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="4YatIo8qwOC8yTX3"
Content-Disposition: inline
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
User-Agent: Mutt/1.12.2 (2019-09-21)
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 178.62.234.194
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


--4YatIo8qwOC8yTX3
Content-Type: multipart/mixed; boundary="W1uEbMXJ1Mj4g6TI"
Content-Disposition: inline


--W1uEbMXJ1Mj4g6TI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

After changing the sysctl service to use one-shot I found 3 more that
look like they'd be good choices.


--=20
Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--W1uEbMXJ1Mj4g6TI
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0001-services-host-name-Make-service-one-shot.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 64126d7a861a415bf4faafb30687928742db4f2b Mon Sep 17 00:00:00 2001
=46rom: Efraim Flashner <efraim@HIDDEN>
Date: Wed, 20 Nov 2019 21:36:56 +0200
Subject: [PATCH 1/3] services: host-name: Make service one-shot.

* gnu/services/base.scm (host-name-service-type): Remove 'respawn?'
keyword from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index b1eff89ecc..7cd42bb30a 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -705,7 +705,7 @@ to add @var{device} to the kernel's entropy pool.  The =
service will fail if
       (provision '(host-name))
       (start #~(lambda _
                  (sethostname #$name)))
-      (respawn? #f)))))
+      (one-shot? #t)))))
=20
 (define (host-name-service name)
   "Return a service that sets the host name to @var{name}."
--=20
2.24.0


--W1uEbMXJ1Mj4g6TI
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0002-services-console-keymap-service-type-Make-service-on.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 6c13de1914503afb3533a0fe032b4db767011874 Mon Sep 17 00:00:00 2001
=46rom: Efraim Flashner <efraim@HIDDEN>
Date: Wed, 20 Nov 2019 21:38:18 +0200
Subject: [PATCH 2/3] services: console-keymap-service-type: Make service
 one-shot.

* gnu/services/base.scm (console-keymap-service-type): Remove 'respawn?'
keyword from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 7cd42bb30a..022bb501ba 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -746,7 +746,7 @@ to add @var{device} to the kernel's entropy pool.  The =
service will fail if
       (start #~(lambda _
                  (zero? (system* #$(file-append kbd "/bin/loadkeys")
                                  #$@files))))
-      (respawn? #f)))))
+      (one-shot? #t)))))
=20
 (define-deprecated (console-keymap-service #:rest files)
   #f
--=20
2.24.0


--W1uEbMXJ1Mj4g6TI
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-services-console-font-shepherd-services-Make-service.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 153d02caa1333788df435ca4ffbf915c50d9cb01 Mon Sep 17 00:00:00 2001
=46rom: Efraim Flashner <efraim@HIDDEN>
Date: Wed, 20 Nov 2019 21:40:50 +0200
Subject: [PATCH 3/3] services: console-font-shepherd-services: Make service
 one-shot.

* gnu/services/base.scm (console-font-shepherd-services): Remove 'stop'
and 'respawn?' keywords from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 022bb501ba..cef2d4cb2b 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -797,8 +797,7 @@ to add @var{device} to the kernel's entropy pool.  The =
service will fail if
                                         "-C" #$device #$font))
                           ((0 71) #t)
                           (else #f))))
-             (stop #~(const #t))
-             (respawn? #f)))))
+             (one-shot? #t)))))
        tty+font))
=20
 (define console-font-service-type
--=20
2.24.0


--W1uEbMXJ1Mj4g6TI--

--4YatIo8qwOC8yTX3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3Vl+cACgkQQarn3Mo9
g1GP6Q//R+/vw7GU01J38iceLEqUz9gLpUcDqwze8PIRS78yr1GYKuk4BLcstQX7
2/0Xpj8BTH0fMKtwubErk/n7VaqLTR5LVa05TcbOXql+8UgJ3fXHzOfONgkcg8c5
feSU7zuXSI3t5Oo3jgriB68025g4sdyu3DUEE/2RAvclBdZx3216vJeu5JriUTYQ
FryUpZqX0T60TfDIIEzFYomvS2WSe8Hl2TJDSJEHrlv5tqxdk3CMPF31hh+afO5T
fOAy+Z0ePesl9U1I0ajhh5abm6sM8In1awYUpHnB8ArCnJuKR1H74AdXYZ6wm1aH
lGlukQ32zPe2Hy/x+c0o+qOyVXgH+DzCFvyxVoqb7e1eW6ljgoq74HGsqSH3vyzZ
tr8GGUggDsJVXPQEm1lBbc8Wa6OeDZhKYeurYXZS0hsaeMSHV2m3K9o/Wut03rjQ
S3KC/9djHV2XcAHUWENTaYE/QRe6/ns/oOTfIPS/ceC7eB3rIsBOr36451lDpxfI
t75wN3CfTIevHJEZ6s4Idbn8drsJziOP0sdckVQhFvtXyxJ2/nX9jmCqg9DnWZAg
73TCMNIzgDB5KR44arGGd5GjBEygCYdId8JwtRAxr3DDi2/DmpWH2NRUdTmuABsW
k0EllW7gOv6D7z6Q+fq8zzwMqM6JMnlDb751Wdb2VpnE+B6HVyQ=
=4XBE
-----END PGP SIGNATURE-----

--4YatIo8qwOC8yTX3--
Acknowledgement sent to Efraim Flashner <efraim@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#38304; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.