GNU bug report logs - #38305
Typo in libtool/m4/libtool.m4

Previous Next

Package: libtool;

Reported by: "Green, Paul" <Paul.Green <at> stratus.com>

Date: Wed, 20 Nov 2019 23:05:02 UTC

Severity: normal

Done: Mike Frysinger <vapier <at> gentoo.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38305 in the body.
You can then email your comments to 38305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-libtool <at> gnu.org:
bug#38305; Package libtool. (Wed, 20 Nov 2019 23:05:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Green, Paul" <Paul.Green <at> stratus.com>:
New bug report received and forwarded. Copy sent to bug-libtool <at> gnu.org. (Wed, 20 Nov 2019 23:05:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Green, Paul" <Paul.Green <at> stratus.com>
To: "bug-libtool <at> gnu.org" <bug-libtool <at> gnu.org>
Subject: Typo in libtool/m4/libtool.m4
Date: Wed, 20 Nov 2019 23:02:59 +0000
[Message part 1 (text/plain, inline)]
Gentle libtool maintainers,

While reading libtool.m4, I noticed that there are two spellings of the variable "old_archive_from_new_cmds". Most references to this variable use lower-case letters. But 3 references, all within "os2" sections, refer to the variable as "old_archive_From_new_cmds". Note the capital "F".

Perhaps the OS/2 shell is case-insensitive and this typo doesn't matter in the OS/2 environment. But I still think it should be corrected, because anyone searching for all references to "old_archive_from_new_cmds" will overlook the 3 references made by the os2 configuration code.

Sincerely,
Paul Green
Sr. Technical Consultant (Retired)
Stratus Technologies, Inc.

[Message part 2 (text/html, inline)]

Information forwarded to bug-libtool <at> gnu.org:
bug#38305; Package libtool. (Wed, 17 Jan 2024 07:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 38305 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: 38305 <at> debbugs.gnu.org
Cc: Paul.Green <at> stratus.com
Subject: [PATCH] libtool.m4: fix old_archive_from_new_cmds variable name typo
Date: Wed, 17 Jan 2024 02:46:47 -0500
From: Paul Green <Paul.Green <at> stratus.com>

The "From" should be "from" in the variable name.

Fixes libtool bug https://bugs.gnu.org/38305

* m4/libtool.m4: Change F to f in old_archive_from_new_cmds.
---
 m4/libtool.m4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 6172662c7a1f..ed572bb3e2b3 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -5173,7 +5173,7 @@ _LT_EOF
 	cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
 	$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
 	emximp -o $lib $output_objdir/$libname.def'
-      _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+      _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
       _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
       _LT_TAGVAR(file_list_spec, $1)='@'
       ;;
@@ -5879,7 +5879,7 @@ _LT_EOF
 	cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
 	$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
 	emximp -o $lib $output_objdir/$libname.def'
-      _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+      _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
       _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
       _LT_TAGVAR(file_list_spec, $1)='@'
       ;;
@@ -6748,7 +6748,7 @@ if test yes != "$_lt_caught_CXX_error"; then
 	  cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
 	  $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
 	  emximp -o $lib $output_objdir/$libname.def'
-	_LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+	_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
 	_LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
 	_LT_TAGVAR(file_list_spec, $1)='@'
 	;;
-- 
2.43.0





bug closed, send any further explanations to 38305 <at> debbugs.gnu.org and "Green, Paul" <Paul.Green <at> stratus.com> Request was from Mike Frysinger <vapier <at> gentoo.org> to control <at> debbugs.gnu.org. (Wed, 17 Jan 2024 07:48:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 14 Feb 2024 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 44 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.