GNU bug report logs - #38310
27.0.50; (image-convert "data" t) doesn't work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38310 in the body.
You can then email your comments to 38310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; (image-convert "data" t) doesn't work
Date: Thu, 21 Nov 2019 16:12:39 +0900

Hi,

Whereas (image-convert "file") works, (image-convert "data" t)
causes an error as follows:

(let ((image-converter 'graphicsmagick))
  (image-convert "data" t))
=>
image-convert: /usr/bin/gm convert: Unable to open file (-) [No such file or directory].

(let ((image-converter 'imagemagick))
  (image-convert "data" t))
=>
image-convert: convert: unable to open image `nil:-': No such file or directory @ error/blob.c/OpenBlob/2873.
convert: no decode delegate for this image format `' @ error/constitute.c/ReadImage/560.
convert: no images defined `png:-' @ error/convert.c/ConvertImageCommand/3258.

Where "data" is a binary string of a webp image gotten from:
<https://www.gstatic.com/webp/gallery/1.sm.webp>
Is a temp file required instead of stdin to those converters?

In relation to this, I think `image-convert' should be autoloaded
for the case where `(create-image FILE-OR-DATA 'image-convert)'
is called from a program other than `find-file'.

Thanks.
Regards,

$ gm -version
GraphicsMagick 1.3.33 2019-07-20 Q16 http://www.GraphicsMagick.org/

$ convert -version
ImageMagick 6.9.10-11 Q16 x86_64 2018-09-08 https://www.imagemagick.org

Message #8 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Thu, 21 Nov 2019 13:55:48 +0100

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> Whereas (image-convert "file") works, (image-convert "data" t)
> causes an error as follows:
>
> (let ((image-converter 'graphicsmagick))
>   (image-convert "data" t))
> =>
> image-convert: /usr/bin/gm convert: Unable to open file (-) [No such
> file or directory].

Yeah, but that's not a valid call format.  As the doc string says

---
If IMAGE-FORMAT is non-nil, IMAGE is a string containing the
image data, and IMAGE-FORMAT is a symbol with a MIME format name
like "image/webp".
---

So you have to say

(image-convert "data" 'image/webp)

I'll rephrase the doc string, because it's not very well-written.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Thu, 21 Nov 2019 14:02:16 +0100

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> In relation to this, I think `image-convert' should be auto loaded
> for the case where `(create-image FILE-OR-DATA 'image-convert)'
> is called from a program other than `find-file'.

Yup; should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Fri, 22 Nov 2019 09:02:23 +0900

On Thu, 21 Nov 2019 13:55:48 +0100, Lars Ingebrigtsen wrote:
> So you have to say

> (image-convert "data" 'image/webp)

> I'll rephrase the doc string, because it's not very well-written.

Ah, thanks.  I verified both these tests work with Emacs -Q.

(with-current-buffer
    (url-retrieve-synchronously
     "https://www.gstatic.com/webp/gallery/1.sm.webp")
  (goto-char (point-min))
  (search-forward "\n\n")
  (image-convert (buffer-substring (point) (point-max)) 'image/webp))

(with-current-buffer
    (url-retrieve-synchronously
     "https://www.gstatic.com/webp/gallery/1.sm.webp")
  (goto-char (point-min))
  (search-forward "\n\n")
  (create-image (buffer-substring (point) (point-max)) 'image-convert
		t :format 'image/webp))

Message #21 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Fri, 22 Nov 2019 13:16:11 +0100

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> Ah, thanks.  I verified both these tests work with Emacs -Q.
>
> (with-current-buffer
>     (url-retrieve-synchronously
>      "https://www.gstatic.com/webp/gallery/1.sm.webp")
>   (goto-char (point-min))
>   (search-forward "\n\n")
>   (image-convert (buffer-substring (point) (point-max)) 'image/webp))

Perhaps image-convert should signal an explicit error if the second
parameter isn't on the proper format?

I've now added some better error feedback on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Mon, 25 Nov 2019 13:11:43 +0900

On Fri, 22 Nov 2019 13:16:11 +0100, Lars Ingebrigtsen wrote:
> Perhaps image-convert should signal an explicit error if the second
> parameter isn't on the proper format?

> I've now added some better error feedback on the trunk.

It looks useful for people like me.  Thanks.

I think it would be better if we can see what types are available
to convert before trying to convert no matter whether ImageMagick
is built-in.  The default value for `imagemagick-enabled-types'
looks old as it does not contain at least WEBP, and there is no
such one that can be used for GraphicsMagick.

The goal might be to make it enable a programmer to do this
without considering whether conversion is necessary or not:

(let ((type "image/webp"))
  (if (image-type-displayable-p type)
      (create-image "file-or-data" type nil-or-t)))

Regards,

Message #27 received at 38310 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 38310 <at> debbugs.gnu.org
Subject: Re: bug#38310: 27.0.50; (image-convert "data" t) doesn't work
Date: Wed, 27 Nov 2019 13:04:08 +0100

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> The goal might be to make it enable a programmer to do this
> without considering whether conversion is necessary or not:
>
> (let ((type "image/webp"))
>   (if (image-type-displayable-p type)
>       (create-image "file-or-data" type nil-or-t)))

Yes, that would be nice.  But you can almost do that with just

(ignore-errors (create-image file))

:-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.