GNU bug report logs - #38319
[PATCH 0/4] Fix wrap-qt-program some packages using Qt

Previous Next

Package: guix-patches;

Reported by: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Date: Fri, 22 Nov 2019 09:37:01 UTC

Severity: normal

Tags: patch

Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38319 in the body.
You can then email your comments to 38319 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Fri, 22 Nov 2019 09:37:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 22 Nov 2019 09:37:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] Fix wrap-qt-program some packages using Qt
Date: Fri, 22 Nov 2019 10:35:56 +0100
During investigating `wrap-qt-program` for kdevelop I discovered that the
paths added there does not match the paths used by qtbase's native-search-path
specifications.

While this would not matter much for the wrapped program (as long as the
package it belongs to stores the files into these places) this is at least
irritating. More important: The wrong paths will not be picked up by qtbase's
native-search-path and thus other packages might experience dubious problems.

I checked all packages using `wrap-qt-package` whether they are using one of
these changed paths, and also all occurrences of '"/plugin' and '"/qml' in
package definitions.


Hartmut Goebel (4):
  gnu: sddm: Fix output directory for QML files.
  guix: Fix wrap-qt-program..
  gnu: python-pyqt: Fix output directory for plugins.
  gnu: kdeconnect: Remove useless code.

 gnu/packages/display-managers.scm | 2 +-
 gnu/packages/kde.scm              | 3 ---
 gnu/packages/qt.scm               | 2 +-
 guix/build/qt-utils.scm           | 4 ++--
 4 files changed, 4 insertions(+), 7 deletions(-)

-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Fri, 22 Nov 2019 09:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 38319 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: sddm: Fix output directory for QML files.
Date: Fri, 22 Nov 2019 10:37:27 +0100
Path must match qtbase's native-search-path specification, otherwise it
will not be picked up by other packages.

* gnu/packages/display-managers.scm(sddm)[arguments]<configure-flags>:
  Change value of "-DQT_IMPORTS_DIR".
---
 gnu/packages/display-managers.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 0b8f742c38..21afc0ec5c 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -102,7 +102,7 @@
                        (assoc-ref %build-inputs "shadow")
                        "/etc/login.defs")
         (string-append "-DQT_IMPORTS_DIR="
-                       (assoc-ref %outputs "out") "/qml")
+                       (assoc-ref %outputs "out") "/lib/qt5/qml")
         (string-append "-DCMAKE_INSTALL_SYSCONFDIR="
                        (assoc-ref %outputs "out") "/etc"))
        #:modules ((guix build cmake-build-system)
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Fri, 22 Nov 2019 09:38:07 GMT) Full text and rfc822 format available.

Message #11 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 38319 <at> debbugs.gnu.org
Subject: [PATCH 2/4] guix: Fix wrap-qt-program.
Date: Fri, 22 Nov 2019 10:37:28 +0100
Paths added here need to match qtbase's native-search-path specifications.

* guix/build/qt-utils.scm(wrap-qt-program): Change paths used for
  QML2_IMPORT_PATH and QT_PLUGIN_PATH.
---
 guix/build/qt-utils.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm
index 48a32674e9..d2486ee86c 100644
--- a/guix/build/qt-utils.scm
+++ b/guix/build/qt-utils.scm
@@ -26,9 +26,9 @@
       (if env-val (string-append env-val ":" path) path)))
 
   (let ((qml-path        (suffix "QML2_IMPORT_PATH"
-                                 (string-append out "/qml")))
+                                 (string-append out "/lib/qt5/qml")))
         (plugin-path     (suffix "QT_PLUGIN_PATH"
-                                 (string-append out "/plugins")))
+                                 (string-append out "/lib/qt5/plugins")))
         (xdg-data-path   (suffix "XDG_DATA_DIRS"
                                  (string-append out "/share")))
         (xdg-config-path (suffix "XDG_CONFIG_DIRS"
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Fri, 22 Nov 2019 09:38:08 GMT) Full text and rfc822 format available.

Message #14 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 38319 <at> debbugs.gnu.org
Subject: [PATCH 3/4] gnu: python-pyqt: Fix output directory for plugins.
Date: Fri, 22 Nov 2019 10:37:29 +0100
This defaults to QT_INSTALL_PLUGINS, thus we should use the same
sub-path ($out/lib/qt5/plugins) here.

* gnu/packages/qt.scm(python-pyqt)[arguments]<phases>{configure}:
  Change base path for plugins.
---
 gnu/packages/qt.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 5f4f29a948..ba6595cdfb 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1616,7 +1616,7 @@ module provides support functions to the automatically generated code.")
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin"))
                     (sip (string-append out "/share/sip"))
-                    (plugins (string-append out "/plugins"))
+                    (plugins (string-append out "/lib/qt5/plugins"))
                     (designer (string-append plugins "/designer"))
                     (qml (string-append plugins "/PyQt5"))
                     (python (assoc-ref inputs "python"))
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Fri, 22 Nov 2019 09:38:08 GMT) Full text and rfc822 format available.

Message #17 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 38319 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: kdeconnect: Remove useless code.
Date: Fri, 22 Nov 2019 10:37:30 +0100
After fixing wrap-qt-program, setting QT_PLUGIN_PATH here is no longer
necessary.

* gnu/packages/kde.scm(kdeconnect)[arguments]<phases>{wrap-executable}:
  Remove setting QT_PLUGIN_PATH.
---
 gnu/packages/kde.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index dcce02e467..636b5d60ba 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -558,9 +558,6 @@ different notification systems.")
          (add-after 'install 'wrap-executable
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
-               (setenv "QT_PLUGIN_PATH"
-                       (string-append out "/lib/qt5/plugins"
-                                      ":" (getenv "QT_PLUGIN_PATH")))
                (wrap-qt-program out "../lib/libexec/kdeconnectd")
                (wrap-qt-program out "kdeconnect-cli")
                (wrap-qt-program out "kdeconnect-handler")
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Mon, 25 Nov 2019 22:36:02 GMT) Full text and rfc822 format available.

Message #20 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 38319 <at> debbugs.gnu.org
Subject: Re: [bug#38319] [PATCH 1/4] gnu: sddm: Fix output directory for QML
 files.
Date: Mon, 25 Nov 2019 23:35:15 +0100
Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> Path must match qtbase's native-search-path specification, otherwise it
> will not be picked up by other packages.
>
> * gnu/packages/display-managers.scm(sddm)[arguments]<configure-flags>:
>   Change value of "-DQT_IMPORTS_DIR".

LGTM!




Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Mon, 25 Nov 2019 22:38:01 GMT) Full text and rfc822 format available.

Message #23 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 38319 <at> debbugs.gnu.org
Subject: Re: [bug#38319] [PATCH 2/4] guix: Fix wrap-qt-program.
Date: Mon, 25 Nov 2019 23:37:08 +0100
Hello,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> Paths added here need to match qtbase's native-search-path specifications.
  ^~~~~

“File names” or “directory names”.

> * guix/build/qt-utils.scm(wrap-qt-program): Change paths used for
                           ^
Missing space.  :-)

LGTM!

If I’m not mistaken, less than a dozen of packages depend on this file,
right?  If that’s the case, this can go to master.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Mon, 25 Nov 2019 22:38:02 GMT) Full text and rfc822 format available.

Message #26 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 38319 <at> debbugs.gnu.org
Subject: Re: [bug#38319] [PATCH 3/4] gnu: python-pyqt: Fix output directory
 for plugins.
Date: Mon, 25 Nov 2019 23:37:45 +0100
Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> This defaults to QT_INSTALL_PLUGINS, thus we should use the same
> sub-path ($out/lib/qt5/plugins) here.

“sub-directory”  :-)

> * gnu/packages/qt.scm(python-pyqt)[arguments]<phases>{configure}:
>   Change base path for plugins.

“base file name”

LGTM, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#38319; Package guix-patches. (Mon, 25 Nov 2019 22:39:01 GMT) Full text and rfc822 format available.

Message #29 received at 38319 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 38319 <at> debbugs.gnu.org
Subject: Re: [bug#38319] [PATCH 4/4] gnu: kdeconnect: Remove useless code.
Date: Mon, 25 Nov 2019 23:38:05 +0100
Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> After fixing wrap-qt-program, setting QT_PLUGIN_PATH here is no longer
> necessary.
>
> * gnu/packages/kde.scm(kdeconnect)[arguments]<phases>{wrap-executable}:
>   Remove setting QT_PLUGIN_PATH.

LGTM, thanks!




Reply sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
You have taken responsibility. (Tue, 26 Nov 2019 11:34:02 GMT) Full text and rfc822 format available.

Notification sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
bug acknowledged by developer. (Tue, 26 Nov 2019 11:34:02 GMT) Full text and rfc822 format available.

Message #34 received at 38319-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38319-close <at> debbugs.gnu.org
Subject: Re: [bug#38319] [PATCH 4/4] gnu: kdeconnect: Remove useless code.
Date: Tue, 26 Nov 2019 12:33:11 +0100
Updated and pushed as 0d455d9865c1bfd21a9415aa8515e75058dd7ee5

Thansk for the review.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 24 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.