GNU bug report logs - #38343
27.0.50; vc git: Cannot edit outgoing log (like git commit --amend)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>; Keywords: patch; Done: Sean Whitton <spwhitton@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 38343-done <at> debbugs.gnu.org:


Received: (at 38343-done) by debbugs.gnu.org; 4 Mar 2025 04:27:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 03 23:27:31 2025
Received: from localhost ([127.0.0.1]:54100 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpJsQ-0003Wo-SU
	for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:27:31 -0500
Received: from sendmail.purelymail.com ([34.202.193.197]:37446)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1tpJsN-0003WU-PW
 for 38343-done <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:27:28 -0500
DKIM-Signature: a=rsa-sha256;
 b=bLmuJ7mmp8KbZnH00KFKxHptlTLnGBv3NzBFwG6lQNXGJWbcRUDE+GudPGeLGBIn8U095E0LdiA2iNx9jCoKJBque2IrH3ct4whBmEz1Ja0ewyEe35l5+NCKjQ2ZOvQRyii0XYrD9Te1hmAYCZWFhYGzjEd94dXIAMSvKNi/CsXdcU1jYUox7lT2RvrX8hJfiFGmR02DZHLeDdOMKZtBcN8bu/Fd3iZV3OsYAKUXP/rJE1SEDfNHTqD3lhmYRY5g8XAG//tqUdL0Jf6YaSMsi2aHgSjPSEo9VGArDLxh1L+V6iwttNC33V1lzNLgGgzam1F4q1NO39Moa3Skw7tKTQ==;
 s=purelymail2; d=spwhitton.name; v=1;
 bh=vHhgH9ntRTXIbavDWLS0fK6YqRt8kT9XPjWCwsWbm8I=;
 h=Received:Received:From:To:Subject:Date; 
DKIM-Signature: a=rsa-sha256;
 b=m+dCG3as9VaG3aG94wMpCG5i/ZYTcgfKNJ4FHR2IF7o+VSWFQCOqfIlXG/EXea5ZVEyOfiEO+Bfqy/U0M0+l+cUMIuAoiQMVyjRwpwn6qfobeytm98kSOjcl28Df+t0MNHl3rICg14Q4Al3nbX0drJmu04QtqX4JaofQOviXOnW2XvNxZZVUiCAKpLEAxicgYlQRMMk9T1bh4nYKUKbZqaEa10tlN6Ku6m+eEniug6HTpn97ibGP5gx78caLYU30LNFq5kRNTw+Y6KRzQMojbSCJ7oSUTBY65d3ys2RlW63Bzeo0FoquP3kYV+n+E8W1n0X3pshlgUO7s2DLicsLWw==;
 s=purelymail2; d=purelymail.com; v=1;
 bh=vHhgH9ntRTXIbavDWLS0fK6YqRt8kT9XPjWCwsWbm8I=;
 h=Feedback-ID:Received:Received:From:To:Subject:Date; 
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 38343-done <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1776501579
 for <38343-done <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Tue, 04 Mar 2025 04:27:21 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id AFDE37E1A88; Tue,  4 Mar 2025 12:27:14 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: 38343-done <at> debbugs.gnu.org
Subject: feature in 31.1
Date: Tue, 04 Mar 2025 12:27:14 +0800
Message-ID: <87plix4dzx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 38343-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Version: 31.1

This is available now.

-- 
Sean Whitton
Notification sent to Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Sean Whitton <spwhitton@HIDDEN>:
You have taken responsibility. Full text available.
Disconnected #38343 from all other report(s). Request was from Sean Whitton <spwhitton@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 38343 64055. Request was from Sean Whitton <spwhitton@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 28 Nov 2019 20:49:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 28 15:49:20 2019
Received: from localhost ([127.0.0.1]:59177 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iaQj2-0005Ue-Dn
	for submit <at> debbugs.gnu.org; Thu, 28 Nov 2019 15:49:20 -0500
Received: from mail-qk1-f181.google.com ([209.85.222.181]:40736)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iaQix-0005UM-Is
 for 38343 <at> debbugs.gnu.org; Thu, 28 Nov 2019 15:49:17 -0500
Received: by mail-qk1-f181.google.com with SMTP id a137so21967240qkc.7
 for <38343 <at> debbugs.gnu.org>; Thu, 28 Nov 2019 12:49:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=Z0LcrFXlOpZVcNNEpPc2oBE9t9pw8DF3keE9I0lDX1Q=;
 b=kcwIjJth1lJbaS4cH6uI1Kg6HbRkFlGXv/4X2BsRg2LPSm+mYhcT8wGekJqANhMtea
 fSR4suQDpQxECMVONGH5t9+clFNbUg5l/7bMwQM3bSoXXdvJ7n7CTlIFgdyvDjsZYCUN
 bndQcPKcXuhJDTZSSFfrl697T3+17ny8sRetw8WtDdnKw2g3iY2b64OE8uBPfWjKiXCz
 RLuAjcXu1QYfJQCVlL4W4m7tUWJi2fih9khdsMZj3mMOecX7oaSucHetiztAShzLPuy7
 b8fxHafPXRsud+xwIVIC4uQmWX25h0Tyrrq6nvyeopOXXzwuTCQYyQojtXh7jKUbilhI
 v8wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Z0LcrFXlOpZVcNNEpPc2oBE9t9pw8DF3keE9I0lDX1Q=;
 b=HMV9vQAdXbHdbN03O3Xa85T7ZU5/h6ATZekneBiYbGPlKc85FsCjjiGKi9u0SzdIvW
 pQc2Nyb4aPkVuLo1d98swYNaSTransqZiHJNEgBT4DXnXyipHiV5QuMgNc/opTfNtxK9
 H/dPsCUCMWhEPfLaQClPsEJqsb63kY2/Evkh77Sceb4zGfXmp/c+uxX4T4AD070vRzzM
 5DRxPT92ZcvL2mQG2j2RujrNFmE/n9gB9ifHH2yPECJXJZY24bbe5AjEvoPgxPbAgmtb
 Bo3XVHXw9uLQa2QJKOMNmZHPtprsjIFifZxxWZj0KVndeadgozZ5pXzzvOxAf5dTfZc4
 T6nw==
X-Gm-Message-State: APjAAAUANK6a4e2KuDriioiPtif//S9T3aTZT4rxBP9bGpZFH3+Q3tl8
 doZuF6t03PKltpfOQKKZW5pwx2P2qXBJ6AltrFY=
X-Google-Smtp-Source: APXvYqzIDqLdBBNv8XSGdRs2M35M+ubfwgsijWvP+IZWQSRDrtUeJy8HYrIKUxhLqsPFyOAhn2kGI9X8XHUbHwKDiSY=
X-Received: by 2002:a37:514:: with SMTP id 20mr10108799qkf.321.1574974148741; 
 Thu, 28 Nov 2019 12:49:08 -0800 (PST)
MIME-Version: 1.0
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
 <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
 <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
 <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@HIDDEN>
 <CAEhcwWbf8LC+0SH_c5sb83LUdLqnMLySDeuEO-Zhoutev=ofBQ@HIDDEN>
 <85bba360-2a57-63b8-d82f-3ed7bcd8bee1@HIDDEN>
In-Reply-To: <85bba360-2a57-63b8-d82f-3ed7bcd8bee1@HIDDEN>
From: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
Date: Thu, 28 Nov 2019 21:48:57 +0100
Message-ID: <CAEhcwWYNdTpGs4eJo7i47ecRhDu9e1y7vkq5agWGyo-WtMHPmw@HIDDEN>
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Dmitry Gutov <dgutov@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000aa8ff805986e3e17"
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Den ons 27 nov. 2019 kl 23:08 skrev Dmitry Gutov : > On
 27.11.2019
 22:11, Fredrik Nyqvist wrote: > > > > > > Den ons 27 nov. 2019 kl 01:10 skrev
 Dmitry Gutov <dgutov@HIDDEN > > <mailto:dgutov@HIDDEN>>: > > > > On
 26.11.2019 22:43, Fredrik Nyqvis [...] 
 Content analysis details:   (1.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (fredrik.nyqvist94[at]gmail.com)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.222.181 listed in list.dnswl.org]
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (fredrik.nyqvist94[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
 blocked.  See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
 for more information. [URIs: stackoverflow.com]
 0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.222.181 listed in wl.mailspike.net]
 1.0 FREEMAIL_REPLY         From and body contain different freemails
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--000000000000aa8ff805986e3e17
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Den ons 27 nov. 2019 kl 23:08 skrev Dmitry Gutov <dgutov@HIDDEN>:

> On 27.11.2019 22:11, Fredrik Nyqvist wrote:
> >
> >
> > Den ons 27 nov. 2019 kl 01:10 skrev Dmitry Gutov <dgutov@HIDDEN
> > <mailto:dgutov@HIDDEN>>:
> >
> >     On 26.11.2019 22:43, Fredrik Nyqvist wrote:
> >      > Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmitry Gutov
> >     <dgutov@HIDDEN <mailto:dgutov@HIDDEN>
> >      > <mailto:dgutov@HIDDEN <mailto:dgutov@HIDDEN>>>:
> >      >
> >      >     On 25.11.2019 22:16, Fredrik Nyqvist wrote:
> >      >      > Yes, I have tried the option you mention to edit the last
> >     commit
> >      >     with
> >      >      > C-x C-e and it is working fine.
> >      >      > But It seems that it only allows amending the last commit
> >     if I have
> >      >      > edited a file.
> >      >
> >      >     Yes. Not sure how to change an arbitrary commit in Git anywa=
y
> >     (without
> >      >     interactive rebase). The best approximation looks like this:
> >      >
> >      > https://stackoverflow.com/a/48999882/615245
> >      >
> >      >
> >      > I am not sure how to do it in a good way either. Maybe the optio=
n
> to
> >      > edit an
> >      > older commit message could be skipped for vc-git. And then just
> >     allow amend
> >      > on the latest one.
> >
> >     The question is how to skip. Error in the end, after the user has
> >     already written the new commit message?
> >
> >     Or add a backend predicate action, like "can edit revision ##".
> That's
> >     one more action, though.
> >
> >
> > If the user is trying to edit an older commit message from the
> > log-buffer (with log-view-modify-change-comment) I think an error
> > message is good, before writing the commit message ("can't edit revisio=
n
> > ##"). I feel that it will be more clear at least.
>
> Then it seems like we'd also have to introduce a new predicate backend
> action (like "can I edit this revision"). Given a recent discussion with
> our maintainer, I'm not confident we're allowed to do that.
>
> OK I understand.


> > Also we should think about how to handle a commit that has already been
> > pushed. In this case I guess a force push is needed, but maybe that is
> > not good to hide. Maybe it is better to just allow edit on local commit=
s
> > then.
>
> Yeah, it's going to be a choice. Sometimes editing even a commit that's
> been pushed is okay (if it's on a personal branch). We already allow
> doing that with 'C-x C-e', so I'd rather we only gave out a warning
> (with yes-no prompt). The aforementioned predicate could do that job, too=
.
>

That sounds good to me. At least so that log-view-modify-change-comment
works the same way as 'C-x C-e'.

--000000000000aa8ff805986e3e17
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"g=
mail_attr">Den ons 27 nov. 2019 kl 23:08 skrev Dmitry Gutov &lt;<a href=3D"=
mailto:dgutov@HIDDEN">dgutov@HIDDEN</a>&gt;:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">On 27.11.2019 22:11, Fredrik Nyqvist wro=
te:<br>
&gt; <br>
&gt; <br>
&gt; Den ons 27 nov. 2019 kl 01:10 skrev Dmitry Gutov &lt;<a href=3D"mailto=
:dgutov@HIDDEN" target=3D"_blank">dgutov@HIDDEN</a> <br>
&gt; &lt;mailto:<a href=3D"mailto:dgutov@HIDDEN" target=3D"_blank">dguto=
v@HIDDEN</a>&gt;&gt;:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0On 26.11.2019 22:43, Fredrik Nyqvist wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmit=
ry Gutov<br>
&gt;=C2=A0 =C2=A0 =C2=A0&lt;<a href=3D"mailto:dgutov@HIDDEN" target=3D"_=
blank">dgutov@HIDDEN</a> &lt;mailto:<a href=3D"mailto:dgutov@HIDDEN" =
target=3D"_blank">dgutov@HIDDEN</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; &lt;mailto:<a href=3D"mailto:dgutov@HIDDEN=
" target=3D"_blank">dgutov@HIDDEN</a> &lt;mailto:<a href=3D"mailto:dguto=
v@HIDDEN" target=3D"_blank">dgutov@HIDDEN</a>&gt;&gt;&gt;:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0On 25.11.2019 22:16, Fredr=
ik Nyqvist wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0 &gt; Yes, I have tried th=
e option you mention to edit the last<br>
&gt;=C2=A0 =C2=A0 =C2=A0commit<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0with<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0 &gt; C-x C-e and it is wo=
rking fine.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0 &gt; But It seems that it=
 only allows amending the last commit<br>
&gt;=C2=A0 =C2=A0 =C2=A0if I have<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0 &gt; edited a file.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0Yes. Not sure how to chang=
e an arbitrary commit in Git anyway<br>
&gt;=C2=A0 =C2=A0 =C2=A0(without<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;=C2=A0 =C2=A0 =C2=A0interactive rebase). The b=
est approximation looks like this:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; <a href=3D"https://stackoverflow.com/a/489998=
82/615245" rel=3D"noreferrer" target=3D"_blank">https://stackoverflow.com/a=
/48999882/615245</a><br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; I am not sure how to do it in a good way eith=
er. Maybe the option to<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; edit an<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; older commit message could be skipped for vc-=
git. And then just<br>
&gt;=C2=A0 =C2=A0 =C2=A0allow amend<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; on the latest one.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0The question is how to skip. Error in the end, afte=
r the user has<br>
&gt;=C2=A0 =C2=A0 =C2=A0already written the new commit message?<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0Or add a backend predicate action, like &quot;can e=
dit revision ##&quot;. That&#39;s<br>
&gt;=C2=A0 =C2=A0 =C2=A0one more action, though.<br>
&gt; <br>
&gt; <br>
&gt; If the user is trying to edit an older commit message from the <br>
&gt; log-buffer (with log-view-modify-change-comment) I think an error <br>
&gt; message is good, before writing the commit message (&quot;can&#39;t ed=
it revision <br>
&gt; ##&quot;). I feel that it will be more clear at least.<br>
<br>
Then it seems like we&#39;d also have to introduce a new predicate backend =
<br>
action (like &quot;can I edit this revision&quot;). Given a recent discussi=
on with <br>
our maintainer, I&#39;m not confident we&#39;re allowed to do that.<br>
<br></blockquote><div>OK I understand.<br></div><div>=C2=A0</div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">
&gt; Also we should think about how to handle a commit that has already bee=
n <br>
&gt; pushed. In this case I guess a force push is needed, but maybe that is=
 <br>
&gt; not good to hide. Maybe it is better to just allow edit on local commi=
ts <br>
&gt; then.<br>
<br>
Yeah, it&#39;s going to be a choice. Sometimes editing even a commit that&#=
39;s <br>
been pushed is okay (if it&#39;s on a personal branch). We already allow <b=
r>
doing that with &#39;C-x C-e&#39;, so I&#39;d rather we only gave out a war=
ning <br>
(with yes-no prompt). The aforementioned predicate could do that job, too.<=
br></blockquote><div>=C2=A0</div><div>That sounds good to me. At least so t=
hat log-view-modify-change-comment works the same way as &#39;C-x C-e&#39;.=
<br></div></div></div>

--000000000000aa8ff805986e3e17--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 27 Nov 2019 22:08:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 27 17:08:50 2019
Received: from localhost ([127.0.0.1]:56339 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ia5UQ-000210-9X
	for submit <at> debbugs.gnu.org; Wed, 27 Nov 2019 17:08:50 -0500
Received: from mail-wm1-f44.google.com ([209.85.128.44]:55835)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1ia5UO-00020j-Jj
 for 38343 <at> debbugs.gnu.org; Wed, 27 Nov 2019 17:08:49 -0500
Received: by mail-wm1-f44.google.com with SMTP id a131so4511167wme.5
 for <38343 <at> debbugs.gnu.org>; Wed, 27 Nov 2019 14:08:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=9CrFllfYrBjGIMtMPhuKEAKkX6jpJ82KxyUlGt1ltzU=;
 b=owSU0UkjhccH644dfYyhcVP+qdzWdhd8WhWv0fo5PzwjdjTlJ6NBgNczhySJ/P6IRV
 sFnnBoblh0EAlx3VlT/RNwAv4+HFAqUFH3LUMBJVkJ+eqcfRjYZ/qZF+7vytOEBcUbQN
 8a8qCUL+mTN0crMGXjKcnpBcXyq/3FBB6scIpfKhzzdzaCAUJmsE+1S7mdJEiux+N5VS
 cquRSh/bBqFfrNk2gqHvHjIgCGCTZcpFWU9QqmO+2SIVKREmDerWO2CCTa6qAQE1SSbI
 9B3UdN1fFPtvfGD9jsKYX9ODfOoWk52ys6iRq1sQ+0MxNKDkr6TTZndQHSwoaWxRYJJF
 RtFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=9CrFllfYrBjGIMtMPhuKEAKkX6jpJ82KxyUlGt1ltzU=;
 b=q/f/7Z8XNd6hoNxYBo8zVZxt+9ZEjMHXpIoQ9zWIUw1cV9SovbP5TDD8SN8fKL1azL
 JgqVMMlSctTWsOapFjG7f0sb/S8jFImIn7sSqYZmc8oO7pexZzBTctRv1RrYm1WK4tXF
 pTZxe/6kwXKGRmnbW8G9bY0yEDPfueSXE7gEee/GZfenjQR5bJg3EK3FbhakZQsxdOhs
 zV/uV32dDkcCB0/5no4QKjoO8Zy1sl+70PYb2Ntyf1DGX26GIrnqlyhlJtDbWvH+u6u3
 oVb/SK5XgLHW2M+jwk8lYF6hlAMT7loU2J2TwSOTUH/NtP83+Z/XkubwKOboWGgtNI5G
 Yq4A==
X-Gm-Message-State: APjAAAWaBQ4VEKHn2ZeGjNotNOlehj30WVLB0eneS/vg2aQwrbPVE+VK
 bUzjwzcJZYo57XtbY3xo7iA=
X-Google-Smtp-Source: APXvYqyMhJfYeiSaOig4sS5LyL5nb1J2afJOZ3AfC7rGI2XqgWPzTV3pOP6jx63mXc/VfM2nNZs1qA==
X-Received: by 2002:a1c:6144:: with SMTP id v65mr6612032wmb.53.1574892522782; 
 Wed, 27 Nov 2019 14:08:42 -0800 (PST)
Received: from [192.168.0.5] ([212.50.117.215])
 by smtp.googlemail.com with ESMTPSA id u16sm20780578wrr.65.2019.11.27.14.08.41
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 27 Nov 2019 14:08:42 -0800 (PST)
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
 <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
 <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
 <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@HIDDEN>
 <CAEhcwWbf8LC+0SH_c5sb83LUdLqnMLySDeuEO-Zhoutev=ofBQ@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <85bba360-2a57-63b8-d82f-3ed7bcd8bee1@HIDDEN>
Date: Thu, 28 Nov 2019 00:08:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAEhcwWbf8LC+0SH_c5sb83LUdLqnMLySDeuEO-Zhoutev=ofBQ@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

On 27.11.2019 22:11, Fredrik Nyqvist wrote:
> 
> 
> Den ons 27 nov. 2019 kl 01:10 skrev Dmitry Gutov <dgutov@HIDDEN 
> <mailto:dgutov@HIDDEN>>:
> 
>     On 26.11.2019 22:43, Fredrik Nyqvist wrote:
>      > Den mån 25 nov. 2019 kl 23:49 skrev Dmitry Gutov
>     <dgutov@HIDDEN <mailto:dgutov@HIDDEN>
>      > <mailto:dgutov@HIDDEN <mailto:dgutov@HIDDEN>>>:
>      >
>      >     On 25.11.2019 22:16, Fredrik Nyqvist wrote:
>      >      > Yes, I have tried the option you mention to edit the last
>     commit
>      >     with
>      >      > C-x C-e and it is working fine.
>      >      > But It seems that it only allows amending the last commit
>     if I have
>      >      > edited a file.
>      >
>      >     Yes. Not sure how to change an arbitrary commit in Git anyway
>     (without
>      >     interactive rebase). The best approximation looks like this:
>      >
>      > https://stackoverflow.com/a/48999882/615245
>      >
>      >
>      > I am not sure how to do it in a good way either. Maybe the option to
>      > edit an
>      > older commit message could be skipped for vc-git. And then just
>     allow amend
>      > on the latest one.
> 
>     The question is how to skip. Error in the end, after the user has
>     already written the new commit message?
> 
>     Or add a backend predicate action, like "can edit revision ##". That's
>     one more action, though.
> 
> 
> If the user is trying to edit an older commit message from the 
> log-buffer (with log-view-modify-change-comment) I think an error 
> message is good, before writing the commit message ("can't edit revision 
> ##"). I feel that it will be more clear at least.

Then it seems like we'd also have to introduce a new predicate backend 
action (like "can I edit this revision"). Given a recent discussion with 
our maintainer, I'm not confident we're allowed to do that.

> Also we should think about how to handle a commit that has already been 
> pushed. In this case I guess a force push is needed, but maybe that is 
> not good to hide. Maybe it is better to just allow edit on local commits 
> then.

Yeah, it's going to be a choice. Sometimes editing even a commit that's 
been pushed is okay (if it's on a personal branch). We already allow 
doing that with 'C-x C-e', so I'd rather we only gave out a warning 
(with yes-no prompt). The aforementioned predicate could do that job, too.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 27 Nov 2019 20:11:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 27 15:11:54 2019
Received: from localhost ([127.0.0.1]:56248 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ia3fG-0005Xd-87
	for submit <at> debbugs.gnu.org; Wed, 27 Nov 2019 15:11:54 -0500
Received: from mail-qk1-f176.google.com ([209.85.222.176]:47037)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1ia3fE-0005XR-OK
 for 38343 <at> debbugs.gnu.org; Wed, 27 Nov 2019 15:11:53 -0500
Received: by mail-qk1-f176.google.com with SMTP id f5so2325789qkm.13
 for <38343 <at> debbugs.gnu.org>; Wed, 27 Nov 2019 12:11:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=fWcDHoqogPJ68SqfOKJt/rM3GYk6fJzU9WrAeUFV5eM=;
 b=aseYK9lebYHoC2p+lL3S6NeD5m2wKkFSlr6kbBLNv73Oq5XBzjpCVoPz3pA1YBfBPS
 2uCcRLC34PdwPtfPINLOqDScWKD3UZdMT3A5V357sFgf4mSEIXDKdC7bgYfUnGRKjY/J
 8Z9UyIF5Q7OZfsfduSs5GccRP9WCd3HHcu7POakFVFMe9BMrpczAv173CzqwCSkvs9SF
 dR5v5/0Z1/Sc3DTa6OEeIKJ9m3ql7DWUKMy9MQzR7v5L5p2hAOqbjX2geCpJOWRWbh0F
 pDpqc0XrM/iiRYZVxmP2eKGXp4N1TiM9xaiFSooZ2t3Zz7qwrBil01ICpyvc0UBDMkyW
 Xofw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=fWcDHoqogPJ68SqfOKJt/rM3GYk6fJzU9WrAeUFV5eM=;
 b=S4ZtR01ZjcCzHEEL+5BmECMJthb8GtbQK+QTOHKU1akTZnpvFxj2Jj7qKf3DG/FgtX
 rKdqAdqKEQiSL9G1gT8XyCVlDwKyWsjQwdBGmSGv57MgvFALy1Kbij6Jt/E1bLHRNcZF
 bTxF0dUhmlJiio67y5Pv2HEA1V9cTaJ+xBPcaJiJUeXu4x8hRlZ38mT7AzuDTZOWF7Uy
 Ym+fzsl/nPDUFxc6NV14vmGiJrPLwez2pdCD/O1mgF/7HS3X5UY5P+du1A5IHpIrPkx1
 DAylheDBob96ZxV8XlTtPlS4VAzEH7KVrfPHUucgNFZnLT+51ofsoskqbUtbf+J+uG06
 4hKQ==
X-Gm-Message-State: APjAAAUt1/Te0tZzDJYM2QuQ8dJCymxwhG9gCqru8+Cmjflalqatmkl8
 af9sjKx+70woXSg7RCl9qCvyKle/cWpx396GC/c=
X-Google-Smtp-Source: APXvYqwTKuuRLhZVjAO0Auk6amNzGr5kEx/nA88oIrWZFDhdmLxdaoE/raWFzjM/DeQmi0/TYyGeR56xFUQcVsQ08BM=
X-Received: by 2002:a05:620a:12cb:: with SMTP id
 e11mr6457480qkl.247.1574885507195; 
 Wed, 27 Nov 2019 12:11:47 -0800 (PST)
MIME-Version: 1.0
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
 <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
 <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
 <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@HIDDEN>
In-Reply-To: <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@HIDDEN>
From: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
Date: Wed, 27 Nov 2019 21:11:36 +0100
Message-ID: <CAEhcwWbf8LC+0SH_c5sb83LUdLqnMLySDeuEO-Zhoutev=ofBQ@HIDDEN>
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Dmitry Gutov <dgutov@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000037e7040598599b47"
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Den ons 27 nov. 2019 kl 01:10 skrev Dmitry Gutov : > On 26.11.2019
    22:43, Fredrik Nyqvist wrote: > > Den mån 25 nov. 2019 kl 23:49 skrev Dmitry
    Gutov <dgutov@HIDDEN > > <mailto:dgutov@HIDDEN>>: > > > > On 25.11.2019
    22:16, Fredrik Nyqvist wrote [...] 
 
 Content analysis details:   (1.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: stackoverflow.com]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [209.85.222.176 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (fredrik.nyqvist94[at]gmail.com)
  0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
                             in digit (fredrik.nyqvist94[at]gmail.com)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [209.85.222.176 listed in wl.mailspike.net]
  1.0 FREEMAIL_REPLY         From and body contain different freemails
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--00000000000037e7040598599b47
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Den ons 27 nov. 2019 kl 01:10 skrev Dmitry Gutov <dgutov@HIDDEN>:

> On 26.11.2019 22:43, Fredrik Nyqvist wrote:
> > Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmitry Gutov <dgutov@HIDDEN
> > <mailto:dgutov@HIDDEN>>:
> >
> >     On 25.11.2019 22:16, Fredrik Nyqvist wrote:
> >      > Yes, I have tried the option you mention to edit the last commit
> >     with
> >      > C-x C-e and it is working fine.
> >      > But It seems that it only allows amending the last commit if I
> have
> >      > edited a file.
> >
> >     Yes. Not sure how to change an arbitrary commit in Git anyway
> (without
> >     interactive rebase). The best approximation looks like this:
> >
> >     https://stackoverflow.com/a/48999882/615245
> >
> >
> > I am not sure how to do it in a good way either. Maybe the option to
> > edit an
> > older commit message could be skipped for vc-git. And then just allow
> amend
> > on the latest one.
>
> The question is how to skip. Error in the end, after the user has
> already written the new commit message?
>
> Or add a backend predicate action, like "can edit revision ##". That's
> one more action, though.
>

If the user is trying to edit an older commit message from the log-buffer
(with log-view-modify-change-comment) I think an error message is good,
before writing the commit message ("can't edit revision ##"). I feel that
it will be more clear at least.

Also we should think about how to handle a commit that has already been
pushed. In this case I guess a force push is needed, but maybe that is not
good to hide. Maybe it is better to just allow edit on local commits then.

--00000000000037e7040598599b47
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">Den ons 27 nov. 2019 kl 01:10 skrev D=
mitry Gutov &lt;<a href=3D"mailto:dgutov@HIDDEN">dgutov@HIDDEN</a>&gt=
;:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 26.11.2019=
 22:43, Fredrik Nyqvist wrote:<br>
&gt; Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmitry Gutov &lt;<a href=3D"m=
ailto:dgutov@HIDDEN" target=3D"_blank">dgutov@HIDDEN</a> <br>
&gt; &lt;mailto:<a href=3D"mailto:dgutov@HIDDEN" target=3D"_blank">dguto=
v@HIDDEN</a>&gt;&gt;:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0On 25.11.2019 22:16, Fredrik Nyqvist wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; Yes, I have tried the option you mention to e=
dit the last commit<br>
&gt;=C2=A0 =C2=A0 =C2=A0with<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; C-x C-e and it is working fine.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; But It seems that it only allows amending the=
 last commit if I have<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; edited a file.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0Yes. Not sure how to change an arbitrary commit in =
Git anyway (without<br>
&gt;=C2=A0 =C2=A0 =C2=A0interactive rebase). The best approximation looks l=
ike this:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0<a href=3D"https://stackoverflow.com/a/48999882/615=
245" rel=3D"noreferrer" target=3D"_blank">https://stackoverflow.com/a/48999=
882/615245</a><br>
&gt; <br>
&gt; <br>
&gt; I am not sure how to do it in a good way either. Maybe the option to <=
br>
&gt; edit an<br>
&gt; older commit message could be skipped for vc-git. And then just allow =
amend<br>
&gt; on the latest one.<br>
<br>
The question is how to skip. Error in the end, after the user has <br>
already written the new commit message?<br>
<br>
Or add a backend predicate action, like &quot;can edit revision ##&quot;. T=
hat&#39;s <br>
one more action, though.<br></blockquote><div><br></div><div>If the user is=
 trying to edit an older commit message from the log-buffer (with log-view-=
modify-change-comment) I think an error message is good, before writing the=
 commit message (&quot;can&#39;t edit revision ##&quot;). I feel that it wi=
ll be more clear at least.</div><div><br></div><div>Also we should think ab=
out how to handle a commit that has already been pushed. In this case I gue=
ss a force push is needed, but maybe that is not good to hide. Maybe it is =
better to just allow edit on local commits then.<br></div></div></div>

--00000000000037e7040598599b47--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 27 Nov 2019 00:10:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 19:10:44 2019
Received: from localhost ([127.0.0.1]:53217 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iZkuq-00058P-Iz
	for submit <at> debbugs.gnu.org; Tue, 26 Nov 2019 19:10:44 -0500
Received: from mail-wr1-f42.google.com ([209.85.221.42]:41494)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1iZkuo-000589-IF
 for 38343 <at> debbugs.gnu.org; Tue, 26 Nov 2019 19:10:42 -0500
Received: by mail-wr1-f42.google.com with SMTP id b18so24577597wrj.8
 for <38343 <at> debbugs.gnu.org>; Tue, 26 Nov 2019 16:10:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=e6gupd+f7XhCfUTjnRgV+r9ZZ1b79RLV3SwGxtM/BHs=;
 b=qkFuPQa5FlCpAcPx+YvvtyJ73oALDnUpQPZ0d3wOvq/J+teXybR5Z9SXjPBtcO0hcU
 9n3OPI1m7MeHWyHThp6IrTKS8MHulJDxt3VtyiaofxvDLO777fzgJAtKYUii8iVyKVqm
 TybCxkPOgD0jHu7XZ/ReOmen5Bayx14r2gepfLB+Zu5Awd+gRHl+Dn+wLDh2Ute/xyBG
 Gk4dP9nwQIqCdyA1z08guJ6oAnoIm5ztGy7uwudolrFh2O0KeAtce5VJtTTr+SqrvvIK
 +7J+071GQ8rM5dGNGcMdzovYaMib3n4S5Q7Ksu7BocOTUup7IetU/9K23IaaQBwdBfrN
 P/FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=e6gupd+f7XhCfUTjnRgV+r9ZZ1b79RLV3SwGxtM/BHs=;
 b=FNpAXE9KxKdChdOPOg9GboTIgcNMn97XQMkHb3j843/Kn8I/n5WZFeABUF3HG23l3h
 aGwPeK9EONWUbLXkZZnHajW1wN9FOGik/yRKAx6UsW6Aq40doUxVQrDNbotbmqSniN9l
 eLsPts/DbdNTXMZYqoKihzz5J4G+/D8Pg+dh/v54VkCZtQAxf8yWUwWRVHodP155CEAk
 3z5C474JWLUgy/JQe1FUl8jEw5ZDhbGLGgUPuqGt+7SPGhF7TvNwlHxhS5VUqj7MqMTx
 gdwtoErfOtohdJ8OQRh7ETzx1n65RHMKTQUNQ4fqhSGbUbvy1BSTmXTUoa9YaPRn8QLl
 8FAg==
X-Gm-Message-State: APjAAAWSKYCfluweKuG7b4m78c15iF96qF4mZ/WK6bQXzJ1vm8n1Fw2F
 Kgmw4WcaSvgR3hk3NrWQNT/KmzwP
X-Google-Smtp-Source: APXvYqyq7aMGu76cF13VkrVjXkydKn6ZnFk6phS3ABB7Mg+vKz+k2v1BAuPMQXyddAwI8dWbqAtNig==
X-Received: by 2002:a5d:4085:: with SMTP id o5mr3620662wrp.321.1574813436694; 
 Tue, 26 Nov 2019 16:10:36 -0800 (PST)
Received: from [192.168.0.5] ([212.50.117.215])
 by smtp.googlemail.com with ESMTPSA id c15sm17030908wrx.78.2019.11.26.16.10.35
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Nov 2019 16:10:35 -0800 (PST)
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
 <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
 <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@HIDDEN>
Date: Wed, 27 Nov 2019 02:10:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

On 26.11.2019 22:43, Fredrik Nyqvist wrote:
> Den mån 25 nov. 2019 kl 23:49 skrev Dmitry Gutov <dgutov@HIDDEN 
> <mailto:dgutov@HIDDEN>>:
> 
>     On 25.11.2019 22:16, Fredrik Nyqvist wrote:
>      > Yes, I have tried the option you mention to edit the last commit
>     with
>      > C-x C-e and it is working fine.
>      > But It seems that it only allows amending the last commit if I have
>      > edited a file.
> 
>     Yes. Not sure how to change an arbitrary commit in Git anyway (without
>     interactive rebase). The best approximation looks like this:
> 
>     https://stackoverflow.com/a/48999882/615245
> 
> 
> I am not sure how to do it in a good way either. Maybe the option to 
> edit an
> older commit message could be skipped for vc-git. And then just allow amend
> on the latest one.

The question is how to skip. Error in the end, after the user has 
already written the new commit message?

Or add a backend predicate action, like "can edit revision ##". That's 
one more action, though.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 26 Nov 2019 20:44:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 15:44:12 2019
Received: from localhost ([127.0.0.1]:53060 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iZhgy-00047F-1E
	for submit <at> debbugs.gnu.org; Tue, 26 Nov 2019 15:44:12 -0500
Received: from mail-qt1-f180.google.com ([209.85.160.180]:36130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iZhgw-000473-GP
 for 38343 <at> debbugs.gnu.org; Tue, 26 Nov 2019 15:44:10 -0500
Received: by mail-qt1-f180.google.com with SMTP id y10so22927293qto.3
 for <38343 <at> debbugs.gnu.org>; Tue, 26 Nov 2019 12:44:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=dFCkVuCDo0oVUbTyIcmrCWRCYjKZncgQjC1YyV9+VGc=;
 b=CFOEO0fuiZC2QUWa3GH8Kp2QDfGGdy1lWtF45FH/jXJOU4d0C7pkjth2VTt8YfVA1Z
 h7Dc6Meb7FLzbEB9ZNJg7RQX0gHvqBTL9e4Bazlf49Z7Q5a1o4HV+VunCgBnILxmlkQ3
 7arlx/UKG4NLaMA2eRTzlN9FenMb8c6qHMigUktsdR2RMha7LWPnsMkLouVjNpqcJVUe
 l6dr9ZR2O8d916ihn/Y6P5J8ExlP3U9hnQnF5us4OiKhtVOtEUv0QqJmBNeezSmAmkRn
 a3YgsqcQUo0tGSYSmRTfBxltBXjvk/iqQvtgeFge2Rk/3NQh/X48PlGsaJzvhgD24B2G
 fCNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dFCkVuCDo0oVUbTyIcmrCWRCYjKZncgQjC1YyV9+VGc=;
 b=IOGX+IwPhu9BTZqJ2kYa08hBWisuiRmvdyQ3vOpTFcbmuzOc9Y/ZlbkTHj6PoaUVSl
 59/zyrdcP9ZIYyhxPQn+L3OCV3Oqtf40No59rNXS6/8QXw4F2Ywrlr/zp9NIJK0er8ua
 SLoIYGK7WlQrPkqiOVnoRDJ0T9MGnQ75jiWTb2t+iGVT8imnbQCD95Ndj6PL8aG6ivEq
 K2jewTiPrDraCwhD8nbYNoX8oXEiJJkHfnpCSSQhPZdM+MKrOpqF2Q30+emvVu3axyut
 ahCUt5f01CjG/z7Ck+gfTSxzucyPiyM2SHYvwKXc3dmMu3gtHUqNCDE0OzZ4qefyyo6F
 ti/Q==
X-Gm-Message-State: APjAAAUXz1vWAsvLqw1O2LWNsQwkclkk4GmLZcHMx3/HNJMC6h1RMWd4
 hIHA4qa1EYl98xt3K1kpv0MIvJwa9OIm5bhnAkk=
X-Google-Smtp-Source: APXvYqxfYx8+NcH8X6yjpn+jDZA/Lrl/VEum0DB8YHb074op79EMVGcaFSvM988z71aqkrnt2m1tj8U3ju9mIja/6WQ=
X-Received: by 2002:ac8:649:: with SMTP id e9mr36858654qth.178.1574801044833; 
 Tue, 26 Nov 2019 12:44:04 -0800 (PST)
MIME-Version: 1.0
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
 <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
In-Reply-To: <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
From: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
Date: Tue, 26 Nov 2019 21:43:54 +0100
Message-ID: <CAEhcwWZpK581rpxQeU=B9Gq8qu+gp7e41TcAtWPhK4BvvtFzxQ@HIDDEN>
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Dmitry Gutov <dgutov@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000de8a71059845f09e"
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--000000000000de8a71059845f09e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmitry Gutov <dgutov@HIDDEN>:

> On 25.11.2019 22:16, Fredrik Nyqvist wrote:
> > Yes, I have tried the option you mention to edit the last commit with
> > C-x C-e and it is working fine.
> > But It seems that it only allows amending the last commit if I have
> > edited a file.
>
> Yes. Not sure how to change an arbitrary commit in Git anyway (without
> interactive rebase). The best approximation looks like this:
>
> https://stackoverflow.com/a/48999882/615245


I am not sure how to do it in a good way either. Maybe the option to edit
an
older commit message could be skipped for vc-git. And then just allow amend
on the latest one.

--000000000000de8a71059845f09e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"></div><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">Den m=C3=A5n 25 nov. 2019 kl 23:49 skrev Dmit=
ry Gutov &lt;<a href=3D"mailto:dgutov@HIDDEN">dgutov@HIDDEN</a>&gt;:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 25.11.2019 22=
:16, Fredrik Nyqvist wrote:<br>
&gt; Yes, I have tried the option you mention to edit the last commit with =
<br>
&gt; C-x C-e and it is working fine.<br>
&gt; But It seems that it only allows amending the last commit if I have <b=
r>
&gt; edited a file.<br>
<br>
Yes. Not sure how to change an arbitrary commit in Git anyway (without <br>
interactive rebase). The best approximation looks like this:<br>
<br>
<a href=3D"https://stackoverflow.com/a/48999882/615245" rel=3D"noreferrer" =
target=3D"_blank">https://stackoverflow.com/a/48999882/615245</a></blockquo=
te><div><br></div><div>I am not sure how to do it in a good way either. May=
be the option to edit an <br></div><div>older commit message could be skipp=
ed for vc-git. And then just allow amend</div><div>on the latest one.<br></=
div><div></div><div><br></div><div><br></div></div></div>

--000000000000de8a71059845f09e--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 25 Nov 2019 22:49:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 25 17:49:29 2019
Received: from localhost ([127.0.0.1]:49886 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iZNAe-00042H-QU
	for submit <at> debbugs.gnu.org; Mon, 25 Nov 2019 17:49:28 -0500
Received: from mail-wr1-f52.google.com ([209.85.221.52]:44478)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1iZNAd-00041s-Dm
 for 38343 <at> debbugs.gnu.org; Mon, 25 Nov 2019 17:49:27 -0500
Received: by mail-wr1-f52.google.com with SMTP id i12so20122234wrn.11
 for <38343 <at> debbugs.gnu.org>; Mon, 25 Nov 2019 14:49:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=QkigIRM+It4s/owpHDIHWf0ICKNwQi10vkRQkNM6+JE=;
 b=a/GaLGxLHQ9bsche4WJT0+jmP7UwqQ9YDXL0O0rZVnZcovvPQQbij0oGQcDaCkH2Gq
 EgPgW3+8jZjaeP9YlaTFm/MasOWG7E97ZHxORPsCSWtx5P4MFLUZ2F54kuvb9SSeIrEM
 y9OktvU2uiwVo/tYKMUWrp5sg8imNWbkvdk5h7u6CZVChdQqU+D++B1dO+Ih/brCoyqb
 TRUIjxCXw+qlfec1Qz9cQyPYzoRd7fOfEXE0lbguDS23S9sOZGR6cILYUf59VLNXgnZm
 Hl301VJuUOW62totnzgYTFdWISSImoHuWt5r1gDu2w21gk/mIfK7rZCmDUvaMJdPlfX6
 kwkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=QkigIRM+It4s/owpHDIHWf0ICKNwQi10vkRQkNM6+JE=;
 b=nqycETxo1T/YUHEQ+nSqmHricKg9q7tEGiPHRjR1hw7iV+NSfBksREpX0fGnVVhAZ4
 xsDUED6TpRIU4mnisIjXkVncb/0OVcMohZ1GWhxcjlAGUQIMuMcD7A3vkve37i0rNCmM
 AOJrw6LjHU/SiF2hdzeXf5vtKGkVqtv+g3p4wwB60ORvyAjHW/rKqEFB0hDLpgR0JsR9
 8todK9fwwEMccEkOaYzsj+5/agDNNdmu8qiCScuslOiGF1J507J7PNU4jyQdnFGFqXqF
 9BSMlNNNGkRmswCdiMQLhuNGzLseEgfg+KUkio8n/jULrCyIgSWAQZH1LNtl/z0As0ke
 Qgtw==
X-Gm-Message-State: APjAAAVTQV5dmPFulSnVgjCDqcGbyvrenJClodX6HsO+oZC3M5OZlmBq
 q6rhXTx3rc++NNGznu8AA6Iqnqha
X-Google-Smtp-Source: APXvYqympq/y1l9gfMdGefEcjnQ7SmcC62Cq2Nv9yR+ZSXpA5ZgIkaWgZFdSbVpKRW0Pg1VFQO5NcA==
X-Received: by 2002:adf:e5ce:: with SMTP id a14mr12630006wrn.214.1574722161055; 
 Mon, 25 Nov 2019 14:49:21 -0800 (PST)
Received: from [192.168.0.5] ([212.50.117.215])
 by smtp.googlemail.com with ESMTPSA id r15sm12757149wrc.5.2019.11.25.14.49.18
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 25 Nov 2019 14:49:19 -0800 (PST)
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
 <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <e16cb4ab-3c93-66c5-a9a7-482ce38e7d2c@HIDDEN>
Date: Tue, 26 Nov 2019 00:49:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.4 (/)
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

On 25.11.2019 22:16, Fredrik Nyqvist wrote:
> Yes, I have tried the option you mention to edit the last commit with 
> C-x C-e and it is working fine.
> But It seems that it only allows amending the last commit if I have 
> edited a file.

Yes. Not sure how to change an arbitrary commit in Git anyway (without 
interactive rebase). The best approximation looks like this:

https://stackoverflow.com/a/48999882/615245

> As I understand it I need to edit a file and then do vc-next-action to 
> get to the log-edit buffer
> where you can do C-x C-e.

Yes.

> I could not find a way to do this if just the commit message is supposed 
> to be updated.

And that is indeed the main downside of our current solution.

(The way to do it is to edit, call vc-next-action, then undo the edit in 
the file, but commit the amended message anyway. Which could be more 
efficient).
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 25 Nov 2019 20:16:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 25 15:16:21 2019
Received: from localhost ([127.0.0.1]:49727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iZKmT-0000XW-Ao
	for submit <at> debbugs.gnu.org; Mon, 25 Nov 2019 15:16:21 -0500
Received: from mail-qv1-f42.google.com ([209.85.219.42]:40470)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iZKmR-0000XK-Ko
 for 38343 <at> debbugs.gnu.org; Mon, 25 Nov 2019 15:16:20 -0500
Received: by mail-qv1-f42.google.com with SMTP id i3so6310050qvv.7
 for <38343 <at> debbugs.gnu.org>; Mon, 25 Nov 2019 12:16:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=T3jDzKDf4AXp5OvPnp0Ayf7U/h4uUKDxhF0TXNJLDQw=;
 b=Mg5oGLWqNpq8AYKaKWrdAHy30dgsm0GXGU4QZw6DVfHBGDes0k8b7aCgu8ak/AZ1rr
 4MjYPwwO5dLugo3q0HGz+x+kzbZJ02cbosETx+wR9yUNUqD2wvfCiDxp/woTdVPjz+Ag
 l8relzzAC5hBTui0Nst1S18vRxejgiB07sD5wG2MGZ9UU0oTCGkynQMzt8Z0DjXtaQ7E
 zb1lPwK2XedidMBGGKqwbTpR9uEWIc6vG3snpYsD6sMoYS1O6Ux+Nf0xOVyh78ECdynS
 I9ShNmT/NjrAvkrtq9xkmvhbu2ZsWmtsB9XdZe/diWUOzYnT3EVEKe+AmPULsi6NLZyP
 E41w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=T3jDzKDf4AXp5OvPnp0Ayf7U/h4uUKDxhF0TXNJLDQw=;
 b=aaLARClrfaYL9itODjw9FXxD0lqeYjstbBh6NV4F6ITNX0qE5er6hgoAU2uhYUhPth
 UgeadDcarkV+UteJ6gppLt0UvgHzX/pzfVrBZYkPFT81lmvV6irlP19Tmm15a5T/6fvV
 AvcQ3lJwIFvIak5xb0tyqcrqUYusXDKswHgP8x72XIhQGXPf5qio1shJO2RFvIv4XjEN
 Wd2RIJklVHS1j/VQlkJmWEDtZdnKjVVCpguw27uLsq3PkeqBq6tvf/v7Iw0i9+ZHHOS8
 Nr1IcRYXEEICc9s3QkiyNKWM7PHxkLJnYcGkKfLGqoBuiBIbywXwAmDS+VOte5Mxc6HG
 lbcQ==
X-Gm-Message-State: APjAAAVU4JY0WtnflS6eOcpEIAyEbEfzE2zfyH3c7NoXLSpbT/Cf3Xhk
 LULAZbnAA63XbqRmovjmplv94dP1oEWT4r/Uv+ngvA==
X-Google-Smtp-Source: APXvYqz5EBWyQNx3Ici8ZpYo8pRkY79m+5/c78nue20MxkhH5naOqywjoV5uRG5uLMtS9rirpxkDRHrcnDS1n5P7LwI=
X-Received: by 2002:ad4:4106:: with SMTP id i6mr13428048qvp.175.1574712974053; 
 Mon, 25 Nov 2019 12:16:14 -0800 (PST)
MIME-Version: 1.0
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
 <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
In-Reply-To: <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
From: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
Date: Mon, 25 Nov 2019 21:16:02 +0100
Message-ID: <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@HIDDEN>
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Dmitry Gutov <dgutov@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000711b2e0598316f6f"
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 38343
Cc: 38343 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--000000000000711b2e0598316f6f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Yes, I have tried the option you mention to edit the last commit with C-x
C-e and it is working fine.
But It seems that it only allows amending the last commit if I have edited
a file.

As I understand it I need to edit a file and then do vc-next-action to get
to the log-edit buffer
where you can do C-x C-e.

I could not find a way to do this if just the commit message is supposed to
be updated.

Den m=C3=A5n 25 nov. 2019 kl 12:48 skrev Dmitry Gutov <dgutov@HIDDEN>:

> On 23.11.2019 12:01, Fredrik Nyqvist wrote:
>
> > I would like to use vc mode to edit an outgoing commit message.
> >
> > Steps to reproduce:
> > 1. emacs -Q /path/to/git/repo
> > 2. Edit a file and then
> > 3. Run vc-next-action to create a commit: C-x v v
> > 4. Write a commit message and end with C-c C-c
> > 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O
> > 6. Try to edit the commit message (log-view-modify-change-comment): e
> >
> > This message is printed:
> >
> > log-view-current-file: Unable to determine the current file
>
> Yes. This feature seems unfinished, and it was never updated for the
> newer VC systems.
>
> However, we have an option for amending the last commit (press C-x C-e
> in an already open log-edit buffer). It only works with Git and Hg now.
>

It would be good to unify these two features somehow.
>

--000000000000711b2e0598316f6f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Yes, I have tried the option you mention to edit the =
last commit with C-x C-e and it is working fine. <br></div><div>But It seem=
s that it only allows amending the last commit if I have edited a file.</di=
v><div><br></div><div>As I understand it I need to edit a file and then do =
vc-next-action to get to the log-edit buffer</div><div>where you can do C-x=
 C-e.</div><div><br></div><div>I could not find a way to do this if just th=
e commit message is supposed to be updated.</div><div><br></div><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Den m=C3=A5n 25 nov.=
 2019 kl 12:48 skrev Dmitry Gutov &lt;<a href=3D"mailto:dgutov@HIDDEN">d=
gutov@HIDDEN</a>&gt;:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">On 23.11.2019 12:01, Fredrik Nyqvist wrote:<br>
<br>
&gt; I would like to use vc mode to edit an outgoing commit message.<br>
&gt; <br>
&gt; Steps to reproduce:<br>
&gt; 1. emacs -Q /path/to/git/repo<br>
&gt; 2. Edit a file and then<br>
&gt; 3. Run vc-next-action to create a commit: C-x v v<br>
&gt; 4. Write a commit message and end with C-c C-c<br>
&gt; 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O<br>
&gt; 6. Try to edit the commit message (log-view-modify-change-comment): e<=
br>
&gt; <br>
&gt; This message is printed:<br>
&gt; <br>
&gt; log-view-current-file: Unable to determine the current file<br>
<br>
Yes. This feature seems unfinished, and it was never updated for the <br>
newer VC systems.<br>
<br>
However, we have an option for amending the last commit (press C-x C-e <br>
in an already open log-edit buffer). It only works with Git and Hg now.<br>
=C2=A0</blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
It would be good to unify these two features somehow.<br>
</blockquote></div></div>

--000000000000711b2e0598316f6f--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at 38343 <at> debbugs.gnu.org:


Received: (at 38343) by debbugs.gnu.org; 25 Nov 2019 12:16:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 25 07:16:58 2019
Received: from localhost ([127.0.0.1]:47722 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iZDIX-0002X7-OB
	for submit <at> debbugs.gnu.org; Mon, 25 Nov 2019 07:16:57 -0500
Received: from mail-wr1-f41.google.com ([209.85.221.41]:42424)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1iZDIW-0002Wt-MD
 for 38343 <at> debbugs.gnu.org; Mon, 25 Nov 2019 07:16:57 -0500
Received: by mail-wr1-f41.google.com with SMTP id a15so17743773wrf.9
 for <38343 <at> debbugs.gnu.org>; Mon, 25 Nov 2019 04:16:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=Fv6iN0IFgVxhRHJ8LkXtKGQiAzHFiyQCEna1OzIfpZM=;
 b=pyDWRIc6hsejK7OdAIdQB8H4n6pccOWqSO/nKIpf1SYnm7+VZIClgW83hD3pPaTMqn
 a4+QPDxJhtcDAsQy+IkDG2Ubu6tSoYLjcXN9ARGaX4NhsTd9+lrBbBB8HJemtQf21WTp
 4H5pZ+qvSkcju9PjKxjYVqT2ciZN1+fBgve9qpllziE0jgRTMprkqBd2kx9gNUdTmfB4
 GPvBXGvEn+zPlxOhtSkQTNCBLeV6Sw3REBvNNSOYbJt3xLjBSmhHQt5Nb5wdFrKkHxTz
 70OKhz/fBge4HIcE7S6WuSMVntOaztAcNgiGrSk7r+O8uwlY9EwfhN8KMdyc+PwtYrwZ
 hdsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=Fv6iN0IFgVxhRHJ8LkXtKGQiAzHFiyQCEna1OzIfpZM=;
 b=T/TekNRAGmgkp7elD8ShUH++U2YY3nGM+ARizk0u8tjD4gi0botabkhXj6KSJ6YgbR
 ypAhniz0jOBvY/z6U3FYFuOPzD2RCkoRbW3CmMcsB6Vh87CJfApcT6im81FglBgtCJWA
 99kXcC9pbrX+Yu18KussO2zy0iBVC/WvBhir3TyYaFwaqhiHtmnsNtM9RlFtDmJflE39
 +zZtT7cMC2v6KHBcLZtW4ztZgzjyYlXOa1i95vrWypL5cFXcGP763OkZyX9vItUuKVbU
 UVkkH/tZb1AZwlKBaQjwMAPD01Uew0iIETMXsk+c6LUaS9hyvYvZvUxUqj+tvqjgeJ3Q
 j7lw==
X-Gm-Message-State: APjAAAX/d/fd8fQrKwZ2wijb+UW46IWhdkdbOMwpFcQP7rn0PjOw5cMx
 RPY6Z6ZQfst+jxA6B7UfVBZ5TRcg
X-Google-Smtp-Source: APXvYqzZ4gHDnDWK16iRzcI92GBL251psl/FCABJdgJB5aq5X4P+RKNkWva3acAEueDJnxJJ/fZY3g==
X-Received: by 2002:adf:f3d0:: with SMTP id g16mr10841957wrp.2.1574682484602; 
 Mon, 25 Nov 2019 03:48:04 -0800 (PST)
Received: from [192.168.0.5] ([212.50.117.215])
 by smtp.googlemail.com with ESMTPSA id u203sm8243191wme.34.2019.11.25.03.48.02
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 25 Nov 2019 03:48:03 -0800 (PST)
Subject: Re: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git
 commit --amend)
To: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>, 38343 <at> debbugs.gnu.org
References: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <a190865c-a1f7-6e7f-96c2-b8299e190944@HIDDEN>
Date: Mon, 25 Nov 2019 13:48:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.4 (/)
X-Debbugs-Envelope-To: 38343
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

On 23.11.2019 12:01, Fredrik Nyqvist wrote:

> I would like to use vc mode to edit an outgoing commit message.
> 
> Steps to reproduce:
> 1. emacs -Q /path/to/git/repo
> 2. Edit a file and then
> 3. Run vc-next-action to create a commit: C-x v v
> 4. Write a commit message and end with C-c C-c
> 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O
> 6. Try to edit the commit message (log-view-modify-change-comment): e
> 
> This message is printed:
> 
> log-view-current-file: Unable to determine the current file

Yes. This feature seems unfinished, and it was never updated for the 
newer VC systems.

However, we have an option for amending the last commit (press C-x C-e 
in an already open log-edit buffer). It only works with Git and Hg now.

It would be good to unify these two features somehow.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Nov 2019 10:02:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 23 05:02:06 2019
Received: from localhost ([127.0.0.1]:55823 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iYSEt-0000Co-Ld
	for submit <at> debbugs.gnu.org; Sat, 23 Nov 2019 05:02:04 -0500
Received: from lists.gnu.org ([209.51.188.17]:52316)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iYSEs-0000Ch-7f
 for submit <at> debbugs.gnu.org; Sat, 23 Nov 2019 05:02:02 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:51224)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iYSEq-0006Uk-DN
 for bug-gnu-emacs@HIDDEN; Sat, 23 Nov 2019 05:02:02 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50,
 FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,URIBL_BLOCKED
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <fredrik.nyqvist94@HIDDEN>) id 1iYSEo-0000Wg-SU
 for bug-gnu-emacs@HIDDEN; Sat, 23 Nov 2019 05:02:00 -0500
Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:37414)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <fredrik.nyqvist94@HIDDEN>)
 id 1iYSEo-0000Vj-NP
 for bug-gnu-emacs@HIDDEN; Sat, 23 Nov 2019 05:01:58 -0500
Received: by mail-qk1-x734.google.com with SMTP id e187so8561253qkf.4
 for <bug-gnu-emacs@HIDDEN>; Sat, 23 Nov 2019 02:01:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=whXPMXi92s1qjwFN6hnKAgMOsm6R29utrvK5EEhOfYg=;
 b=ABlmPkZAoPJ730+nzDtlSPbOEiNrMuaorCRjYhCKICYgn/BRo1prHFKCdWvQ3KDEl4
 qvQg29NYnx60IrSNYLqDkb40en+sULxQE8NTlqi1XuCPdyx2qZ6x0PEtjBJCx2rlXbgA
 Ti2lF2rNI6iMEOkdU8lR/kIK5Nh4ruJGsJo9zvGIstqzojNpO+CKXgfV+hsiSsdjQ9G3
 qqI/2rhHbNLf1YJEx26zY1zJgQl78vHCpKMnWLcIAELTgt5NGtxLbDKihDGsjKkw5cl4
 kc3HxBz78TnvToQw+4Ix9Vw3toX9AZCZSbu4rbVw5ptdbswEnQDr514142AiixU7lBDB
 95Tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=whXPMXi92s1qjwFN6hnKAgMOsm6R29utrvK5EEhOfYg=;
 b=GvwCsUO1bPjXWr9MysxHARTMkxvwFrXznM+ymUyGgBf1ekoAh2s1uHX6IVdZBhkI3i
 EcMpah38ssmeaC+KfvxYMqCXl0n8JaVeuSGIpPcaX039P88TxtjqygzMaptuJz4yzw11
 aMq+RwdVKWFRhz6GGsCSNFmP5nq6Aj0M9U/7WZGXCrtMyPSLLPAu/eeKFF9jYCYL53ue
 vngck4v2BS0BRu1QdjK2hFE69xoHM7nLLe9mzryzaAMhMhpW0q1UAW2eFWIAeA+gOFBM
 cllXpXWX+TxZOxLqRKxsTDKrqq+99oCatL0c5oXgm9MVV6KwxF/fFLqWY0AE79TDlhsP
 3o2A==
X-Gm-Message-State: APjAAAXGm1QfpuxhGUXHeFo2Gu1IveBuGVx5TUdVa84+7t7XTU1Uc1Ph
 T9aa4OVIOH7zYhfOUSgSEsd7bE8LPyQyQ+n51+omNUaJ
X-Google-Smtp-Source: APXvYqy8sLst6IL3NRo0GxPiTb1eCgWP/abdU17gqlu3hfZtptNjoBZ6K3vr8aS1nYJp1HKmAEyPq0idRZ2HJ62bntM=
X-Received: by 2002:a37:514:: with SMTP id 20mr5790965qkf.321.1574503317177;
 Sat, 23 Nov 2019 02:01:57 -0800 (PST)
MIME-Version: 1.0
From: Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>
Date: Sat, 23 Nov 2019 11:01:46 +0100
Message-ID: <CAEhcwWY3DRDrYmR5QtCJbhQvGL3vhFkiCL9SzVULOTB9+J3WAg@HIDDEN>
Subject: 27.0.50; vc git: Cannot edit outgoing log (like git commit --amend)
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/alternative; boundary="000000000000eb0ace0598009ea8"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2607:f8b0:4864:20::734
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--000000000000eb0ace0598009ea8
Content-Type: text/plain; charset="UTF-8"

Hi,

I would like to use vc mode to edit an outgoing commit message.

Steps to reproduce:
1. emacs -Q /path/to/git/repo
2. Edit a file and then
3. Run vc-next-action to create a commit: C-x v v
4. Write a commit message and end with C-c C-c
5. Now Open the outgoing log (vc-log-outgoing) : C-x v O
6. Try to edit the commit message (log-view-modify-change-comment): e

This message is printed:

log-view-current-file: Unable to determine the current file


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-11-23 built on gnu
Repository revision: 6d4d00c63417e3479e978a373f252b9f2709ce39
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Recent messages:
Auto-saving...done
Specified image bit depth is not supported by XRender [2 times]

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX GNUTLS FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK3
X11 XDBE XIM MODULES THREADS PDUMPER GMP

Important settings:
  value of $LANG: sv_SE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(help-mode pp shadow sort mail-extr emacsbug message rmc puny
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
dired dired-loaddefs tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 49936 10334)
 (symbols 48 6110 0)
 (strings 32 15815 1297)
 (string-bytes 1 516576)
 (vectors 16 10114)
 (vector-slots 8 132119 14836)
 (floats 8 23 70)
 (intervals 56 347 6)
 (buffers 1000 16))

--000000000000eb0ace0598009ea8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>I would like to use vc mode to edit an outgoing=
 commit message.<br><br>Steps to reproduce:<br>1. emacs -Q /path/to/git/rep=
o<br>2. Edit a file and then<br>3. Run vc-next-action to create a commit: C=
-x v v<br>4. Write a commit message and end with C-c C-c<br>5. Now Open the=
 outgoing log (vc-log-outgoing) : C-x v O<br>6. Try to edit the commit mess=
age (log-view-modify-change-comment): e<br><br>This message is printed:<br>=
<br>log-view-current-file: Unable to determine the current file<br><br><br>=
In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)<br=
>=C2=A0of 2019-11-23 built on gnu<br>Repository revision: 6d4d00c63417e3479=
e978a373f252b9f2709ce39<br>Repository branch: master<br>Windowing system di=
stributor &#39;The X.Org Foundation&#39;, version 11.0.12004000<br>System D=
escription: Debian GNU/Linux 10 (buster)<br><br>Recent messages:<br>Auto-sa=
ving...done<br>Specified image bit depth is not supported by XRender [2 tim=
es]<br><br>Configured features:<br>XPM JPEG TIFF GIF PNG SOUND DBUS GSETTIN=
GS GLIB NOTIFY INOTIFY<br>LIBSELINUX GNUTLS FREETYPE HARFBUZZ XFT ZLIB TOOL=
KIT_SCROLL_BARS GTK3<br>X11 XDBE XIM MODULES THREADS PDUMPER GMP<br><br>Imp=
ortant settings:<br>=C2=A0 value of $LANG: sv_SE.UTF-8<br>=C2=A0 locale-cod=
ing-system: utf-8-unix<br><br>Major mode: Dired by name<br><br>Minor modes =
in effect:<br>=C2=A0 tooltip-mode: t<br>=C2=A0 global-eldoc-mode: t<br>=C2=
=A0 electric-indent-mode: t<br>=C2=A0 mouse-wheel-mode: t<br>=C2=A0 tool-ba=
r-mode: t<br>=C2=A0 menu-bar-mode: t<br>=C2=A0 file-name-shadow-mode: t<br>=
=C2=A0 global-font-lock-mode: t<br>=C2=A0 font-lock-mode: t<br>=C2=A0 blink=
-cursor-mode: t<br>=C2=A0 auto-composition-mode: t<br>=C2=A0 auto-encryptio=
n-mode: t<br>=C2=A0 auto-compression-mode: t<br>=C2=A0 buffer-read-only: t<=
br>=C2=A0 line-number-mode: t<br>=C2=A0 transient-mark-mode: t<br><br>Load-=
path shadows:<br>None found.<br><br>Features:<br>(help-mode pp shadow sort =
mail-extr emacsbug message rmc puny<br>format-spec rfc822 mml easymenu mml-=
sec password-cache epa derived epg<br>epg-config gnus-util rmail rmail-load=
defs text-property-search time-date<br>subr-x seq byte-opt gv bytecomp byte=
-compile cconv mm-decode mm-bodies<br>mm-encode mail-parse rfc2231 mailabbr=
ev gmm-utils mailheader cl-loaddefs<br>cl-lib sendmail rfc2047 rfc2045 ietf=
-drums mm-util mail-prsvr mail-utils<br>dired dired-loaddefs tooltip eldoc =
electric uniquify ediff-hook vc-hooks<br>lisp-float-type mwheel term/x-win =
x-win term/common-win x-dnd tool-bar<br>dnd fontset image regexp-opt fringe=
 tabulated-list replace newcomment<br>text-mode elisp-mode lisp-mode prog-m=
ode register page tab-bar menu-bar<br>rfn-eshadow isearch timer select scro=
ll-bar mouse jit-lock font-lock<br>syntax facemenu font-core term/tty-color=
s frame minibuffer cl-generic<br>cham georgian utf-8-lang misc-lang vietnam=
ese tibetan thai tai-viet lao<br>korean japanese eucjp-ms cp51932 hebrew gr=
eek romanian slovak czech<br>european ethiopic indian cyrillic chinese comp=
osite charscript charprop<br>case-table epa-hook jka-cmpr-hook help simple =
abbrev obarray<br>cl-preloaded nadvice loaddefs button faces cus-face macro=
exp files<br>text-properties overlay sha1 md5 base64 format env code-pages =
mule<br>custom widget hashtable-print-readable backquote threads dbusbind<b=
r>inotify dynamic-setting system-font-setting font-render-setting<br>move-t=
oolbar gtk x-toolkit x multi-tty make-network-process emacs)<br><br>Memory =
information:<br>((conses 16 49936 10334)<br>=C2=A0(symbols 48 6110 0)<br>=
=C2=A0(strings 32 15815 1297)<br>=C2=A0(string-bytes 1 516576)<br>=C2=A0(ve=
ctors 16 10114)<br>=C2=A0(vector-slots 8 132119 14836)<br>=C2=A0(floats 8 2=
3 70)<br>=C2=A0(intervals 56 347 6)<br>=C2=A0(buffers 1000 16))<br></div>

--000000000000eb0ace0598009ea8--
Acknowledgement sent to Fredrik Nyqvist <fredrik.nyqvist94@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#38343; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 4 Mar 2025 04:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.