GNU bug report logs - #38347
gnome-contacts

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38347 in the body.
You can then email your comments to 38347 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnome-contacts
Date: Sat, 23 Nov 2019 11:32:31 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached file containing patch to add gnome-contacts.

Thank you!

Regards,
RG.

[0001-Add-gnome-contacts.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 38347 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 38347 <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts
Date: Sat, 23 Nov 2019 19:51:10 +0100

[Message part 1 (text/plain, inline)]

Raghav,

Raghav Gururajan 写道：
> Please find the attached file containing patch to add 
> gnome-contacts.

Thank you!  Congratulations on your first patch, and may there be 
many more.

I was going to fix the points below myself, but then they 
multiplied and hey, I can always say it's a good lesson for you, 
right?  Just send the result to this thread with ‘v2’ clearly in 
the subject line.

* Using ‘name’ in source URIs is harmless but also completely 
 useless.  Just use:

   (uri (string-append "mirror://gnome/sources/gnome-contacts/"
                       (version-major+minor version) "/"
                       "gnome-contacts-" version ".tar.xz"))

* Could you explain *why* generate-vapis needs to be done 
 manually?  For a mostly non-GNOMEhead like me, it's just black 
 magic.

* Nitpick: the ‘`’ of `(#:phases should fall under the ‘(’ of 
 (arguments:

   (arguments
    `(#:phases

 You can use C-M-q in emacs or run etc/indent-code.el manually to 
 indent the code for you.

* You need to move inputs that appear in ‘guix gc --references 
 /gnu/store/…gnome-contacts…’ from (native-inputs) to (inputs).

* Fix ‘dockbook-xsl’ typo.

* Since you're rewriting most *inputs anyway, please order them 
 alphabetically.

* Synopses don't need to include the name of the programme or a 
 leading article (‘a’):

   (synopsis "GNOME's integrated address book")

* The description is far too short, and just not very relevant to 
 me.

 I took a look at the README; what about:

   (description
    "Contacts is GNOME's integrated address book.  It organizes 
    contact                                         
information from all your online and offline sources, and provides 
a central                                     
place to:                                                                                                        
@enumerate                                                                                                       
@item search for and view contacts,                                                                              
@item edit contact details and make new contacts,                                                                
@item integrate with online address books,                                                                       
@item automatically link contacts from different online sources.                                                 
@end enumerate\n")

* Add ‘license:’ prefix to gpl2 (without it, Guix won't even 
 work).

* A randomly chosen source file 
 (https://gitlab.gnome.org/GNOME/gnome-contacts/blob/master/src/cc-crop-area.c) 
 says ‘or any later version’.  This makes the licence gpl2+, not 
 gpl2 (-only), unless there are files that lack this wording. 
 Could you check?

                                * * *

I'm happy to hear that you have more patches planned.  Please 
check them for similar points and send them to guix-patches at 
gnu.org.

Thanks again!

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38347 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 38347 <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Sat, 23 Nov 2019 15:56:49 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached file containing revised patch for gnome-
contacts.

Thank you!

Regards,
RG.

[0004-gnu-Add-gnome-contacts.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 38347 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 38347 <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Sun, 8 Dec 2019 22:36:49 +0100

[Message part 1 (text/plain, inline)]

Hey,

I took your patch and applied it with some caveats to master. I updated
to 3.32.

gnome-contacts launches when installed, but it's not possible to add any
local contacts or remote ones. So there is still some work left.

~Jonathan

On 23.11.19 21:56, Raghav Gururajan wrote:
> Hello Guix!
>
> Please find the attached file containing revised patch for gnome-
> contacts.
>
> Thank you!
>
> Regards,
> RG.
>

[0001-gnu-Add-gnome-contacts.patch (text/x-patch, attachment)]

Message #19 received at 38347-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 38347-done <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Sun, 08 Dec 2019 23:16:24 +0100

Hi,

Raghav Gururajan <raghavgururajan <at> disroot.org> skribis:

> From 28cb5a45af5ff85365c5bcb4745f4e87d9d3d0bd Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 23 Nov 2019 15:52:17 -0500
> Subject: [PATCH 4/4] gnu: Add gnome-contacts.
>
> * gnu/packages/gnome.scm (gnome-contacts): New Variable.

I merged the two patches, addressed the ‘guix lint’ warnings, and pushed
as 4e868d22e6fedb439910c50bb5c61ab712a479be with a followup commit.

I tried it under GNOME in a VM and it’s not entirely clear that it’s
working as expected: it seems to be expecting to import the address book
from an online service but doesn’t know of any?

Thank you,
Ludo’.

Message #22 received at 38347 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Tobias Geerinckx-Rice
 <me <at> tobias.gr>
Cc: 38347 <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Mon, 09 Dec 2019 07:39:29 -0500

[Message part 1 (text/plain, inline)]

Hello Jonathan!

> I took your patch and applied it with some caveats to master. I
> updated
> to 3.32.
> 
> gnome-contacts launches when installed, but it's not possible to add
> any
> local contacts or remote ones. So there is still some work left.

Thanks so much.

I believe gnome-contacts uses evolution-data-server for data
management. Could you please try with `evolution-data-server` as
propagated-input?

Thank you!

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 38347-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 38347-done <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Mon, 09 Dec 2019 07:44:32 -0500

[Message part 1 (text/plain, inline)]

Hello Ludo!

> I merged the two patches, addressed the ‘guix lint’ warnings, and
> pushed
> as 4e868d22e6fedb439910c50bb5c61ab712a479be with a followup commit.
> 
> I tried it under GNOME in a VM and it’s not entirely clear that it’s
> working as expected: it seems to be expecting to import the address
> book
> from an online service but doesn’t know of any?

Thank you very much.

I believe it can be tried with 'evolution-data-server' as propagated
input.

Let me try and get back to you.

AFAIK, it can create local contacts or sync contacts from online
accounts (WebDAV).

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 38347-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 38347-done <at> debbugs.gnu.org
Subject: Re: [bug#38347] gnome-contacts v2
Date: Fri, 20 Dec 2019 23:28:52 -0500

[Message part 1 (text/plain, inline)]

Hello Ludo!

> > I merged the two patches, addressed the ‘guix lint’ warnings, and
> > pushed
> > as 4e868d22e6fedb439910c50bb5c61ab712a479be with a followup commit.
> > 
> > I tried it under GNOME in a VM and it’s not entirely clear that
> > it’s
> > working as expected: it seems to be expecting to import the address
> > book
> > from an online service but doesn’t know of any?
> 
> Thank you very much.
> 
> I believe it can be tried with 'evolution-data-server' as propagated
> input.
> 
> Let me try and get back to you.
> 
> AFAIK, it can create local contacts or sync contacts from online
> accounts (WebDAV).

The application is working fine on my end. No need of 'eds' as
propagated input.

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.