GNU bug report logs - #38400
[PATCH] gnu: feh: Adapt tests for imlib2 1.6.

Previous Next

Package: guix-patches;

Reported by: Pierre Langlois <pierre.langlois <at> gmx.com>

Date: Wed, 27 Nov 2019 10:51:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38400 in the body.
You can then email your comments to 38400 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38400; Package guix-patches. (Wed, 27 Nov 2019 10:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 27 Nov 2019 10:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
Date: Wed, 27 Nov 2019 10:49:48 +0000
[Message part 1 (text/plain, inline)]
Hello Guix!

Since we updated imlib2 to version 1.6 the feh test suite was failing,
however it looks harmless. The output expectation just needs tweaking a
little.

I've reported it upstream https://github.com/derf/feh/issues/497 but in
the meantime, here's a patch for downstream! I don't think such a patch
is suitable upstream as it would mean the tests would fail on previous
versions of imlib2.

[0001-gnu-feh-Adapt-tests-for-imlib2-1.6.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Thanks,
Pierre

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Wed, 27 Nov 2019 23:37:01 GMT) Full text and rfc822 format available.

Notification sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
bug acknowledged by developer. (Wed, 27 Nov 2019 23:37:02 GMT) Full text and rfc822 format available.

Message #10 received at 38400-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Langlois <pierre.langlois <at> gmx.com>, 38400-done <at> debbugs.gnu.org
Subject: Re: [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
Date: Thu, 28 Nov 2019 00:36:37 +0100
[Message part 1 (text/plain, inline)]
Pierre Langlois <pierre.langlois <at> gmx.com> writes:

> Hello Guix!
>
> Since we updated imlib2 to version 1.6 the feh test suite was failing,
> however it looks harmless. The output expectation just needs tweaking a
> little.
>
> I've reported it upstream https://github.com/derf/feh/issues/497 but in
> the meantime, here's a patch for downstream! I don't think such a patch
> is suitable upstream as it would mean the tests would fail on previous
> versions of imlib2.

Thanks!  Pushed in 9943d238e9f07dccae973b641eb7738637ce95fb.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 26 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.