GNU bug report logs - #38421
27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Filipp Gunbin <fgunbin@HIDDEN>; Keywords: patch; dated Thu, 28 Nov 2019 19:21:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Added tag(s) patch. Request was from Filipp Gunbin <fgunbin@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 38421 <at> debbugs.gnu.org:


Received: (at 38421) by debbugs.gnu.org; 28 Nov 2019 21:48:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 28 16:48:22 2019
Received: from localhost ([127.0.0.1]:59207 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iaRe9-0006zr-O3
	for submit <at> debbugs.gnu.org; Thu, 28 Nov 2019 16:48:21 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:39627)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fgunbin@HIDDEN>)
 id 1iaRe7-0006zY-Cf; Thu, 28 Nov 2019 16:48:20 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C96D422824;
 Thu, 28 Nov 2019 16:48:13 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 28 Nov 2019 16:48:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h=
 from:to:subject:in-reply-to:date:message-id:mime-version
 :content-type; s=fm1; bh=vQ5ferCqWAAoXWQb/1jbJ/Xf7gYDHUSTM1amIV+
 BjSk=; b=d/+zc/jiDmtXuMvq88Ye867uNBwkZNyVkZNlI//yMHBbpzE0Hp/c9pw
 zSZMEPQLCqYihwdOy3hzB/IZXC4PV4vo7tHzs0H7D8xvJF0vtDPVvSzM3ulT1B1b
 d6ICYrI4/9neBDtT6wCGE/3nuTM9FjrW0YVl8eUeGslx9VVsvKYMakkHytr0hnfJ
 VzBU19M3+T651vJrVpqfJ1J2chrWW3Mg2CdGsenkhcifQ/49wcTDnp8m7coVxkfx
 If3ZGlWs5J5kvrFyzgjQoWo2tOYDzMLcqMLVifnfl0E7in3GgFxGXDycGGgmMHGe
 wVQsuFQ8D3YDd4rQFXGUCYJatorEIYQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vQ5ferCqWAAoXWQb/
 1jbJ/Xf7gYDHUSTM1amIV+BjSk=; b=cvJdMIhG7slAQKbHu/Fg8Q000lFzEI10P
 qSQJAmgKZpqTAnNcIBp4+pfaGbs1Y8BAj5ECjwb0/yaUbCLFtazw46X3HDWaIDCH
 S8U+zuOugNvXftYHgTLx6BHpBKKSYtxLHVflP8z+N8MOyjS6eo7eqvz16UXRARmx
 w0pkkTsACjC4mfvp00qU5PVXlQT0hxdT2nvqryVaYLN844coKtVumDfhSqZQUoB6
 kmdl9XufIthL0NIjLkn/hrXquiUgI9cEa6sI6gBBzcQiR2+a7/x6OlKg0TvD9IqX
 LC86F8/6UbAWlngcVCXhivfC9ts00vS1O89QANKHXZ1+oPx2pRhuA==
X-ME-Sender: <xms:nUDgXbG13qaF6iqdNywyVmy_d4Ix8P2VQS6vd1jIDmsQ_oo1apQShw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeijedgudehtdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfgffkfggtgesmhdtre
 ertdertdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehf
 rghsthhmrghilhdrfhhmqeenucfkphepkeefrddutddvrddugeejrddufedtnecurfgrrh
 grmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmnecuvehl
 uhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:nUDgXXkDOYDxhJLFwCfK-7tpBCv9iTuuhiffUiltZV2WjzhU_S50Sg>
 <xmx:nUDgXZXFUTFTjl2Z0Rd2St7UzSVBBtGO5nnA4m7zKS7AIs7gnq-_dw>
 <xmx:nUDgXT03om4OAxP7JInP3VnE-kUVFsvTsqfY-zxmAmNOfOZXdGoyFw>
 <xmx:nUDgXaI_kFas3KO0fsUW5c0U4JqmmYTqnsliFXurIK6r_lrY073kaw>
Received: from fgunbin.local (unknown [83.102.147.130])
 by mail.messagingengine.com (Postfix) with ESMTPA id 065643060061;
 Thu, 28 Nov 2019 16:48:12 -0500 (EST)
From: Filipp Gunbin <fgunbin@HIDDEN>
To: bug#38421 <38421 <at> debbugs.gnu.org>
Subject: Re: Status: 27.0.50; Gnus fontifies patch attachments when
 gnus-visual is nil
In-Reply-To: bug's message of "Thu, 28 Nov 2019 20:20:54 +0000"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin)
Date: Fri, 29 Nov 2019 00:48:11 +0300
Message-ID: <m2lfrzu0ys.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 38421
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain

tags 38421 + patch
quit


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Fontify-inline-article-parts-only-if-gnus-visual-say.patch
Content-Description: patch

From 5ce40fc8e81a82d173e9cb17fa3390369b9b87f4 Mon Sep 17 00:00:00 2001
From: Filipp Gunbin <fgunbin@HIDDEN>
Date: Thu, 28 Nov 2019 23:24:40 +0300
Subject: [PATCH] Fontify inline article parts only if gnus-visual says to do
 so

* lisp/gnus/mm-view.el (mm-display-inline-fontify): Check gnus-visual
before calling font-lock-ensure.
---
 lisp/gnus/mm-view.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 559ec7a669..3762e866fb 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -32,6 +32,7 @@
 
 (autoload 'gnus-completing-read "gnus-util")
 (autoload 'gnus-article-prepare-display "gnus-art")
+(autoload 'gnus-visual-p "gnus")
 (autoload 'vcard-parse-string "vcard")
 (autoload 'vcard-format-string "vcard")
 (autoload 'fill-flowed "flow-fill")
@@ -499,8 +500,9 @@ mm-display-inline-fontify
 			 (copy-sequence auto-mode-alist))))
 	      (set-auto-mode)
 	      (setq mode major-mode)))
-	  ;; Do not fontify if the guess mode is fundamental.
-	  (unless (eq major-mode 'fundamental-mode)
+          (when (and (gnus-visual-p 'article-highlight 'highlight)
+                     ;; Do not fontify if the guessed mode is fundamental
+                     (not (eq major-mode 'fundamental-mode)))
 	    (font-lock-ensure))))
       (setq text (buffer-string))
       (when (eq mode 'diff-mode)
-- 
2.24.0


--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#38421; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Nov 2019 19:20:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 28 14:20:47 2019
Received: from localhost ([127.0.0.1]:59149 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iaPLL-0001JT-KT
	for submit <at> debbugs.gnu.org; Thu, 28 Nov 2019 14:20:47 -0500
Received: from lists.gnu.org ([209.51.188.17]:49528)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fgunbin@HIDDEN>) id 1iaPLJ-0001JE-V6
 for submit <at> debbugs.gnu.org; Thu, 28 Nov 2019 14:20:46 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35443)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <fgunbin@HIDDEN>) id 1iaPLE-0007wJ-KK
 for bug-gnu-emacs@HIDDEN; Thu, 28 Nov 2019 14:20:43 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_40,FREEMAIL_FROM,
 RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled
 version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <fgunbin@HIDDEN>) id 1iaP9X-0003vD-AZ
 for bug-gnu-emacs@HIDDEN; Thu, 28 Nov 2019 14:08:36 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49719)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <fgunbin@HIDDEN>) id 1iaP9V-0003WN-Ju
 for bug-gnu-emacs@HIDDEN; Thu, 28 Nov 2019 14:08:34 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E59F522764
 for <bug-gnu-emacs@HIDDEN>; Thu, 28 Nov 2019 14:08:30 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 28 Nov 2019 14:08:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h=
 from:to:subject:date:message-id:mime-version:content-type; s=
 fm1; bh=ZJuQJYjtdrGl+qrues8TJQFUbWF3TVtl9jgismwo9eM=; b=Wtg/kywF
 wHlS/iO28eMzdsqaQkXIrLFZ7JdDfJsng0voVWrnc1grLTm3Jw3d5++JsM5NKxmE
 C6p6SKM+DwErdV4aknK0hFRpKhbyL2MgkVUFgMvjEVnCh51nEM0nhIVSEI22k8Ov
 ooheJDGB+OB82U/UVItPHxM3IlYKWDDfdJ+l1MR0ohHMe/dfUFKOaUA/fDDJ17kq
 K7Id3iIk7B1xR7Y8OW8UcrprMus9Uu9Kjt/gM2KssnB2OcwBer3myga+z2cRJzy7
 BaarTsMMEQTt6rocDJRkOJfELuCByAimkZ3jfTTm+Nvq/StFq/o+e3nvcREfnXwD
 VOEsUAljNEodcQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:message-id
 :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm1; bh=ZJuQJYjtdrGl+qrues8TJQFUbWF3T
 Vtl9jgismwo9eM=; b=qhusCMZ3vZheUKFy+zgfH3gUvDCWCIJwrRq4QHD9uz/49
 6pV5u2Z0PlKSVkesEBNplTFeE8QTlGSASeSTrdMI0uXkpcFbtKKl7fI6wHAPAduL
 cD9RUvEAVe7FPhIlaj96SaE5YfCIMYJx+Zwn9cf1ATmlTQokM04ihrS6l4panj5x
 DnSssgC+98wqh8bKkCYHLUgVG5MyYQQGbHuf3KpNISwNARMX5uWws66V2k4YCtoM
 +BI9V5GySre6enGZ3BbSvwn6IIh0B3PWaWLgYCG2kP/wzXdRUef4hV0GWLcCILu7
 +/P7VxB/of9PCbJX749kllqBTBEF2St5jitvW/uHQ==
X-ME-Sender: <xms:LhvgXdjL6kMXnPTv5sNT0vLM8bSu2pidroedhduEA7RosBtFpcgvyg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeijedguddukecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttd
 dttdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghs
 thhmrghilhdrfhhmqeenucfkphepudekhedrfedvrdeikedrudefheenucfrrghrrghmpe
 hmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmhenucevlhhushht
 vghrufhiiigvpedt
X-ME-Proxy: <xmx:LhvgXbHQq3LYwznLyq-c3enLSUoXXkVIGGw0yMF8dY-4zpZSosSNLQ>
 <xmx:LhvgXWI-PxYPV4xkNwUW2rmkacfW2ZB40NjnrWMtafcEAzZyDCSSfA>
 <xmx:LhvgXeAaNOo5NyP5mwzJARBvSsEpwyLVqz2GivJSAhPMDByxLWzi2Q>
 <xmx:LhvgXYcdJDV2-PcrV9SPKIebS52gV0H0iJNCFRh3_TGBEoICY5M7GA>
Received: from fgunbin.local (unknown [185.32.68.135])
 by mail.messagingengine.com (Postfix) with ESMTPA id 15E8D80059
 for <bug-gnu-emacs@HIDDEN>; Thu, 28 Nov 2019 14:08:29 -0500 (EST)
From: Filipp Gunbin <fgunbin@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil
Mail-Followup-To: bug-gnu-emacs@HIDDEN
Date: Thu, 28 Nov 2019 22:08:28 +0300
Message-ID: <m2zhgfvmxf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 66.111.4.25
X-Spam-Score: 0.4 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)


When gnus-visual is nil, attachments of type text/x-patch (and probably
others) still get fontified when Gnus displays them inline.

I have a patch, will attach it soon.
Thanks.


In GNU Emacs 27.0.50 (build 9, x86_64-apple-darwin19.0.0, NS appkit-1894.10 Version 10.15.1 (Build 19B88))
 of 2019-11-28 built on fgunbin.local
Repository revision: b05aa8d742d80aeb692c54289e8ccb074a68bf51
Repository branch: master
System Description:  Mac OS X 10.15.1




Acknowledgement sent to Filipp Gunbin <fgunbin@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#38421; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 28 Nov 2019 22:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.