GNU bug report logs - #38425
27.0.50; [PATCH] vc-hg-create-tag: Possibility to create a branch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38425 in the body.
You can then email your comments to 38425 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to create a branch
Date: Fri, 29 Nov 2019 17:03:33 +0200

[Message part 1 (text/plain, inline)]

Hello.

Mercurial supports two kind of branches: named branch and bookmark.

vc-hg-create-tag can create only a bookmark (Bug#17586).

This patch adds possibility to create a named branch.

[0001-vc-hg-create-tag-Possibility-to-create-a-branch.patch (application/octet-stream, attachment)]

Message #8 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>, 38425 <at> debbugs.gnu.org
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Fri, 29 Nov 2019 17:14:16 +0200

On 29.11.2019 17:03, Andrii Kolomoiets wrote:
> +*** New user option 'vc-hg-create-bookmark' controls whether a bookmark
> +or branch will be created when you invoke 'C-u C-x v s' ('vc-create-tag')

Do some Mercurial users or projects predominantly work with branches, 
while others - with bookmarks?

Message #11 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 38425 <at> debbugs.gnu.org
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Fri, 29 Nov 2019 20:30:44 +0200

On 29 Nov 2019, at 17:14, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> 
> On 29.11.2019 17:03, Andrii Kolomoiets wrote:
>> +*** New user option 'vc-hg-create-bookmark' controls whether a bookmark
>> +or branch will be created when you invoke 'C-u C-x v s' ('vc-create-tag')
> 
> Do some Mercurial users or projects predominantly work with branches, while others - with bookmarks?

I think so. They even can be used together in one repository.

Message #14 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38425 <at> debbugs.gnu.org
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Sat, 30 Nov 2019 00:21:59 +0200

On 29.11.2019 20:30, Andrii Kolomoiets wrote:
> On 29 Nov 2019, at 17:14, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
>>
>> On 29.11.2019 17:03, Andrii Kolomoiets wrote:
>>> +*** New user option 'vc-hg-create-bookmark' controls whether a bookmark
>>> +or branch will be created when you invoke 'C-u C-x v s' ('vc-create-tag')
>>
>> Do some Mercurial users or projects predominantly work with branches, while others - with bookmarks?
> 
> I think so. They even can be used together in one repository.

That "even" is why I'm asking. If, on average, the user has to deal with 
both then the new option won't help. vc-hg might as well only one or the 
other in vc-create-tag, leaving the alternative to the command line.

Message #17 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 38425 <at> debbugs.gnu.org
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Sat, 30 Nov 2019 01:01:30 +0200

On 30 Nov 2019, at 00:21, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> 
> On 29.11.2019 20:30, Andrii Kolomoiets wrote:
>> On 29 Nov 2019, at 17:14, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
>>> 
>>> On 29.11.2019 17:03, Andrii Kolomoiets wrote:
>>>> +*** New user option 'vc-hg-create-bookmark' controls whether a bookmark
>>>> +or branch will be created when you invoke 'C-u C-x v s' ('vc-create-tag')
>>> 
>>> Do some Mercurial users or projects predominantly work with branches, while others - with bookmarks?
>> I think so. They even can be used together in one repository.
> 
> That "even" is why I'm asking. If, on average, the user has to deal with both then the new option won't help. vc-hg might as well only one or the other in vc-create-tag, leaving the alternative to the command line.

Why not? I've added option 'ask' so user can create branch or bookmark. Default value t is set for backward capability.

Message #20 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 38425 <at> debbugs.gnu.org
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Sat, 30 Nov 2019 01:03:57 +0200

On 30 Nov 2019, at 01:01, Andrii Kolomoiets <andreyk.mad <at> gmail.com> wrote:
> 
> On 30 Nov 2019, at 00:21, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
>> 
>> On 29.11.2019 20:30, Andrii Kolomoiets wrote:
>>> On 29 Nov 2019, at 17:14, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
>>>> 
>>>> On 29.11.2019 17:03, Andrii Kolomoiets wrote:
>>>>> +*** New user option 'vc-hg-create-bookmark' controls whether a bookmark
>>>>> +or branch will be created when you invoke 'C-u C-x v s' ('vc-create-tag')
>>>> 
>>>> Do some Mercurial users or projects predominantly work with branches, while others - with bookmarks?
>>> I think so. They even can be used together in one repository.
>> 
>> That "even" is why I'm asking. If, on average, the user has to deal with both then the new option won't help. vc-hg might as well only one or the other in vc-create-tag, leaving the alternative to the command line.
> 
> Why not? I've added option 'ask' so user can create branch or bookmark. Default value t is set for backward capability.

Sorry, backward compatibility.

Message #23 received at 38425 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38425 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#38425: 27.0.50; [PATCH] vc-hg-create-tag: Possibility to
 create a branch
Date: Sun, 09 Aug 2020 14:28:12 +0200

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

>>> That "even" is why I'm asking. If, on average, the user has to deal
>>> with both then the new option won't help. vc-hg might as well only
>>> one or the other in vc-create-tag, leaving the alternative to the
>>> command line.
>> 
>> Why not? I've added option 'ask' so user can create branch or
>> bookmark. Default value t is set for backward capability.
>
> Sorry, backward compatibility.

I think that makes sense, so I've applied your patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.